Groups > linux.debian.maint.java > #11799

Re: RFS : libcharts4j-java

Path	csiph.com!4.us.feeder.erje.net!3.eu.feeder.erje.net!feeder.erje.net!news.in-chemnitz.de!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Andreas Tille <andreas@an3as.eu>
Newsgroups	linux.debian.maint.java
Subject	Re: RFS : libcharts4j-java
Date	Sun, 26 Jul 2020 10:40:02 +0200
Message-ID	<AwKmm-6Yz-9@gated-at.bofh.it> (permalink)
References	<Awl4B-8F-1@gated-at.bofh.it> <Awm0F-I2-1@gated-at.bofh.it> <AwA3D-Fx-5@gated-at.bofh.it>
X-Mailbox-Line	From debian-java-request@lists.debian.org Sun Jul 26 08:31:29 2020
Old-Return-Path	<andreas@an3as.eu>
X-Amavis-Spam-Status	No, score=-7 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, LDO_WHITELIST=-5] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate: -4.6
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.10.1 (2018-07-13)
X-Mailing-List	<debian-java@lists.debian.org> archive/latest/22393
List-ID	<debian-java.lists.debian.org>
List-URL	<https://lists.debian.org/debian-java/>
List-Archive	https://lists.debian.org/msgid-search/20200726083116.GI8994@an3as.eu
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Sun, 26 Jul 2020 10:31:16 +0200
X-Original-Message-ID	<20200726083116.GI8994@an3as.eu>
X-Original-References	<fe9a914b-2073-eb8b-6228-308b3831f703@free.fr> <298942a9-b205-5dd9-bcd2-a752e9934225@apache.org> <30c9aaf8-e31b-7cb2-ffa0-d21aa3d7d539@apache.org>
Xref	csiph.com linux.debian.maint.java:11799

Show key headers only | View raw

Hi Emmanuel,

On Sat, Jul 25, 2020 at 11:36:08PM +0200, Emmanuel Bourg wrote:
> On 25/07/2020 08:39, Emmanuel Bourg wrote:
> 
> >> Could someone please review and sponsor it when time permits?
> > 
> > Hi Pierre, I'll take care of it.
> 
> The package has been uploaded and is now in the NEW queue.

Thanks a lot for sponsoring.  That package is a precondition for some
long wanted Debian Med package.
 
> Technically the package was good, I just made a few minor changes:
> - I've removed the -doc package, it's rarely used and javadoc is a
> recurrent source of troubles on JDK upgrades.
> - I've removed the +dfsg suffix, I have a personal preference for
> "clean" version numbers, and the removal of the junit jar from the
> upstream source isn't significant enough to justify using this prefix in
> my opinion.

I admit I personally think that having some suffix (alternatively for
+dfsg the suffix +ds is used for "Debian source) is very informative
when deriving from the original upstream download tarball.  There is
also a lintian warning (or info?) issued if Files-Excluded is used but
the change is not "advertised" in a version suffix.  I agree here with
lintian due to my personal preference.

> - I've renamed the source package from libcharts4j to charts4j

Could you please remove the now unused Git repository in Salsa to avoid
confusion?

> - The dependency on javahelper wasn't necessary
> - The dependency on the maven-compiler-plugin is implicit when using
> maven-debian-helper

I'm also always thankful for this kind of hints. 

Thanks again for all your Java support

     Andreas.

-- 
http://fam-tille.de

Back to linux.debian.maint.java | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

RFS : libcharts4j-java Pierre Gruet <pgtdebian@free.fr> - 2020-07-25 07:40 +0200
  Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-25 08:40 +0200
    Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-25 23:40 +0200
      Re: RFS : libcharts4j-java Pierre Gruet <pgtdebian@free.fr> - 2020-07-26 09:50 +0200
        Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-26 13:00 +0200
      Re: RFS : libcharts4j-java Andreas Tille <andreas@an3as.eu> - 2020-07-26 10:40 +0200
        Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-26 17:20 +0200

csiph-web