Groups > linux.debian.maint.java > #11797

Re: RFS : libcharts4j-java

From	Pierre Gruet <pgtdebian@free.fr>
Newsgroups	linux.debian.maint.java
Subject	Re: RFS : libcharts4j-java
Date	2020-07-26 09:50 +0200
Message-ID	<AwJzX-6tf-1@gated-at.bofh.it> (permalink)
References	<Awl4B-8F-1@gated-at.bofh.it> <Awm0F-I2-1@gated-at.bofh.it> <AwA3D-Fx-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Emmanuel,

Le 25/07/2020 à 23:36, Emmanuel Bourg a écrit :
> On 25/07/2020 08:39, Emmanuel Bourg wrote:
> 
>>> Could someone please review and sponsor it when time permits?
>>
>> Hi Pierre, I'll take care of it.
> 
> The package has been uploaded and is now in the NEW queue.
>

Thanks a lot for taking time to review and give advice!

> 
> Technically the package was good, I just made a few minor changes:
> - I've removed the -doc package, it's rarely used and javadoc is a
> recurrent source of troubles on JDK upgrades.
>

OK, so you are giving the general advice to never package javadoc?

> - I've removed the +dfsg suffix, I have a personal preference for
> "clean" version numbers, and the removal of the junit jar from the
> upstream source isn't significant enough to justify using this prefix in
> my opinion.
>

Understood, I will keep in mind that such changes do not necessarily
deserve a suffix to the version number.

> - I've renamed the source package from libcharts4j to charts4j
> - The dependency on javahelper wasn't necessary
> - The dependency on the maven-compiler-plugin is implicit when using
> maven-debian-helper
>

Acknowledged!

> 
> Emmanuel Bourg
> 

Thanks again for your help,
Pierre Gruet

Back to linux.debian.maint.java | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

RFS : libcharts4j-java Pierre Gruet <pgtdebian@free.fr> - 2020-07-25 07:40 +0200
  Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-25 08:40 +0200
    Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-25 23:40 +0200
      Re: RFS : libcharts4j-java Pierre Gruet <pgtdebian@free.fr> - 2020-07-26 09:50 +0200
        Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-26 13:00 +0200
      Re: RFS : libcharts4j-java Andreas Tille <andreas@an3as.eu> - 2020-07-26 10:40 +0200
        Re: RFS : libcharts4j-java Emmanuel Bourg <ebourg@apache.org> - 2020-07-26 17:20 +0200

csiph-web