Groups | Search | Server Info | Login | Register

Groups > linux.debian.maint.hams > #11174

Re: seeking review of pat 0.19.2

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

* re-folding in debian-hams, as the `pat' package is in that group

On Mon, Mar 16, 2026 at 11:15:27AM +0800, Otto Kekäläinen wrote:
> Hi Federico!
> 
> On Mon, 16 Mar 2026 at 01:30, Federico Grau <donfede@casagrau.org> wrote:
> >
> > Hello debian-hams and tmancill --
> >
> > I've packaged pat v0.19.2 and pushed my work to salsa.d.o .
> >
> >      https://tracker.debian.org/pkg/pat
> 
> I added a small comment on
> https://salsa.debian.org/debian-hamradio-team/pat/-/commit/f8c2d7926e431ce010e1e36f6fb87bbefd4ddbf8
> but I didn't analyze the full build process to be able to answer your
> questions.
> 
> Also, I'd strongly recommend making a Merge Request when seeking
> feedback. Commenting the commits directly will get lost easily and
> there is no handy way to track the new versions you made or if
> previous comments were resolved or not. I guess we could also all post
> the review feedback by email, but in that case you should sent the
> patch in email too and not as links to Salsa.


Hello and thank you Otto for the feedback --


I appreciate the salsa comment per changing d/watch file _first_ and then
upgrading from upstream with uscan to validate things are ok.  I've replied on
salsa (and here).  

Per this particular instance with pat, I have re-tested in my dev-build
environment upgrading from pat 0.19.1 upstream with the old v4 and new v5
d/watch files, and found results to match.

While not excusable, this is my second time (and package) updating d/watch.
I've added to my personal packaging notes and will follow the suggested
practice going forward.



Thanks also per the Merge Request (MR) guidance when seeking packaging
feedback.  I've been collaborating on maintaining the pat package for several
years following the same workflow.  The suggestion per MR makes sense and I'll
keep that in mind for the future when I am seeking feedback.


Pardon the sloppy efforts here, I'll aim to improve.


Respectfully,
donfede

Fede Grau

Back to linux.debian.maint.hams | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

seeking review of pat 0.19.2 Federico Grau <donfede@casagrau.org> - 2026-03-15 18:40 +0100
  Re: seeking review of pat 0.19.2 Federico Grau <donfede@casagrau.org> - 2026-03-17 01:40 +0100
    Re: seeking review of pat 0.19.2 Andrew Lee <ajqlee@debian.org> - 2026-03-24 11:30 +0100
      Re: seeking review of pat 0.19.2 Federico Grau <donfede@casagrau.org> - 2026-03-25 01:40 +0100
        Re: seeking review of pat 0.19.2 Andrew Lee <ajqlee@debian.org> - 2026-03-25 10:10 +0100

csiph-web