Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > gnu.gnustep.bug > #4223
| Path | csiph.com!fu-berlin.de!usenet.stanford.edu!not-for-mail |
|---|---|
| From | Ivan Vučica <INVALID.NOREPLY@gnu.org> |
| Newsgroups | gnu.gnustep.bug |
| Subject | [bug #52518] [GWorkspace] Unnecessarily complex build system |
| Date | Sun, 31 Dec 2017 16:36:53 -0500 (EST) |
| Lines | 41 |
| Approved | bug-gnustep@gnu.org |
| Message-ID | <mailman.6624.1514756219.27995.bug-gnustep@gnu.org> (permalink) |
| References | <20171126-211113.sv47215.23519@savannah.gnu.org> <20171126-211517.sv47215.63512@savannah.gnu.org> <20171231-210939.sv82476.16688@savannah.gnu.org> <20171231-211500.sv82476.2975@savannah.gnu.org> |
| NNTP-Posting-Host | lists.gnu.org |
| Mime-Version | 1.0 |
| Content-Type | text/plain;charset=UTF-8 |
| X-Trace | usenet.stanford.edu 1514756220 16932 208.118.235.17 (31 Dec 2017 21:37:00 GMT) |
| X-Complaints-To | action@cs.stanford.edu |
| To | Riccardo Mottola <rm@gnu.org>, Yavor Doganov <yavor@gnu.org>, Ivan Vučica <ivan@vucica.net>, bug-gnustep@gnu.org |
| Envelope-to | bug-gnustep@gnu.org |
| X-PHP-Originating-Script | 1001:sendmail.php |
| X-Savane-Server | savannah.gnu.org:443 [208.118.235.79] |
| X-Savane-Project | gnustep |
| X-Savane-Tracker | bugs |
| X-Savane-Item-ID | 52518 |
| User-Agent | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 |
| X-Apparently-From | 109.255.23.171 (Savane authenticated user ivucica) |
| In-Reply-To | <20171231-211500.sv82476.2975@savannah.gnu.org> |
| X-detected-operating-system | by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] |
| X-Received-From | 208.118.235.79 |
| X-BeenThere | bug-gnustep@gnu.org |
| X-Mailman-Version | 2.1.21 |
| Precedence | list |
| List-Id | Bug reports for the GNUstep programming environment <bug-gnustep.gnu.org> |
| List-Unsubscribe | <https://lists.gnu.org/mailman/options/bug-gnustep>, <mailto:bug-gnustep-request@gnu.org?subject=unsubscribe> |
| List-Archive | <http://lists.gnu.org/archive/html/bug-gnustep/> |
| List-Post | <mailto:bug-gnustep@gnu.org> |
| List-Help | <mailto:bug-gnustep-request@gnu.org?subject=help> |
| List-Subscribe | <https://lists.gnu.org/mailman/listinfo/bug-gnustep>, <mailto:bug-gnustep-request@gnu.org?subject=subscribe> |
| Xref | csiph.com gnu.gnustep.bug:4223 |
Show key headers only | View raw
Update of bug #52518 (project gnustep):
Assigned to: ivucica => rmottola
_______________________________________________________
Follow-up Comment #3:
I created a PR at https://github.com/gnustep/apps-gworkspace/pull/2 if you'd
like a diff, but I am fine with reviewing here instead (given that GH is
nonfree, you might not like using it).
(1) Side remark: Interesting that you're explicitly stating FND_LIBS. I guess
it makes sense for libraries.
(2) I like the change in GWMetadata/gmds/gmds/GNUmakefile.preamble to move to
ADDITIONAL_TOOL_LIBS:
ADDITIONAL_TOOL_LIBS += -lsqlite3
but I am not sure moving -L flags in
GWMetadata/gmds/gmds/GNUmakefile.preamble.in is correct:
ADDITIONAL_TOOL_LIBS += @SQLITE_LIB_DIRS@
Also, are these one and the same? It's confusing that @SQLITE_LIB_DIRS@ has a
library and not the -L in it. It's also slightly confusing that both
GNUmakefile.preamble.in and GNUmakefile.preamble are and were submitted. I
think I'll delete the GNUmakefile.preamble.
(3) In OpenOfficeExtractor.m, the inclusion of <config.h> is almost certainly
wrong. Is there a system header called config.h? Did you mean local header
"config.h"? I'll update this. Same in Resizer.m.
I'll let Riccardo take a look at this too.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?52518>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
Back to gnu.gnustep.bug | Previous | Next | Find similar
[bug #52518] [GWorkspace] Unnecessarily complex build system Ivan Vučica <INVALID.NOREPLY@gnu.org> - 2017-12-31 16:36 -0500
csiph-web