Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > gnu.gnustep.bug > #4223

[bug #52518] [GWorkspace] Unnecessarily complex build system

Show all headers | View raw

Update of bug #52518 (project gnustep):

             Assigned to:                 ivucica => rmottola               

    _______________________________________________________

Follow-up Comment #3:

I created a PR at https://github.com/gnustep/apps-gworkspace/pull/2 if you'd
like a diff, but I am fine with reviewing here instead (given that GH is
nonfree, you might not like using it).

(1) Side remark: Interesting that you're explicitly stating FND_LIBS. I guess
it makes sense for libraries.
(2) I like the change in GWMetadata/gmds/gmds/GNUmakefile.preamble to move to
ADDITIONAL_TOOL_LIBS:
  ADDITIONAL_TOOL_LIBS +=  -lsqlite3
but I am not sure moving -L flags in 
GWMetadata/gmds/gmds/GNUmakefile.preamble.in is correct:
  ADDITIONAL_TOOL_LIBS += @SQLITE_LIB_DIRS@
Also, are these one and the same? It's confusing that @SQLITE_LIB_DIRS@ has a
library and not the -L in it. It's also slightly confusing that both
GNUmakefile.preamble.in and GNUmakefile.preamble are and were submitted. I
think I'll delete the GNUmakefile.preamble.
(3) In OpenOfficeExtractor.m, the inclusion of <config.h> is almost certainly
wrong. Is there a system header called config.h? Did you mean local header
"config.h"? I'll update this. Same in Resizer.m.

I'll let Riccardo take a look at this too.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52518>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

Back to gnu.gnustep.bug | Previous | Next | Find similar

Thread

[bug #52518] [GWorkspace] Unnecessarily complex build system Ivan Vučica <INVALID.NOREPLY@gnu.org> - 2017-12-31 16:36 -0500

csiph-web