Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #14574

[PATCH] decode_signal: allow all sane forms of SIGRTMIN+n

Path csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From Rasmus Villemoes <rv@rasmusvillemoes.dk>
Newsgroups gnu.bash.bug
Subject [PATCH] decode_signal: allow all sane forms of SIGRTMIN+n
Date Wed, 12 Sep 2018 12:11:24 +0200
Lines 50
Approved bug-bash@gnu.org
Message-ID <mailman.670.1536756476.1284.bug-bash@gnu.org> (permalink)
NNTP-Posting-Host lists.gnu.org
X-Trace usenet.stanford.edu 1536756476 4533 208.118.235.17 (12 Sep 2018 12:47:56 GMT)
X-Complaints-To action@cs.stanford.edu
Cc Rasmus Villemoes <rv@rasmusvillemoes.dk>
To bug-bash@gnu.org
Envelope-to bug-bash@gnu.org
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=ApeFfRDO9qsI6uEps9xpwNPHUqlAcLSgNcCEEEivOFU=; b=J1cUJ0mQRsr1GD2/IQamD/HMjNuq+yCO5KO71ANNuEfDTs//cSvVOwPQCQimj2HBJH 7WRCouKdmBM9x0ZgcSMG6lVo6J2MLoMwNcJTXNln+fQNDDO045RRrL2kr4vFCt5BwKSH wbbJxm3V19dKTK479qvExwrI/r7Xdxp7ZU27A=
X-Google-DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ApeFfRDO9qsI6uEps9xpwNPHUqlAcLSgNcCEEEivOFU=; b=c+kOAPRmCN/TfOXfTQlqpYnl5XsbNbplpAhpHW2aQj7f8pE7x5h47xVvCwXZSCm1tU 3Uy55BIxc14T7iY6L4LiFFVbJgzqouSBGPAS4b6exES5D0SGSIxGLejzufRiVbBsuaBF 4R2x6tv2iW5LowZA94HeVZh9N2tyzdHPZ2gNNN764oSLOpAkXZkdwu/86ptCTOWM1rKZ rLnKxi1V84fQ80eyHTOKXGcwyli3cozuCM1YRX4qD7c4QkWaCFxy/ldzG58eLyi6fzCo uyq2bLgO2JBY59k1VXvlFBwZjBkNIUHO1cLt+/r6pLfZBnnTLTvIGFnOWQ1G0jAl8VrX ESrA==
X-Gm-Message-State APzg51DVCTWJSqZRatJyE/BPn3AOQ7/w7hFHT8GCndsekrf2kaXZbBkK St5G7dHsZGx605VDHhAAEn7g/jnKTKiyzigU
X-Google-Smtp-Source ANB0VdY+ud8itH5faUgT1Vd6+JHyP8oYbKk6olLJCWDTRkPtDcl6sUwqGA+i1ivUMEJNE7HMhLR8ng==
X-Received by 2002:a2e:5419:: with SMTP id i25-v6mr827272ljb.51.1536747087467; Wed, 12 Sep 2018 03:11:27 -0700 (PDT)
X-Mailer git-send-email 2.16.4
X-detected-operating-system by eggs.gnu.org: Genre and OS details not recognized.
X-Received-From 2a00:1450:4864:20::242
X-Mailman-Approved-At Wed, 12 Sep 2018 08:47:54 -0400
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.21
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <http://lists.gnu.org/archive/html/bug-bash/>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
Xref csiph.com gnu.bash.bug:14574

Show key headers only | View raw


I have a program I'd like to send SIGRTMIN+20, because that's the
spelling used in its documentation. Currently, bash only accepts the
symbolic names in the signal_names array, meaning I'd have to spell it
SIGRTMAX-10 on linux.

One workaround is of course to use

  kill -n $(($(kill -l SIGRTMIN) + 20)) pid

but it's more user-friendly to allow the form

  kill -s SIGRTMIN+20 pid

For symmetry, also accept SIGRTMAX-n expressions.

Signed-off-by: Rasmus Villemoes <rv@rasmusvillemoes.dk>
---
 trap.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/trap.c b/trap.c
index eb8ecf3a..dd80c220 100644
--- a/trap.c
+++ b/trap.c
@@ -242,6 +242,21 @@ decode_signal (string, flags)
   if (legal_number (string, &sig))
     return ((sig >= 0 && sig < NSIG) ? (int)sig : NO_SIG);
 
+#if defined(SIGRTMIN) && defined(SIGRTMAX)
+  if (STREQN (string, "SIGRTMIN+", 9)) {
+    if (legal_number (string + 9, &sig) && sig >= 0 && sig <= SIGRTMAX - SIGRTMIN)
+      return SIGRTMIN + sig;
+    else
+      return NO_SIG;
+  }
+  if (STREQN (string, "SIGRTMAX-", 9)) {
+    if (legal_number (string + 9, &sig) && sig >= 0 && sig <= SIGRTMAX - SIGRTMIN)
+      return SIGRTMAX - sig;
+    else
+      return NO_SIG;
+  }
+#endif
+
   /* A leading `SIG' may be omitted. */
   for (sig = 0; sig < BASH_NSIG; sig++)
     {
-- 
2.16.4

Back to gnu.bash.bug | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] decode_signal: allow all sane forms of SIGRTMIN+n Rasmus Villemoes <rv@rasmusvillemoes.dk> - 2018-09-12 12:11 +0200

csiph-web