Path: csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Newsgroups: gnu.bash.bug
Subject: [PATCH] decode_signal: allow all sane forms of SIGRTMIN+n
Date: Wed, 12 Sep 2018 12:11:24 +0200
Lines: 50
Approved: bug-bash@gnu.org
Message-ID: <mailman.670.1536756476.1284.bug-bash@gnu.org>
NNTP-Posting-Host: lists.gnu.org
Cc: Rasmus Villemoes <rv@rasmusvillemoes.dk>
To: bug-bash@gnu.org
Envelope-to: bug-bash@gnu.org
Precedence: list
Xref: csiph.com gnu.bash.bug:14574

I have a program I'd like to send SIGRTMIN+20, because that's the
spelling used in its documentation. Currently, bash only accepts the
symbolic names in the signal_names array, meaning I'd have to spell it
SIGRTMAX-10 on linux.

One workaround is of course to use

  kill -n $(($(kill -l SIGRTMIN) + 20)) pid

but it's more user-friendly to allow the form

  kill -s SIGRTMIN+20 pid

For symmetry, also accept SIGRTMAX-n expressions.

Signed-off-by: Rasmus Villemoes <rv@rasmusvillemoes.dk>
---
 trap.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/trap.c b/trap.c
index eb8ecf3a..dd80c220 100644
--- a/trap.c
+++ b/trap.c
@@ -242,6 +242,21 @@ decode_signal (string, flags)
   if (legal_number (string, &sig))
     return ((sig >= 0 && sig < NSIG) ? (int)sig : NO_SIG);
 
+#if defined(SIGRTMIN) && defined(SIGRTMAX)
+  if (STREQN (string, "SIGRTMIN+", 9)) {
+    if (legal_number (string + 9, &sig) && sig >= 0 && sig <= SIGRTMAX - SIGRTMIN)
+      return SIGRTMIN + sig;
+    else
+      return NO_SIG;
+  }
+  if (STREQN (string, "SIGRTMAX-", 9)) {
+    if (legal_number (string + 9, &sig) && sig >= 0 && sig <= SIGRTMAX - SIGRTMIN)
+      return SIGRTMAX - sig;
+    else
+      return NO_SIG;
+  }
+#endif
+
   /* A leading `SIG' may be omitted. */
   for (sig = 0; sig < BASH_NSIG; sig++)
     {
-- 
2.16.4