Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #16486

Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V

Path csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From Chet Ramey <chet.ramey@case.edu>
Newsgroups gnu.bash.bug
Subject Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V
Date Mon, 29 Jun 2020 10:52:33 -0400
Organization ITS, Case Western Reserve University
Lines 19
Approved bug-bash@gnu.org
Message-ID <mailman.649.1593442362.2574.bug-bash@gnu.org> (permalink)
References <20200627200631.38456-1-jrtc27@jrtc27.com> <20200627200631.38456-3-jrtc27@jrtc27.com> <54831546-88c8-674c-8e92-587e08fda5f5@case.edu>
Reply-To chet.ramey@case.edu
NNTP-Posting-Host lists.gnu.org
Mime-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 7bit
X-Trace usenet.stanford.edu 1593442363 15174 209.51.188.17 (29 Jun 2020 14:52:43 GMT)
X-Complaints-To action@cs.stanford.edu
Cc chet.ramey@case.edu
To Jessica Clarke <jrtc27@jrtc27.com>, bug-bash@gnu.org
Envelope-to bug-bash@gnu.org
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1593442358; bh=YLiMVovm6I4O2K87tYQ/CyZrxExes0DS1ND7tOUV6y8=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=F6owNFyDYIWoA1bloQX0/JBy6odQBvoOm2gYhsHumEQeTmRyi4OB5LkoAcipYDqrjI NNXkVOZpoEvHV4Ovaa4jhRB8pLQ0DkRWl7txw0jNDJ1mfyFw0gXoQhniYdcnNCpV6RK eiTPUrTHjz6y6aKZ2HcbW6xni8tNTYxECuU4OC0LDrNAYrPw80vaUblwTSZHl2xSBbU dzSXyDO0eNnmD7Vgd+C2z1k4g2dfYkHqjAy0BlsBLOZ9yz6Xb4ofxkWqop6AvyIYYgc jNeVXW9eTOBw7RUDNYyeOxVwm0Iifs1EzWZdEHcS89fJV+wl2e91GJsUn/jMSaXUB5D KNRD+fCw==
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1593442356; bh=ETEDL9q+2lwRFLEe9VTxgdmgnEgy+3F69M91LW933BA=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ChESUMvVOaKpv7BdoaZJ1+AvafDru+oPeiZ9tLIDURBL2TbefjLZ94hasTDOkEZq8b f+aWRQmKtT5F/W/TvZvcU5Tu5wx+u2fEqabols4SGZ+Sl1pph7TfB3D4Dp59mcaVim/ n/6QOc6anJXndEak1H+L3QkZjTox99sEfKP8/sBQ6uRHQV5KoRgy2+9jsz7y1h5Ija+ FIghed157D9gFeJYl+LKSP9kSTw0cAI7D0EoWe2FKD/jCtW5EAe6mRK0l9w0pMzkKJH EfwK9jsJrPuiuNOjR5YSSVauuf7VmeKLXDXHdAcmX4LhlhvSXa4YFeQtyGCuRldyHEb 6VKBLhvA==
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=g-case; h=reply-to:cc:subject:to:references:from:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ETEDL9q+2lwRFLEe9VTxgdmgnEgy+3F69M91LW933BA=; b=T6uiIeJHxvHe1IJYIfPTsbY63kaxOJ5W+MrxL25dX+XdMmKfEd2CeG6/Myg2xhiR5T EpaCgA6j/uAMX7/8uUwiyUY9fVCDKC+Yiz1i5ki/MJullaZK0Ps4mVuHgAtFsDs2B1C4 +vGhYOXlNmlMGFhqHj+I1rJDujk1RDsy/xQeNhvPGMZGQiwcx4h0CK9quIWdagF5p1fa WmVL5IMcjfeezf/WFQs+N5jgzZUV6Ks3U6dngcIs6ON4tY5ECSatMcXZIR1z4k0kLvcG uCpJ8VHgOva2YwgmrrWh3Mwul7y2eu6osaUXRS3sfjCidFdojn6R1Y4CCf9Ei5Cx8pz7 D2Tw==
X-Google-DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:cc:subject:to:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ETEDL9q+2lwRFLEe9VTxgdmgnEgy+3F69M91LW933BA=; b=kjTPZq6EtCSKdGgE8jL1VlF5Xrmvw1FXg2B2hgAe/37ZzBQd4T67+DHqDr3R+gAOC0 Uq4gfm3b/Q1c2t/QgiQ9/zq6ei+N7t9PeOgXjiPyhTJLpZln6pgH1rCrvE71KkmoBh4G zJqpc5bLWrziMbp3eXvhmlF6SHdoqUOkZ1HmU/ypvSM2w2TMzkqF1yY9wdZ9EZetGb42 FxDJvPbExnpMPbxPQUQFbIbBNwhpoxl//nTzbdCqr1q6MzYAvF6+QGOBw3tJUz6wZPCg VyQEg/6GBBgneIadpSUx/8NJIt7cTi6+WvjNWW+xCWSWmBR9gJi8AYkNsnD4T823Gef1 T4MA==
X-Gm-Message-State AOAM530QqjvLvpNxY1/4uWVvrKDEKS4ov8ZbiIpQQF0ITmvAHXKKeHq3 Kzf/zXUzsB/XepBr67AeMSHyxNHPg9Rfz0+VUqnz59/RE40J2XtkO7+5Y2wBoTIDGy5FLwTQuO3 X9w0/axG9x4g=
X-Received by 2002:a05:6e02:1070:: with SMTP id q16mr15378599ilj.221.1593442356098; Mon, 29 Jun 2020 07:52:36 -0700 (PDT)
X-Google-Smtp-Source ABdhPJw5QhF5dq6QC3aJm2HSWoTPjPX1NLZ5UbxbWAmbJfBNT7r43FyKGdePt7WgeWmlx+5Y2Pvh1w==
X-Received by 2002:a05:6e02:1070:: with SMTP id q16mr15378568ilj.221.1593442355722; Mon, 29 Jun 2020 07:52:35 -0700 (PDT)
Autocrypt addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN
User-Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0
In-Reply-To <20200627200631.38456-3-jrtc27@jrtc27.com>
Content-Language en-US
X-Mirapoint-IP-Reputation reputation=Good-1, source=Queried, refid=tid=0001.0A020303.5EF9F5A3.000E, actions=tag
X-Mirapoint-IP-Reputation reputation=good-1, source=Fixed, refid=n/a, actions=tag
X-Junkmail-Status score=7/80, host=mpv3-2015.case.edu
X-Junkmail-PrAS-Raw score=7/80, refid=2.7.2:2020.6.29.134817:17:7.944, ip=, rules=__YOUTUBE_RCVD, DKIM_SIGNATURE, __X_GOOGLE_DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __TO_MALFORMED_2, __MULTIPLE_RCPTS_TO_X2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_MAILTO, __URI_WITH_PATH, __URI_ENDS_IN_SLASH, __URI_NO_WWW, __CP_URI_IN_BODY, __INVOICE_MULTILINGUAL, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __MAIL_CHAIN, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODYTEXTP_SIZE_3000_LESS, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138
Received-SPF pass client-ip=129.22.103.194; envelope-from=chet.ramey@case.edu; helo=mpv3-2015.case.edu
X-detected-operating-system by eggs.gnu.org: First seen = 2020/06/29 10:37:28
X-ACL-Warn Detected OS = Linux 2.4.x-2.6.x [generic]
X-Spam_score_int -43
X-Spam_score -4.4
X-Spam_bar ----
X-Spam_report (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN
X-Spam_action no action
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.23
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <https://lists.gnu.org/archive/html/bug-bash>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID <54831546-88c8-674c-8e92-587e08fda5f5@case.edu>
X-Mailman-Original-References <20200627200631.38456-1-jrtc27@jrtc27.com> <20200627200631.38456-3-jrtc27@jrtc27.com>
Xref csiph.com gnu.bash.bug:16486

Show key headers only | View raw


On 6/27/20 4:06 PM, Jessica Clarke wrote:
> FreeBSD unconditionally provides a prototype for sbrk(2), but on recent
> ports (AArch64 and RISC-V) it does not provide the deprecated symbol.
> This means that, when cross-compiling, we currently only get to use
> AC_CHECK_FUNCS_ONCE, and so believe sbrk(2) to be available. Instead,
> use AC_TRY_LINK so we can detect this case when cross-compiling. Also,
> only define HAVE_SBRK when our tests pass, since xmalloc.c checks
> whether it's defined, not its value. This likely meant the case where
> sbrk(2) was available but broken did not in fact do the right thing.

Thanks for the report and fix.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar


Thread

Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V Chet Ramey <chet.ramey@case.edu> - 2020-06-29 10:52 -0400

csiph-web