Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V

From	Chet Ramey <chet.ramey@case.edu>
Newsgroups	gnu.bash.bug
Subject	Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V
Date	2020-06-29 10:52 -0400
Organization	ITS, Case Western Reserve University
Message-ID	<mailman.649.1593442362.2574.bug-bash@gnu.org> (permalink)
References	<20200627200631.38456-1-jrtc27@jrtc27.com> <20200627200631.38456-3-jrtc27@jrtc27.com> <54831546-88c8-674c-8e92-587e08fda5f5@case.edu>

Show all headers | View raw

On 6/27/20 4:06 PM, Jessica Clarke wrote:
> FreeBSD unconditionally provides a prototype for sbrk(2), but on recent
> ports (AArch64 and RISC-V) it does not provide the deprecated symbol.
> This means that, when cross-compiling, we currently only get to use
> AC_CHECK_FUNCS_ONCE, and so believe sbrk(2) to be available. Instead,
> use AC_TRY_LINK so we can detect this case when cross-compiling. Also,
> only define HAVE_SBRK when our tests pass, since xmalloc.c checks
> whether it's defined, not its value. This likely meant the case where
> sbrk(2) was available but broken did not in fact do the right thing.

Thanks for the report and fix.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH 2/3] aclocal.m4: Fix BASH_FUNC_SBRK when cross-compiling for FreeBSD/RISC-V Chet Ramey <chet.ramey@case.edu> - 2020-06-29 10:52 -0400

csiph-web