Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > gnu.bash.bug > #11563

Re: [PATCH] input: fix logic bug that breaks on O_TEXT systems

Show key headers only | View raw

On 9/24/15 5:47 PM, Eric Blake wrote:
> The bash-20101229 snapshot introduced an attempt to incorporate
> some patches that were previously used downstream by Cygwin
> with regards to managing scripts read with O_TEXT mode (where
> lseek() sees different offsets than the number of bytes read,
> because the system is converting physical '\r\n' into logical
> '\n').  But it introduced a typo, using O_TEXT where it meant
> to use B_TEXT, with the result that scripts read in text mode
> would seek to the wrong location.

Good catch.  Thanks for the report and fix.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH] input: fix logic bug that breaks on O_TEXT systems Chet Ramey <chet.ramey@case.edu> - 2015-09-24 19:51 -0400

csiph-web