Path: csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!news.glorb.com!usenet.stanford.edu!not-for-mail From: Chet Ramey Newsgroups: gnu.bash.bug Subject: Re: [PATCH] input: fix logic bug that breaks on O_TEXT systems Date: Thu, 24 Sep 2015 19:51:36 -0400 Organization: ITS, Case Western Reserve University Lines: 19 Approved: bug-bash@gnu.org Message-ID: References: <1443131249-5728-1-git-send-email-eblake@redhat.com> Reply-To: chet.ramey@case.edu NNTP-Posting-Host: lists.gnu.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: usenet.stanford.edu 1443138707 11365 208.118.235.17 (24 Sep 2015 23:51:47 GMT) X-Complaints-To: action@cs.stanford.edu Cc: chet.ramey@case.edu To: Eric Blake , bug-bash@gnu.org Envelope-to: bug-bash@gnu.org User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 In-Reply-To: <1443131249-5728-1-git-send-email-eblake@redhat.com> X-Junkmail-Whitelist: YES (by domain whitelist at mpv2.tis.cwru.edu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 129.22.105.37 X-BeenThere: bug-bash@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports for the GNU Bourne Again SHell List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Xref: csiph.com gnu.bash.bug:11563 On 9/24/15 5:47 PM, Eric Blake wrote: > The bash-20101229 snapshot introduced an attempt to incorporate > some patches that were previously used downstream by Cygwin > with regards to managing scripts read with O_TEXT mode (where > lseek() sees different offsets than the number of bytes read, > because the system is converting physical '\r\n' into logical > '\n'). But it introduced a typo, using O_TEXT where it meant > to use B_TEXT, with the result that scripts read in text mode > would seek to the wrong location. Good catch. Thanks for the report and fix. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/