Re: Curious about some comments I received on some of my code

Path	csiph.com!fu-berlin.de!uni-berlin.de!individual.net!not-for-mail
From	Robert Klemme <shortcutter@googlemail.com>
Newsgroups	comp.lang.ruby
Subject	Re: Curious about some comments I received on some of my code
Date	Sat, 21 May 2016 22:01:36 +0200
Lines	23
Message-ID	<dqbt51F2g7cU1@mid.individual.net> (permalink)
References	<bfc6c044-e8ff-436d-af00-038742e45c3f@googlegroups.com>
Mime-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Trace	individual.net ml1ECH2fLCudRMVEcGdiEQw8LuapAeS5lLU/K2mJqeRxcgpUM=
Cancel-Lock	sha1:+HGvF3SKLnD0r8v6lDQp2aFBw6A=
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0
In-Reply-To	<bfc6c044-e8ff-436d-af00-038742e45c3f@googlegroups.com>
Xref	csiph.com comp.lang.ruby:7253

Show key headers only | View raw

On 18.05.2016 11:23, ngw@nofeed.org wrote:

> They told me that "The feedback from the team showed that the tests
> provided complete coverage, however the code had a few issue
> regarding naming and organising and contained quite a few clusters of
> functionality in a few lines."

I find that way too unspecific to comment.  What is this supposed to 
mean?  If they have something to complain about they should address 
specific items - if only that you can learn from it.

> Also consider I'm not a native english speaker.
> What you guys think? Maybe it's because I opened Fixnum?...

That method should have gone into Integer if at all.

Kind regards

	robert

-- 
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/

Back to comp.lang.ruby | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Curious about some comments I received on some of my code ngw@nofeed.org - 2016-05-18 02:23 -0700
  Re: Curious about some comments I received on some of my code Robert Klemme <shortcutter@googlemail.com> - 2016-05-21 22:01 +0200
  Re: Curious about some comments I received on some of my code "WJ" <w_a_x_man@yahoo.com> - 2016-07-23 23:43 +0000

csiph-web