Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.ruby > #7253

Re: Curious about some comments I received on some of my code

Show all headers | View raw

On 18.05.2016 11:23, ngw@nofeed.org wrote:

> They told me that "The feedback from the team showed that the tests
> provided complete coverage, however the code had a few issue
> regarding naming and organising and contained quite a few clusters of
> functionality in a few lines."

I find that way too unspecific to comment.  What is this supposed to 
mean?  If they have something to complain about they should address 
specific items - if only that you can learn from it.

> Also consider I'm not a native english speaker.
> What you guys think? Maybe it's because I opened Fixnum?...

That method should have gone into Integer if at all.

Kind regards

	robert

-- 
remember.guy do |as, often| as.you_can - without end
http://blog.rubybestpractices.com/

Back to comp.lang.ruby | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Curious about some comments I received on some of my code ngw@nofeed.org - 2016-05-18 02:23 -0700
  Re: Curious about some comments I received on some of my code Robert Klemme <shortcutter@googlemail.com> - 2016-05-21 22:01 +0200
  Re: Curious about some comments I received on some of my code "WJ" <w_a_x_man@yahoo.com> - 2016-07-23 23:43 +0000

csiph-web