Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #106659

Re: how to convert code that uses cmp to python3

From Chris Angelico <rosuav@gmail.com>
Newsgroups comp.lang.python
Subject Re: how to convert code that uses cmp to python3
Date 2016-04-08 17:40 +1000
Message-ID <mailman.70.1460101211.2253.python-list@python.org> (permalink)
References (1 earlier) <CAPTjJmrGiQS9uhFU-+TQ4nUWQ2p4gmJoQitMotS0Ob--qm1iWg@mail.gmail.com> <5706C961.2000009@rece.vub.ac.be> <CAPTjJmrbL870mV1kU8nHar=bPyKZRmhKP-8iUs_tpYVo5vhhOA@mail.gmail.com> <57075F43.7060004@rece.vub.ac.be> <CAPTjJmp_P7avc8G0E249wPSQKWBjHgToB2gq+3bHFC=K4EHicw@mail.gmail.com>

Show all headers | View raw


On Fri, Apr 8, 2016 at 5:35 PM, Antoon Pardon
<antoon.pardon@rece.vub.ac.be> wrote:
> Op 08-04-16 om 00:21 schreef Chris Angelico:
>> On Fri, Apr 8, 2016 at 6:56 AM, Antoon Pardon
>> <antoon.pardon@rece.vub.ac.be> wrote:
>>> That solution will mean I will have to do about 100% more comparisons
>>> than previously.
>> Try it regardless. You'll probably find that performance is fine.
>> Don't prematurely optimize!
>>
>> ChrisA
>
> But it was already working and optimized. The python3 approach forces
> me to make changes to working code and make the performance worse.

Is performance actually worse because you're doing two comparisons?
Visibly worse? If so, you probably have an overly-complex comparison
function, and a tree is *always* going to be suboptimal. Have you
actually measured a performance hit?

ChrisA

Back to comp.lang.python | Previous | Next | Find similar | Unroll thread


Thread

Re: how to convert code that uses cmp to python3 Chris Angelico <rosuav@gmail.com> - 2016-04-08 17:40 +1000

csiph-web