Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: Chris Angelico <rosuav@gmail.com>
Newsgroups: comp.lang.python
Subject: Re: how to convert code that uses cmp to python3
Date: Fri, 8 Apr 2016 17:40:08 +1000
Lines: 21
Message-ID: <mailman.70.1460101211.2253.python-list@python.org>
References: <57064D0D.1030701@rece.vub.ac.be> <CAPTjJmrGiQS9uhFU-+TQ4nUWQ2p4gmJoQitMotS0Ob--qm1iWg@mail.gmail.com> <5706C961.2000009@rece.vub.ac.be> <CAPTjJmrbL870mV1kU8nHar=bPyKZRmhKP-8iUs_tpYVo5vhhOA@mail.gmail.com> <57075F43.7060004@rece.vub.ac.be> <CAPTjJmp_P7avc8G0E249wPSQKWBjHgToB2gq+3bHFC=K4EHicw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: news.uni-berlin.de JfpfrtoDfY3DhUV0aWpXhA9qwh5C7R7cItLMZcx4HJAw==
Return-Path: <rosuav@gmail.com>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.006
X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'received:209.85.223': 0.03; 'python3': 0.05; 'subject:code': 0.07; 'cc:addr:python- list': 0.09; 'worse': 0.09; '*always*': 0.16; '2016': 0.16; '6:56': 0.16; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'measured': 0.16; 'received:io': 0.16; 'received:psf.io': 0.16; 'subject:python3': 0.16; 'worse.': 0.16; 'wrote:': 0.16; 'tree': 0.18; '>>>': 0.20; 'changes': 0.20; 'cc:2**0': 0.20; 'cc:addr:python.org': 0.20; 'function,': 0.22; 'am,': 0.23; 'header:In-Reply-To:1': 0.24; 'chris': 0.26; 'fri,': 0.27; 'message-id:@mail.gmail.com': 0.27; 'comparison': 0.29; 'forces': 0.29; 'subject:that': 0.29; 'code': 0.30; 'probably': 0.31; 'received:google.com': 0.35; 'so,': 0.35; 'but': 0.36; 'received:209.85': 0.36; 'pm,': 0.36; 'subject:: ': 0.37; 'two': 0.37; 'doing': 0.38; 'received:209': 0.38; 'mean': 0.38; "you'll": 0.61; 'more': 0.63; '100%': 0.72; 'angelico:': 0.84; 'chrisa': 0.84; 'optimized.': 0.84; 'pardon': 0.84; 'schreef': 0.84; 'suboptimal.': 0.84; 'to:none': 0.91
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc; bh=yI3dZV/8G9/n3QpEoXy0y+AjFB7Q8OLiuFB8nAs4mLI=; b=EepSLvQZxrWIBdjybO/DFzBrumlZhJVV97rGt5cb2O1KbqIYsPYBshaNKLHGDQTR47 /iDTjSNFmH4PUziiFztPeuqqxocaQFTVRjCVjg5o0i2UAfOHtsLs84Za8796YFxfEwtA opP+ftPP21B0YReKQS46OGiJi/o2OySu/8bUSJPtIQAmDlhUG0A7uFUTPI2SmdIPbCJQ LFG6pe+JOmtA9tWAT89FRLVB37OoPvX4icRyDgjzt0bWcx+PSP871gImblctkLt9+fpP QKlgGSwpjnRWqI2CoUU5EBBhYTZEwGxrY8MysTvEDuE4/Mgqi3D6q1AJ8fZzZsKQzyOI VAWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:cc; bh=yI3dZV/8G9/n3QpEoXy0y+AjFB7Q8OLiuFB8nAs4mLI=; b=kFfBa+ZVRn3K4SzCzegLIy8myOmJEaVxAAIxUr8mBNE82s9VAHg44Oo9RhR6uNsQrB MKE6mWXgRb/UdymDaQPMssJYx3RNf2+y44Y95v6PgxwPXdff2W16tBI8RUuY4po8MtqI gaMwC3RurvZIBX2ixE+6cibdrfffl7SOKkmQa8QmN2WyfSuMDFdCDYhv+ZsXNhsVCuz1 c3oF+8HWZRm8c+dmD2+3I5TAdDXqLvJ6Upm/EZJDWBDQbyL9sM5rvK+9Y3NIfLleqNet cROknvQMNX0vYjneUAQnFrXyb36gPVYA81z2yul5wT8FAIdf+5VHXNm9X2rGnq5i/tMW KZNg==
X-Gm-Message-State: AD7BkJIa1I+MEvNRuVugHyxSmRmL65CdGmlXay/zmPYveVXzhVMfN0gp4ueWkIBhcM37vcIcIz45ootWeBAZNg==
X-Received: by 10.107.169.32 with SMTP id s32mr7123311ioe.19.1460101208298; Fri, 08 Apr 2016 00:40:08 -0700 (PDT)
In-Reply-To: <57075F43.7060004@rece.vub.ac.be>
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
X-Mailman-Original-Message-ID: <CAPTjJmp_P7avc8G0E249wPSQKWBjHgToB2gq+3bHFC=K4EHicw@mail.gmail.com>
X-Mailman-Original-References: <57064D0D.1030701@rece.vub.ac.be> <CAPTjJmrGiQS9uhFU-+TQ4nUWQ2p4gmJoQitMotS0Ob--qm1iWg@mail.gmail.com> <5706C961.2000009@rece.vub.ac.be> <CAPTjJmrbL870mV1kU8nHar=bPyKZRmhKP-8iUs_tpYVo5vhhOA@mail.gmail.com> <57075F43.7060004@rece.vub.ac.be>
Xref: csiph.com comp.lang.python:106659

On Fri, Apr 8, 2016 at 5:35 PM, Antoon Pardon
<antoon.pardon@rece.vub.ac.be> wrote:
> Op 08-04-16 om 00:21 schreef Chris Angelico:
>> On Fri, Apr 8, 2016 at 6:56 AM, Antoon Pardon
>> <antoon.pardon@rece.vub.ac.be> wrote:
>>> That solution will mean I will have to do about 100% more comparisons
>>> than previously.
>> Try it regardless. You'll probably find that performance is fine.
>> Don't prematurely optimize!
>>
>> ChrisA
>
> But it was already working and optimized. The python3 approach forces
> me to make changes to working code and make the performance worse.

Is performance actually worse because you're doing two comparisons?
Visibly worse? If so, you probably have an overly-complex comparison
function, and a tree is *always* going to be suboptimal. Have you
actually measured a performance hit?

ChrisA