Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #18797

Re: your feedback to my first project please

Path csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Return-Path <python-python-list@m.gmane.org>
X-Original-To python-list@python.org
Delivered-To python-list@mail.python.org
X-Spam-Status OK 0.000
X-Spam-Evidence '*H*': 1.00; '*S*': 0.00; 'dislike': 0.07; 'inserts': 0.07; 'received:verizon.net': 0.07; 'removes': 0.07; 'terry': 0.07; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:80.91.229.12': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'received:lo.gmane.org': 0.09; 'am,': 0.12; 'acceptable.': 0.16; 'reedy': 0.16; 'wrote:': 0.18; 'jan': 0.19; 'header:In-Reply-To:1': 0.22; 'documented': 0.23; 'subject:please': 0.24; 'code.': 0.26; 'quite': 0.32; 'does': 0.32; 'header:User-Agent:1': 0.33; 'header:X-Complaints-To:1': 0.33; 'object': 0.33; 'to:addr:python-list': 0.34; 'someone': 0.34; 'subject:project': 0.34; 'before.': 0.37; 'another': 0.37; 'could': 0.37; 'received:org': 0.38; 'why': 0.39; 'to:addr:python.org': 0.40; 'more': 0.61; 'your': 0.61; 'subject:your': 0.80
X-Injected-Via-Gmane http://gmane.org/
To python-list@python.org
From Terry Reedy <tjreedy@udel.edu>
Subject Re: your feedback to my first project please
Date Tue, 10 Jan 2012 20:53:15 -0500
References <4F0C45FA.2060505@sequans.com>
Mime-Version 1.0
Content-Type text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding 7bit
X-Gmane-NNTP-Posting-Host pool-74-109-121-73.phlapa.fios.verizon.net
User-Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0
In-Reply-To <4F0C45FA.2060505@sequans.com>
X-BeenThere python-list@python.org
X-Mailman-Version 2.1.12
Precedence list
List-Id General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe <http://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive <http://mail.python.org/pipermail/python-list>
List-Post <mailto:python-list@python.org>
List-Help <mailto:python-list-request@python.org?subject=help>
List-Subscribe <http://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups comp.lang.python
Message-ID <mailman.4623.1326246913.27778.python-list@python.org> (permalink)
Lines 14
NNTP-Posting-Host 2001:888:2000:d::a6
X-Trace 1326246913 news.xs4all.nl 6934 [2001:888:2000:d::a6]:48841
X-Complaints-To abuse@xs4all.nl
Xref x330-a1.tempe.blueboxinc.net comp.lang.python:18797

Show key headers only | View raw


On 1/10/2012 9:06 AM, Jean-Michel Pichavant wrote:

> - I quite dislike your avg method which does more than averaging, it
> also inserts a value and removes another modifying the object in place.
> It could be very confusing for someone reading your code. Fortunately,
> you have documented it, that makes it acceptable. Why don't you make avg
> only averaging. Surely you can use the add method right before.

Or use a better name, like running_average or run_mean (if that is what 
it is doing).

-- 
Terry Jan Reedy

Back to comp.lang.python | Previous | Next | Find similar | Unroll thread


Thread

Re: your feedback to my first project please Terry Reedy <tjreedy@udel.edu> - 2012-01-10 20:53 -0500

csiph-web