Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #40187

Re: suggestions for improving code fragment please

Date 2013-02-28 16:28 -0500
From Dave Angel <davea@davea.name>
Subject Re: suggestions for improving code fragment please
References <u8idnaoktKrcKbLMnZ2dnUVZ8uednZ2d@brightview.co.uk> <20130228143715.4e5ada26@bigbox.christie.dr>
Newsgroups comp.lang.python
Message-ID <mailman.2685.1362086914.2939.python-list@python.org> (permalink)

Show all headers | View raw


On 02/28/2013 03:37 PM, Tim Chase wrote:
> On 2013-02-28 19:47, The Night Tripper wrote:
>> Hi there
>>      I'm being very dumb ... how can I simplify this fragment?
>>
>>
>>          if arglist:
>>              arglist.pop(0)
>>              if arglist:
>>                  self.myparm1 = arglist.pop(0)
>>                  if arglist:
>>                      self.myparm2 = arglist.pop(0)
>>                      if arglist:
>>                          self.myparm3 = arglist.pop(0)
>>                          if arglist:
>>                              self.parm4 = arglist.pop(0)
>
> If they're arbitrarily named attributes of the "self", you could do
> something like
>
>    for attr in ("myparm1", "myparm2", "myparm3", ...):
>      if arglist:
>        setattr(self, attr, arglist.pop(0))
>      else:
>        break
>
> -tkc
>
>
>
Or something like (untested):

     for name, value in zip(["myparm1", "myparm2", "myparm3"], arglist):
          setattr(self, name, value)
     arglist = []     #if you care how it ends up


-- 
DaveA

Back to comp.lang.python | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

suggestions for improving code fragment please The Night Tripper <jkn+gg@nicorp.co.uk> - 2013-02-28 19:47 +0000
  Re: suggestions for improving code fragment please Rick Johnson <rantingrickjohnson@gmail.com> - 2013-02-28 11:55 -0800
  Re: suggestions for improving code fragment please Joel Goldstick <joel.goldstick@gmail.com> - 2013-02-28 14:56 -0500
    Re: suggestions for improving code fragment please The Night Tripper <jkn+gg@nicorp.co.uk> - 2013-02-28 23:20 +0000
  Re: suggestions for improving code fragment please Ian Kelly <ian.g.kelly@gmail.com> - 2013-02-28 12:58 -0700
  Re: suggestions for improving code fragment please Tim Chase <python.list@tim.thechases.com> - 2013-02-28 14:37 -0600
  Re: suggestions for improving code fragment please MRAB <python@mrabarnett.plus.com> - 2013-02-28 21:13 +0000
  Re: suggestions for improving code fragment please Mitya Sirenef <msirenef@lightbird.net> - 2013-02-28 16:22 -0500
  Re: suggestions for improving code fragment please Dave Angel <davea@davea.name> - 2013-02-28 16:28 -0500
  Re: suggestions for improving code fragment please Terry Reedy <tjreedy@udel.edu> - 2013-02-28 16:30 -0500
  Re: suggestions for improving code fragment please Tim Chase <python.list@tim.thechases.com> - 2013-02-28 16:44 -0600
  Re: suggestions for improving code fragment please Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-03-01 02:44 +0000

csiph-web