Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #101207

Re: Consistent error

From Chris Angelico <rosuav@gmail.com>
Newsgroups comp.lang.python
Subject Re: Consistent error
Date 2016-01-04 01:47 +1100
Message-ID <mailman.205.1451832473.11925.python-list@python.org> (permalink)
References <6f54629c-745f-4f75-a267-0f174cc1aea1@googlegroups.com>

Show all headers | View raw


On Mon, Jan 4, 2016 at 1:35 AM,  <cc.fezeribe@gmail.com> wrote:
> Here's my code in python :
>
> def get_algorithm_result( numlist ):
>  largest = numlist[0]
>  i = 1
>  while ( i < len(numlist) ):
>    if ( largest < numlist[i]):
>      largest = numlist[i]
>      i = i + 1
>      numlist[i] = numlist[-1]
>      return largest
>      numlist = [1,2,3,4,5]
>      largest = get_algorithm_result(numlist)
>      print largest
> def prime_number(x):
>  return len([n for n in range(1, x + 1) if x % n == 0]) <= 2

I'm a bit uncertain of your indentation here, partly because there's
so little of it; what happens in the while loop if the 'if' condition
is false?

After a 'return' statement, nothing will be executed. If you write
code like this:

if some_condition:
    do_stuff()
    return something
    do_more_stuff()

the second call will never happen - the function will immediately bail
out. Maybe you meant for the subsequent code to be unindented? I'm not
sure.

Have a very careful read of your requirements, and try to lay your
code out the exact same way. Put comments against each block of code
to show which part of the required algorithm it's performing. That
way, you divide the problem up some, and you can look at each piece
separately.

ChrisA

Back to comp.lang.python | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Consistent error cc.fezeribe@gmail.com - 2016-01-03 06:35 -0800
  Re: Consistent error Chris Angelico <rosuav@gmail.com> - 2016-01-04 01:47 +1100
    Re: Consistent error cc.fezeribe@gmail.com - 2016-01-03 07:59 -0800
      Re: Consistent error Chris Angelico <rosuav@gmail.com> - 2016-01-04 03:14 +1100
        Re: Consistent error cc.fezeribe@gmail.com - 2016-01-03 08:55 -0800
          Re: Consistent error Alister <alister.ware@ntlworld.com> - 2016-01-03 18:22 +0000
      Re: Consistent error Ian Kelly <ian.g.kelly@gmail.com> - 2016-01-03 09:27 -0700
        Re: Consistent error cc.fezeribe@gmail.com - 2016-01-03 08:59 -0800
          Re: Consistent error iykeluvzu@gmail.com - 2016-01-15 06:15 -0800

csiph-web