Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #109804

Re: i'm a python newbie & wrote my first script, can someone critique it?

Path csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From Christopher Reimer <christopher_reimer@icloud.com>
Newsgroups comp.lang.python
Subject Re: i'm a python newbie & wrote my first script, can someone critique it?
Date Fri, 10 Jun 2016 16:05:28 -0700
Lines 14
Message-ID <mailman.144.1465603541.2306.python-list@python.org> (permalink)
References <d7259e19-2c36-4282-9f57-bc46a6d5d641@googlegroups.com> <C25AE7F9-D6BD-46EE-90E2-21072856BA58@icloud.com>
Mime-Version 1.0 (1.0)
Content-Type text/plain; charset=us-ascii
Content-Transfer-Encoding quoted-printable
X-Trace news.uni-berlin.de wSBWZwMcIOplp4Rmkrua9ARliZPaecZMKplm3qP/01IA==
Return-Path <christopher_reimer@icloud.com>
X-Original-To python-list@python.org
Delivered-To python-list@mail.python.org
X-Spam-Status OK 0.026
X-Spam-Evidence '*H*': 0.95; '*S*': 0.00; 'python,': 0.02; 'cc:addr :python-list': 0.09; 'subject:script': 0.09; 'subject:python': 0.14; 'basic.': 0.16; 'received:io': 0.16; 'received:psf.io': 0.16; 'scientist': 0.16; 'wrote:': 0.16; 'cc:2**0': 0.20; 'cc:addr:python.org': 0.20; 'cc:no real name:2**0': 0.22; 'wondering': 0.25; 'chris': 0.26; 'received:17': 0.27; 'cap': 0.29; 'comments': 0.30; 'code': 0.30; 'received:10.0.0': 0.32; 'done,': 0.33; 'lock': 0.33; 'received:10.0': 0.34; 'could': 0.35; 'subject:?': 0.36; 'pm,': 0.36; 'subject:: ': 0.37; 'received:10': 0.37; 'charset:us-ascii': 0.37; 'things': 0.38; 'delete': 0.38; 'header:MIME-version:1': 0.60; 'your': 0.60; 'iphone': 0.63; 'better.': 0.66; 'subject: & ': 0.74; 'header:In-reply-to:1': 0.84; 'subject:, \n ': 0.84
X-Proofpoint-Virus-Version vendor=fsecure engine=2.50.10432:,, definitions=2016-06-10_14:,, signatures=0
X-Proofpoint-Spam-Details rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510270003 definitions=main-1606100256
X-Mailer iPhone Mail (13F69)
In-reply-to <d7259e19-2c36-4282-9f57-bc46a6d5d641@googlegroups.com>
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=4d515a; t=1465599930; bh=JIyNQf+OkvO7D/u6+zz7aW1ftApAxvG0Yiyc4uzX7pM=; h=Content-type:MIME-version:Subject:From:Date:Message-id:To; b=AYeG8nYSxsG0Cq2Gam8+AzyPLOl+U8t7YH9vYNwtSYY6sc7UmCMGRG7qu99isjj7m srNRP8mfGrb2MzrNcb4pN9auCN/WXGK+/QmprtyHeQlsypBq1Yk+SmwVqqdz4DjsvW MesznkDsDrksxZUCXDPrf7L4Ncx6QifpV23ieY7ldM94Vs4sSu89ZYlFh15s5NuX0W qSnFWsuX+CXAPd7VAa1dnXZv0aUyHw70c/3jj1AsFykhh0PNMIfT5kOo6hBgS89NMb x52ltqi2l0BhQdLMrpjx82W6HJdtixzETugohDoXb0zYcltsh37xuJ+/luGo0TKxVz qRry1RMlSkHDQ==
X-BeenThere python-list@python.org
X-Mailman-Version 2.1.22
Precedence list
List-Id General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive <http://mail.python.org/pipermail/python-list/>
List-Post <mailto:python-list@python.org>
List-Help <mailto:python-list-request@python.org?subject=help>
List-Subscribe <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
X-Mailman-Original-Message-ID <C25AE7F9-D6BD-46EE-90E2-21072856BA58@icloud.com>
X-Mailman-Original-References <d7259e19-2c36-4282-9f57-bc46a6d5d641@googlegroups.com>
Xref csiph.com comp.lang.python:109804

Show key headers only | View raw


Sent from my iPhone

> On Jun 10, 2016, at 3:52 PM, mad scientist jr <mad.scientist.jr@gmail.com> wrote:
> . 
> Now that it's done, I am wondering what kind of things I could do better.

This is Python, not BASIC. Lay off on the CAP LOCK key and delete all the comments and separation blocks. No one is going to find your code in all that noise.

Chris R.

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

i'm a python newbie & wrote my first script, can someone critique it? mad scientist jr <mad.scientist.jr@gmail.com> - 2016-06-10 15:52 -0700
  Re: i'm a python newbie & wrote my first script, can someone critique it? Christopher Reimer <christopher_reimer@icloud.com> - 2016-06-10 16:05 -0700
  Re: i'm a python newbie & wrote my first script, can someone critique it? Marc Brooks <marcwbrooks@gmail.com> - 2016-06-10 20:51 -0400
  Re: i'm a python newbie & wrote my first script, can someone critique it? Joel Goldstick <joel.goldstick@gmail.com> - 2016-06-10 21:02 -0400
  Re: i'm a python newbie & wrote my first script, can someone critique it? Larry Hudson <orgnut@yahoo.com> - 2016-06-10 21:00 -0700
  Re: i'm a python newbie & wrote my first script, can someone critique it? Matt Wheeler <m@funkyhat.org> - 2016-06-11 04:28 +0000
    Re: i'm a python newbie & wrote my first script, can someone critique it? mad scientist jr <mad.scientist.jr@gmail.com> - 2016-06-11 10:59 -0700
      Re: i'm a python newbie & wrote my first script, can someone critique it? mad scientist jr <mad.scientist.jr@gmail.com> - 2016-06-11 11:14 -0700
        Re: i'm a python newbie & wrote my first script, can someone critique it? Marc Brooks <marcwbrooks@gmail.com> - 2016-06-11 18:18 +0000
      Re: i'm a python newbie & wrote my first script, can someone critique it? MRAB <python@mrabarnett.plus.com> - 2016-06-11 19:41 +0100
        Re: i'm a python newbie & wrote my first script, can someone critique it? mad scientist jr <mad.scientist.jr@gmail.com> - 2016-06-12 09:04 -0700

csiph-web