Groups > comp.lang.java.programmer > #20462

Re: Need clarification on Object.equals.

Newsgroups	comp.lang.java.programmer
Date	2012-12-18 10:48 -0800
References	<e6f674ec-f00d-4b22-bc02-e1c0ff9ff196@oi3g2000pbb.googlegroups.com> <kaqcdf$p45$1@dont-email.me>
Message-ID	<909022a2-ead4-45e6-9f43-79b5013e04ee@googlegroups.com> (permalink)
Subject	Re: Need clarification on Object.equals.
From	plewto@gmail.com

Show all headers | View raw

On Tuesday, December 18, 2012 12:24:44 PM UTC-6, markspace wrote:
> On 12/18/2012 12:13 AM,
> 
> > 	Node a = new Gate();
> 
> > 	Monitor b = new Monitor();
> 
> > 	System.out.println(a.equals(b)); // --> prints 'true'
> 
> ...
> 
> > The underlying production code is a bit complex to include here. My
> 
> 
> 
> This is a red flag.  The code should not be so complex that you can't 
> 
> show us what is really going on.  If it *is* too complex, then likely 
> 
> the issue is the complexity itself.
> 
> 
> 
> However, I think Roedy zeroed in on the most likely cause.  Your 
> 
> abstract class, Node (or some superclass), implements equals() 
> 
> *incorrectly* and is returning true when it should not.  Probably Node() 
> 
> should not implement equals() at all.
> 
> 
> 
> Show us the implementation of equals() for Node (and probably Gate too, 
> 
> that version of equals() could also be borked in the example you gave) 
> 
> and we'll point out the error.

It is complex because it is a large application. I can either post the several hundred lines of source or the the 6 which adequately illustrates the point. Node does not implement equals at all as you say

Thread

Need clarification on Object.equals. "plewto@gmail.com" <plewto@gmail.com> - 2012-12-18 00:13 -0800
  Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-18 10:39 +0000
    Re: Need clarification on Object.equals. Roedy Green <see_website@mindprod.com.invalid> - 2012-12-18 04:48 -0800
      Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-18 10:56 -0800
        Re: Need clarification on Object.equals. FredK <fred.l.kleinschmidt@gmail.com> - 2012-12-19 08:13 -0800
          Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 11:22 -0500
            Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 17:43 +0100
              Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 12:06 -0500
                Re: Need clarification on Object.equals. Patricia Shanahan <pats@acm.org> - 2012-12-19 09:39 -0800
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 13:24 -0500
            Re: Need clarification on Object.equals. FredK <fred.l.kleinschmidt@gmail.com> - 2012-12-19 11:23 -0800
          Re: Need clarification on Object.equals. Patricia Shanahan <pats@acm.org> - 2012-12-19 08:25 -0800
    Re: Need clarification on Object.equals. plewto@gmail.com - 2012-12-18 10:56 -0800
      Re: Need clarification on Object.equals. Jim Janney <jjanney@shell.xmission.com> - 2012-12-18 14:24 -0700
        Re: Need clarification on Object.equals. Patricia Shanahan <pats@acm.org> - 2012-12-18 13:52 -0800
  Re: Need clarification on Object.equals. markspace <-@.> - 2012-12-18 10:24 -0800
    Re: Need clarification on Object.equals. plewto@gmail.com - 2012-12-18 10:48 -0800
      Re: Need clarification on Object.equals. David Lamb <dalamb@cs.queensu.ca> - 2012-12-18 14:01 -0500
        Re: Need clarification on Object.equals. plewto@gmail.com - 2012-12-18 12:14 -0800
          Re: Need clarification on Object.equals. plewto@gmail.com - 2012-12-18 12:17 -0800
            Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-18 22:16 -0500
              Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 10:20 +0000
                Re: Need clarification on Object.equals. Patricia Shanahan <pats@acm.org> - 2012-12-19 03:22 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 12:06 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 09:07 -0500
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 09:09 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 14:36 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 09:42 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 15:05 +0000
                Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 16:15 +0100
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 15:47 +0000
                Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 16:57 +0100
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 16:51 +0000
                Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 18:12 +0100
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 17:27 +0000
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 11:40 -0800
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 10:17 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 15:40 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 10:50 -0500
                Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 17:01 +0100
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 10:22 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 18:49 +0000
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 11:41 -0800
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-19 17:05 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-20 08:34 +0000
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-20 07:27 -0800
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-20 09:04 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-20 18:10 +0000
                Re: Need clarification on Object.equals. Lew <lewbloch@gmail.com> - 2012-12-20 11:08 -0800
                Re: Need clarification on Object.equals. Peter Dunihơ <Np0eStPeAdM@NnOwSlPiAnMk.com> - 2012-12-21 07:50 +0000
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-21 07:30 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-21 17:09 +0000
                Re: Need clarification on Object.equals. Leŵ <lewbl0ch@gmail.com> - 2012-12-23 00:54 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-21 12:23 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-21 17:38 +0000
                Re: Need clarification on Object.equals. Arne Vajhoj <arne@vajhoj.dk> - 2012-12-23 00:50 +0000
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-21 08:39 +0000
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-20 13:39 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-21 08:34 +0000
                Re: Need clarification on Object.equals. Leif Roar Moldskred <leifm@dimnakorr.com> - 2012-12-19 09:22 -0600
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 15:35 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 10:56 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 17:08 +0000
                Re: Need clarification on Object.equals. Joshua Cranmer <Pidgeot18@verizon.invalid> - 2012-12-19 08:58 -0600
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 15:32 +0000
                Re: Need clarification on Object.equals. Joshua Cranmer <Pidgeot18@verizon.invalid> - 2012-12-19 11:08 -0600
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 17:32 +0000
                Re: Need clarification on Object.equals. Lars Enderin <lars.enderin@telia.com> - 2012-12-19 18:41 +0100
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 17:58 +0000
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 18:12 +0000
                Re: Need clarification on Object.equals. Joshua Cranmer <Pidgeot18@verizon.invalid> - 2012-12-19 12:29 -0600
                Re: Need clarification on Object.equals. Joshua Cranmer <Pidgeot18@verizon.invalid> - 2012-12-19 12:00 -0600
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 18:06 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 13:13 -0500
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-19 07:48 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 16:48 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 12:09 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 17:50 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 13:14 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 18:59 +0000
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 13:16 -0500
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 19:05 +0000
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 11:45 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 20:00 +0000
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-19 17:15 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-20 09:22 +0000
                Re: Need clarification on Object.equals. Peter Duniho <NpOeStPeAdM@NnOwSlPiAnMk.com> - 2012-12-20 07:36 -0800
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 10:19 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-19 19:16 +0000
                Re: Need clarification on Object.equals. Gene Wirchenko <genew@telus.net> - 2012-12-19 11:48 -0800
                Re: Need clarification on Object.equals. Leif Roar Moldskred <leifm@dimnakorr.com> - 2012-12-19 14:12 -0600
                Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 09:04 -0500
                Re: Need clarification on Object.equals. Lew <lewbloch@gmail.com> - 2012-12-19 13:40 -0800
                Re: Need clarification on Object.equals. lipska the kat <lipskathekat@yahoo.co.uk> - 2012-12-20 09:30 +0000
          Re: Need clarification on Object.equals. Lew <lewbloch@gmail.com> - 2012-12-18 12:52 -0800
          Re: Need clarification on Object.equals. Joshua Cranmer <Pidgeot18@verizon.invalid> - 2012-12-19 09:27 -0600
            Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-19 10:44 -0500
      Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-18 22:11 -0500
  Re: Need clarification on Object.equals. Arne Vajhøj <arne@vajhoej.dk> - 2012-12-18 22:10 -0500

csiph-web