Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.python > #50922

Re: Find and Replace Simplification

Show all headers | View raw

On 07/19/2013 12:22 PM, Steven D'Aprano wrote:
> On Fri, 19 Jul 2013 09:22:48 -0400, Devyn Collier Johnson wrote:
>
>> I have some code that I want to simplify. I know that a for-loop would
>> work well, but can I make re.sub perform all of the below tasks at once,
>> or can I write this in a way that is more efficient than using a
>> for-loop?
>>
>> DATA = re.sub(',', '', 'DATA')
>> DATA = re.sub('\'', '', 'DATA')
>> DATA = re.sub('(', '', 'DATA')
>> DATA = re.sub(')', '', 'DATA')
>
> I don't think you intended to put DATA in quotes on the right hand side.
> That makes it literally the string D A T A, so all those replacements are
> no-ops, and you could simplify it to:
>
> DATA = 'DATA'
>
> But that's probably not what you wanted.
>
> My prediction is that this will be by far the most efficient way to do
> what you are trying to do:
>
> py> DATA = "Hello, 'World'()"
> py> DATA.translate(dict.fromkeys(ord(c) for c in ",'()"))
> 'Hello World'
>
> That's in Python 3 -- in Python 2, using translate will still probably be
> the fastest, but you'll need to call it like this:
>
> import string
> DATA.translate(string.maketrans("", ""), ",'()")
>
> I also expect that the string replace() method will be second fastest,
> and re.sub will be the slowest, by a very long way.
>
> As a general rule, you should avoiding using regexes unless the text you
> are searching for actually contains a regular expression of some kind. If
> it's merely a literal character or substring, standard string methods
> will probably be faster.
>
>
> Oh, and a tip for you:
>
> - don't escape quotes unless you don't need to, use the other quote.
>
> s = '\''  # No, don't do this!
> s = "'"  # Better!
>
> and vice versa.
>
>
>
>
Thanks for finding that error; DATA should not be in quotes. I cannot 
believe I missed that. Good eye Steven!

Using the replace command is a brilliant idea; I will implement that 
where ever I can. I am wanting to perform all of the replaces at once. 
Is that possible?

Mahalo,
DCJ

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Find and Replace Simplification Devyn Collier Johnson <devyncjohnson@gmail.com> - 2013-07-19 09:22 -0400
  Re: Find and Replace Simplification Novocastrian_Nomad <gregory.j.baker@gmail.com> - 2013-07-19 06:38 -0700
  Re: Find and Replace Simplification John Gordon <gordon@panix.com> - 2013-07-19 14:28 +0000
  Re: Find and Replace Simplification Steven D'Aprano <steve+comp.lang.python@pearwood.info> - 2013-07-19 16:22 +0000
    Re: Find and Replace Simplification Serhiy Storchaka <storchaka@gmail.com> - 2013-07-19 20:29 +0300
    Re: Find and Replace Simplification Skip Montanaro <skip@pobox.com> - 2013-07-19 13:08 -0500
    Re: Find and Replace Simplification Devyn Collier Johnson <devyncjohnson@gmail.com> - 2013-07-19 17:44 -0400
    Re: Find and Replace Simplification Dave Angel <davea@davea.name> - 2013-07-19 18:45 -0400
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-20 12:16 +0100
    Re: Find and Replace Simplification Serhiy Storchaka <storchaka@gmail.com> - 2013-07-20 14:48 +0300
    Re: Find and Replace Simplification Serhiy Storchaka <storchaka@gmail.com> - 2013-07-20 14:57 +0300
    Re: Find and Replace Simplification Devyn Collier Johnson <devyncjohnson@gmail.com> - 2013-07-20 08:41 -0400
    Re: Find and Replace Simplification Devyn Collier Johnson <devyncjohnson@gmail.com> - 2013-07-20 08:50 -0400
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-20 18:03 +0100
    Re: Find and Replace Simplification Dave Angel <davea@davea.name> - 2013-07-20 14:04 -0400
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-20 19:37 +0100
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-20 19:41 +0100
    Re: Find and Replace Simplification Dave Angel <davea@davea.name> - 2013-07-20 17:56 -0400
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-20 23:33 +0100
    Re: Find and Replace Simplification Serhiy Storchaka <storchaka@gmail.com> - 2013-07-21 10:44 +0300
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-21 12:29 +0100
    Re: Find and Replace Simplification Serhiy Storchaka <storchaka@gmail.com> - 2013-07-21 15:28 +0300
    Re: Find and Replace Simplification Joshua Landau <joshua@landau.ws> - 2013-07-21 13:49 +0100

csiph-web