Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > gnu.groff.bug > #1838

[bug #58314] [PATCH] preconv.cpp: Add block delimiters for an if-clause

Show all headers | View raw

Update of bug #58314 (project groff):

                  Status:                    None => Need Info              
             Assigned to:                    None => gbranden               

    _______________________________________________________

Follow-up Comment #1:

Please remember the '' tag in the future.  The Savannah bug renderer on the
Web is not very robust in its absence.

[comment #0 original submission:]
> From bfda94f0ffbf1cce3a35370f650564affe4a5535 Mon Sep 17 00:00:00 2001
> From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
> Date: Wed, 6 May 2020 20:29:43 +0000
> Subject: [PATCH] preconv.cpp: Add block delimiters for an if-clause
> 
>   Warning from the compiler:
> 
> ../src/preproc/preconv/preconv.cpp: In function 'char*
get_late_coding_tag(FILE*)':
> ../src/preproc/preconv/preconv.cpp:959:6: warning: suggest explicit braces
to avoid ambiguous 'else' [-Wdangling-else]
>   959 |   if (fseek(fp, -limit, SEEK_END) != 0)
>       |      ^
> 
>   Always use block delimiters to help the compiler to know explicitly
> what belongs to a block.

That's not the brace style in use in the codebase.

>   Indention is a pseudo (unreal) structure element, intended only for
> humans.
> 
>   Compilers don't "see" nor do they count, how many tabs or space
> characters there are in front of a command word.

I'm aware of all this.  My own brace style preference is 1TBS.

The groff brace style is pretty close to that mandated by the GNU Coding
Standards:

https://www.gnu.org/prep/standards/html_node/Formatting.html

However, a grep reveals that the existing codebase does not brace 'do-while'
structures as GNU instructs.

Possibly an oversight, as do-whiles are rare relative to while-do.

The code works as I intend (I have a whole pile of negative test cases I can
share).  Does this warning get thrown for anything else in the groff source
tree?

I welcome comments from other groff developers.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58314>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/

Back to gnu.groff.bug | Previous | Next | Find similar

Thread

[bug #58314] [PATCH] preconv.cpp: Add block delimiters for an if-clause "G. Branden Robinson" <INVALID.NOREPLY@gnu.org> - 2020-05-07 18:25 -0400

csiph-web