Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.ruby > #2866

Re: Exclusive float range, Range#step result in counterintuitive result

Show all headers | View raw

This looks like a bug to me.

(The problem exists as of 1.9.2-p180.)

In <range.c>, `range_step' is the implementation of Range#step. It calls 
`ruby_float_step', which is implemented in <numeric.c>, to handle float 
stepping.

The call looks like this:

    else if (ruby_float_step(b, e, step, EXCL(range))) {
  /* done */
    }

The problem is that it passes the `exclude_end?' property of the range 
to `ruby_float_step', in our case it is false. Inside the implementation 
of `ruby_float_step' is something like:

      n = floor(n + err);
      if (!excl) n++;
      for (i=0; i<n; i++) {
    rb_yield(DBL2NUM(i*unit+beg));
      }

And excl is the last parameter. Clearly if the end value of the range is 
x, then the iteration only goes to floor(x)-1.

On the other hand -

p 1.step(6.3).to_a # => [1.0, 2.0, 3.0, 4.0, 5.0, 6.0]

This works since `num_step', again implemented in <numeric.c>, 
explicitly passes a false to excl:

    else if (!ruby_float_step(from, to, step, FALSE)) {
        ...

-- 
Posted via http://www.ruby-forum.com/.

Back to comp.lang.ruby | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Exclusive float range, Range#step result in counterintuitive result Joey Zhou <yimutang@gmail.com> - 2011-04-14 07:42 -0500
  Re: Exclusive float range, Range#step result in counterintuitive result Joey Zhou <yimutang@gmail.com> - 2011-04-14 07:58 -0500
  Re: Exclusive float range, Range#step result in counterintuitive result Robert Klemme <shortcutter@googlemail.com> - 2011-04-14 08:28 -0500
  Re: Exclusive float range, Range#step result in counterintuitive result 7stud -- <bbxx789_05ss@yahoo.com> - 2011-04-14 11:47 -0500
  Re: Exclusive float range, Range#step result in counterintuitive result Su Zhang <zhangsu@live.com> - 2011-04-14 13:01 -0500

csiph-web