Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > comp.os.linux.advocacy > #92299
| From | Phil Carmody <thefatphil_demunged@yahoo.co.uk> |
|---|---|
| Newsgroups | comp.os.linux.advocacy, comp.os.linux.embedded |
| Subject | Re: Reading the Riot Act To ARM's developers |
| Date | 2012-02-27 15:52 +0200 |
| Organization | A noiseless patient Spider |
| Message-ID | <87zkc4mlho.fsf@bazspaz.fatphil.org> (permalink) |
| References | <WGiYq.100467$WX2.28685@newsfe28.ams2> <4iah09-1p2.ln1@spankydtr.localhost.net> <PYqZq.3558$FY5.2955@newsfe10.ams2> <87fwdzpbqe.fsf@bazspaz.fatphil.org> <TIa2r.45441$6J5.28348@newsfe17.ams2> |
Cross-posted to 2 groups.
7 <email_at_www_at_enemygadgets_dot_com@enemygadgets.com> writes:
> Phil Carmody wrote:
> >> #define INT_XMA (1 << 4)
> >> #define ENABLE_RS232 SYSCON->INT |= INT_XMA
> >
> > Ewwww! Don't do that.
> >
> >> The problem I am having is what does that '4' mean. Is it 4 or 14 or
> >> something else? I need a datasheet. Thats just crap programming.
> >>
> >> What I want to be able to do is
> >>
> >> #define ENABLED 1
> >> #define ENABLE_RS232_INTERRUPT SYSCON.INT.INT_XMA = ENABLED
> >
> > Ewww! Don't do that either.
> >
> > NACKed.
>
> By all means save us the laughs and
> write one line of code to say what you would do.
Well, even the mindless robotic conversion to
#define ENABLE_RS232_INTERRUPT() do { SYSCON.INT.INT_XMA = ENABLED; } while(0)
would be better than what you had.
Phil
--
> I'd argue that there is much evidence for the existence of a God.
Pics or it didn't happen.
-- Tom (/. uid 822)
Back to comp.os.linux.advocacy | Previous | Next — Previous in thread | Next in thread | Find similar
Re: Reading the Riot Act To ARM's developers Phil Carmody <thefatphil_demunged@yahoo.co.uk> - 2012-02-25 10:18 +0200
Re: Reading the Riot Act To ARM's developers 7 <email_at_www_at_enemygadgets_dot_com@enemygadgets.com> - 2012-02-25 19:34 +0000
Re: Reading the Riot Act To ARM's developers Phil Carmody <thefatphil_demunged@yahoo.co.uk> - 2012-02-27 15:52 +0200
Re: Reading the Riot Act To ARM's developers David Brown <david.brown@removethis.hesbynett.no> - 2012-02-27 22:04 +0100
While( Ch ) if ( Ch‑1 <= 32 ) *P -= 32 ; Jeff-Relf.Me <x@x.Invalid> - 2012-02-28 05:52 -0800
csiph-web