Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.c > #5743

Re: bdiff

From blp@cs.stanford.edu (Ben Pfaff)
Newsgroups comp.lang.c
Subject Re: bdiff
Date 2011-06-09 12:33 -0700
Message-ID <87boy6241i.fsf@blp.benpfaff.org> (permalink)
References (5 earlier) <95av9fFrnrU11@mid.individual.net> <95b018FvdmU1@mid.individual.net> <95bg72Fjo2U1@mid.individual.net> <isq2mv$c6h$1@speranza.aioe.org> <95ckn0Fg9bU1@mid.individual.net>

Show all headers | View raw


Uno <Uno@example.invalid> writes:

>     while (((c = fgetc(fp)) != EOF) || ((d = fgetc(fq)) != EOF)) {

You want to read one byte from each file on every loop iteration,
but this will only read from fq if the read from fp fails.

Try something more like this:

for (;;) {
  c = fgetc(fp);
  d = fgetc(fq);
  if (c == EOF || d == EOF)
    break;
-- 
"A lesson for us all: Even in trivia there are traps."
--Eric Sosman

Back to comp.lang.c | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

variable-length strings Uno <Uno@example.invalid> - 2011-06-01 03:36 -0600
  Re: variable-length strings ccc31807 <cartercc@gmail.com> - 2011-06-01 07:13 -0700
    Re: variable-length strings Uno <Uno@example.invalid> - 2011-06-02 10:54 -0600
  Re: variable-length strings "George Mpouras" <nospam.gravitalsun@hotmail.com.nospam> - 2011-06-01 17:01 +0300
  Re: variable-length strings "Peter J. Holzer" <hjp-usenet2@hjp.at> - 2011-06-02 15:33 +0200
  Re: variable-length strings "Peter J. Holzer" <hjp-usenet2@hjp.at> - 2011-06-02 15:44 +0200
    Re: bdiff Uno <Uno@example.invalid> - 2011-06-08 21:59 -0600
      Re: bdiff Ian Collins <ian-news@hotmail.com> - 2011-06-09 16:08 +1200
        Re: bdiff Uno <Uno@example.invalid> - 2011-06-08 22:20 -0600
          Re: bdiff Uno <Uno@example.invalid> - 2011-06-09 02:57 -0600
            Re: bdiff Janis Papanagnou <janis_papanagnou@hotmail.com> - 2011-06-09 11:10 +0200
              Re: bdiff Uno <Uno@example.invalid> - 2011-06-09 13:19 -0600
                Re: bdiff James Waldby <not@valid.invalid> - 2011-06-09 19:32 +0000
                Re: bdiff Angel <angel+news@spamcop.net> - 2011-06-09 19:32 +0000
                Re: bdiff Uno <Uno@example.invalid> - 2011-06-09 15:28 -0600
                Re: bdiff blp@cs.stanford.edu (Ben Pfaff) - 2011-06-09 12:33 -0700
                Re: bdiff Uno <Uno@example.invalid> - 2011-06-09 15:15 -0600
                Re: bdiff pacman@kosh.dhis.org (Alan Curry) - 2011-06-09 22:17 +0000
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-20 19:14 +0000
                Re: bdiff Robert Wessel <robertwessel2@yahoo.com> - 2011-06-20 18:43 -0500
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-21 20:39 +0000
                Re: bdiff Joe Wright <joewwright@comcast.net> - 2011-06-21 18:38 -0400
                Re: bdiff Robert Wessel <robertwessel2@yahoo.com> - 2011-06-21 18:11 -0500
                Re: bdiff Michael Press <rubrum@pacbell.net> - 2011-06-22 15:51 -0700
                Re: bdiff Stephen Sprunk <stephen@sprunk.org> - 2011-06-21 07:49 -0500
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-21 20:40 +0000
                Re: bdiff superpollo <superpollo@tznvy.pbz> - 2011-06-22 09:59 +0200
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-22 19:57 +0000
                Re: bdiff superpollo <superpollo@tznvy.pbz> - 2011-06-23 21:16 +0200
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-24 19:36 +0000
                Re: bdiff superpollo <superpollo@tznvy.pbz> - 2011-06-24 22:48 +0200
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-24 21:17 +0000
                Re: bdiff Robert Wessel <robertwessel2@yahoo.com> - 2011-06-24 17:20 -0500
                Re: bdiff blmblm@myrealbox.com <blmblm.myrealbox@gmail.com> - 2011-06-22 19:55 +0000
                Re: bdiff Eric Sosman <esosman@ieee-dot-org.invalid> - 2011-06-21 21:40 -0400
                Re: bdiff Azazel <azazel@remove.azazel.net> - 2011-06-22 09:06 -0500
                Re: bdiff Ben Bacarisse <ben.usenet@bsb.me.uk> - 2011-06-22 16:47 +0100
                Re: bdiff Stephen Sprunk <stephen@sprunk.org> - 2011-06-22 11:23 -0500
                Re: bdiff Ike Naar <ike@sverige.freeshell.org> - 2011-06-09 21:37 +0000
            Re: bdiff bonomi@host122.r-bonomi.com (Robert Bonomi) - 2011-06-19 06:10 -0500
      Re: bdiff Eric Sosman <esosman@ieee-dot-org.invalid> - 2011-06-09 07:13 -0400
        Re: bdiff Uno <Uno@example.invalid> - 2011-06-09 13:30 -0600
          Re: bdiff Keith Thompson <kst-u@mib.org> - 2011-06-09 13:29 -0700
            Re: bdiff Uno <merrilljensen@q.com> - 2011-06-09 21:11 -0700
              Re: bdiff "Morris Keesan" <mkeesan@post.harvard.edu> - 2011-06-09 23:58 -0400
                Re: bdiff Uno <Uno@example.invalid> - 2011-06-12 00:47 -0600
                Re: bdiff Angel <angel+news@spamcop.net> - 2011-06-12 07:53 +0000
                Re: bdiff Shao Miller <sha0.miller@gmail.com> - 2011-06-12 12:02 -0500
                Re: bdiff Keith Thompson <kst-u@mib.org> - 2011-06-12 01:24 -0700
                Re: bdiff Shao Miller <sha0.miller@gmail.com> - 2011-06-12 12:18 -0500

csiph-web