Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > muc.lists.netbsd.source-changes > #156109

Re: bin/59587: ftp client ascii transfers with progress report fail

Show all headers | View raw

> Module Name:    src
> Committed By:   lukem
> Date:           Sat Dec  6 06:20:23 UTC 2025
> 
> Modified Files:
>         src/usr.bin/ftp: extern.h ftp.c util.c version.h
> 
> Log Message:
> ftp: fix ascii transfers with progress bar
> 
> Handle stdio interruption by signals and improve error handling
> in getc() and putc() on the control and data channels.
> Provide ftp_getc() and ftp_putc() wrappers that:
> - Retry the operation on EINTR or EAGAIN instead of failing.
> [...]
> +	while ((res = getc(fin)) == EOF) {
> +		if (feof(fin))
> +			break;		/* return EOF */
> +		if (ferror(fin)) {
> +			if ((errno == EINTR) || (errno == EAGAIN)) {
> +					/* retry on EINTR or EAGAIN */
> +				clearerr(fin);
> +				continue;

Why do you loop on EAGAIN?

Is the underlying file descriptor non-blocking?

=> If it is non-blocking, then you presumably need to wait in
   select/poll for input to arrive -- otherwise this is a busy-wait.

=> If it isn't non-blocking, then you should never get EAGAIN here --
   EAGAIN is generally only for non-blocking I/O calls to report that
   they can't perform the requested operation until you wait in
   select/poll for something to become ready (some input data to
   become ready or some output data to be processed from the buffer).

Or is there a bug somewhere that causes some syscall or library
routine involved to return EAGAIN on a signal, when it should really
either restart or return EINTR?  (I have never seen such a bug.)

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-admin@muc.de

Back to muc.lists.netbsd.source-changes | Previous | Next — Next in thread | Find similar

Thread

Re: bin/59587: ftp client ascii transfers with progress report fail Taylor R Campbell <riastradh@NetBSD.org> - 2026-01-15 03:51 +0000
  Re: bin/59587: ftp client ascii transfers with progress report fail Taylor R Campbell <riastradh@NetBSD.org> - 2026-01-15 04:19 +0000
    Re: bin/59587: ftp client ascii transfers with progress report fail Luke Mewburn <luke@mewburn.net> - 2026-01-15 16:34 +1100
      Re: bin/59587: ftp client ascii transfers with progress report fail Taylor R Campbell <riastradh@NetBSD.org> - 2026-01-15 23:56 +0000
  Re: bin/59587: ftp client ascii transfers with progress report fail Luke Mewburn <luke@mewburn.net> - 2026-01-15 16:26 +1100

csiph-web