Re: [gentoo-dev] [PATCH v2] install-qa-check.d/60cargo-eclass: make it a failure for EAPI>=9

From	Michał Górny <mgorny@gentoo.org>
Newsgroups	linux.gentoo.dev
Subject	Re: [gentoo-dev] [PATCH v2] install-qa-check.d/60cargo-eclass: make it a failure for EAPI>=9
Date	2026-05-02 09:20 +0200
Message-ID	<MQcNP-1Yw2-5@gated-at.bofh.it> (permalink)
References	<MQcNP-1Yw2-7@gated-at.bofh.it>
Organization	Gentoo

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, 2026-05-02 at 10:15 +0300, Arthur Zamarin wrote:
> While cargo.eclass doesn't yet support EAPI 9, I want to make it a
> failure for EAPI 9 ebuilds to be merged without the RUST_MIN_VER being
> updated to the correct value.
> 
> The class itself supports currently EAPI=8, so this should be a safe
> change to make, and it will help ensure that the ebuilds are updated in
> a timely manner.
> 
> Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
> ---
>  metadata/install-qa-check.d/60cargo-eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/metadata/install-qa-check.d/60cargo-eclass b/metadata/install-qa-check.d/60cargo-eclass
> index 4fd014b2287..38aca3ca5b3 100644
> --- a/metadata/install-qa-check.d/60cargo-eclass
> +++ b/metadata/install-qa-check.d/60cargo-eclass
> @@ -42,6 +42,9 @@ cargo_ver_check() {
>  		eqawarn "QA Notice: ${min_rust_source}"
>  		eqawarn "which requires RUST_MIN_VER=\"${min_rust_ver}\""
>  		eqawarn
> +
> +		# For EAPI>=9, enforce the ebuild being updated to specify the correct RUST_MIN_VER
> +		[[ ${EAPI} != 8 ]] && die "Update ebuild to specify RUST_MIN_VER=\"${min_rust_ver}\""
>  	fi
>  }
>  

LGTM

-- 
Best regards,
Michał Górny

Back to linux.gentoo.dev | Previous | Next | Find similar

Thread

Re: [gentoo-dev] [PATCH v2] install-qa-check.d/60cargo-eclass: make  it a failure for EAPI>=9 Michał Górny <mgorny@gentoo.org> - 2026-05-02 09:20 +0200

csiph-web