Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.gentoo.dev > #70479

[gentoo-dev] [PATCH 0/3] "bash -n" fixes and nits

From Lukas Schmelting <lschmelting@posteo.com>
Newsgroups linux.gentoo.dev
Subject [gentoo-dev] [PATCH 0/3] "bash -n" fixes and nits
Date 2026-04-29 20:00 +0200
Message-ID <MPhmx-1kDL-3@gated-at.bofh.it> (permalink)
References <MOVvI-166w-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


I just ran bash -n  on the v2 variant and saw bash -n wasn't completely
clean, apologies.

Lukas Schmelting (3):
  metadata/install-qa-check.d: refactor 60udev-eclass
  udev.eclass: add udev_hwdb_update function
  metadata/install-qa-check.d: add udev hwdb check

 eclass/udev.eclass                        |  16 +++
 metadata/install-qa-check.d/60udev-eclass | 139 +++++++++++++++-------
 2 files changed, 114 insertions(+), 41 deletions(-)

$ PAGER=cat git range-diff udev-hwdb-v2...udev-hwdb-v3
1:  cfc1543234b6 ! 1:  f301f364fbc7 metadata/install-qa-check.d: refactor 60udev-eclass
@@ metadata/install-qa-check.d/60udev-eclass: udev_rules_check() {
 +    local need_udev_reload=0
 +
 +    # Check 2a: Check if udev rules must be updated
-+    if _dir_has_nonhidden_files "lib/udev/rules.d"
++    if _dir_has_nonhidden_files "lib/udev/rules.d" \
 +        || _dir_has_nonhidden_files "usr/lib/udev/rules.d"; then
 +        need_udev_reload=1
 +    fi
2:  9759663666c7 ! 2:  28f6c11f5edb udev.eclass: add udev_hwdb_update function
@@ eclass/udev.eclass: udev_reload() {
 +	if [[ -n ${ROOT} ]]; then
 +		return 0
 +	fi
++
 +	ebegin "Running systemd-hwdb update to regenerate binary udev hardware database"
 +	systemd-hwdb update --root "${ROOT}"
 +	eend $?
3:  dcc74cdd89c7 ! 3:  bf6c3230f176 metadata/install-qa-check.d: add udev hwdb check
@@ metadata/install-qa-check.d/60udev-eclass: udev_rules_check() {
 +    local need_udev_hwdb_update=0
  
      # Check 2a: Check if udev rules must be updated
-     if _dir_has_nonhidden_files "lib/udev/rules.d"
+     if _dir_has_nonhidden_files "lib/udev/rules.d" \
 @@ metadata/install-qa-check.d/60udev-eclass: udev_rules_check() {
          need_udev_reload=1
      fi
  
 +    # Check 2b: Check if udev binary hardware database must be updated
-+    if _dir_has_nonhidden_files "lib/udev/hwdb.d"
++    if _dir_has_nonhidden_files "lib/udev/hwdb.d" \
 +       || _dir_has_nonhidden_files "usr/lib/udev/hwdb.d"; then
 +	    need_udev_hwdb_update=1
 +    fi

-- 
2.53.0

Back to linux.gentoo.dev | Previous | NextPrevious in thread | Next in thread | Find similar


Thread

[gentoo-dev] [PATCH 0/3] refactor and extend udev handling Lukas Schmelting <lschmelting@posteo.com> - 2026-04-28 20:20 +0200
  [gentoo-dev] [PATCH 2/3] udev.eclass: add udev_hwdb_reload function Lukas Schmelting <lschmelting@posteo.com> - 2026-04-28 20:30 +0200
    [gentoo-dev] Re: [PATCH 2/3] udev.eclass: add udev_hwdb_reload function Mike Gilbert <floppym@gentoo.org> - 2026-04-28 20:40 +0200
      [gentoo-dev] [PATCH v2 0/2] range-diff v1/v2 Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 00:10 +0200
        [gentoo-dev] [PATCH v2 3/3] metadata/install-qa-check.d: add udev hwdb check Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 00:20 +0200
        [gentoo-dev] [PATCH v2 2/3] udev.eclass: add udev_hwdb_update function Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 00:20 +0200
      [gentoo-dev] [PATCH 3/3] metadata/install-qa-check.d: add udev hwdb check Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 20:00 +0200
      [gentoo-dev] [PATCH 0/3] "bash -n" fixes and nits Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 20:00 +0200
        [gentoo-dev] [PATCH 1/3] metadata/install-qa-check.d: refactor 60udev-eclass Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 20:00 +0200
        [gentoo-dev] [PATCH 2/3] udev.eclass: add udev_hwdb_update function Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 20:00 +0200
          [gentoo-dev] Re: [PATCH 2/3] udev.eclass: add udev_hwdb_update function Mike Gilbert <floppym@gentoo.org> - 2026-04-29 20:40 +0200
            [gentoo-dev] Re: [PATCH 2/3] udev.eclass: add udev_hwdb_update function Lukas Schmelting <lschmelting@posteo.com> - 2026-04-29 21:40 +0200
  [gentoo-dev] [PATCH 1/3] metadata/install-qa-check.d: refactor 60udev-eclass Lukas Schmelting <lschmelting@posteo.com> - 2026-04-28 20:30 +0200
  [gentoo-dev] [PATCH 3/3] metadata/install-qa-check.d: add udev hwdb check Lukas Schmelting <lschmelting@posteo.com> - 2026-04-28 20:30 +0200

csiph-web