Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.gentoo.dev > #70452

Re: [gentoo-dev] [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Eli Schwartz <eschwartz@gentoo.org> writes:

> app-arch/rpm supports various compression types, but usually via USE
> flags. We need ugly strings|grep to see which one is needed. rpm2targz
> dynamically detects `@system` set tools which is why it has worked
> forever.
>
> To solve this we add RPM_COMPRESS_TYPE="" before inheriting the eclass,
> which controls if app-arch/rpm is used. While testing this it also turns
> out legacy lzma, i.e. PayloadIsLzma rather than PayloadIsXz, is not
> supported by rpm2targz at all (despite bug 321439 implying it *was*
> added? the one instance I found in-tree fails). So, exclude it in such
> cases.
>
> The eclass now has effectively a "mandatory for proper support" eclass
> pre-inherit variable which nothing ever set before. Emit an eqawarn if
> it is being "held wrong", to encourage people to set this variable.
>
> Closes: https://bugs.gentoo.org/973073
> Closes: https://bugs.gentoo.org/971578
> Bug: https://bugs.gentoo.org/971600
> Bug: https://bugs.gentoo.org/321439
> Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
> ---
>
> v2:
>
> big rework of BDEPEND generation. The first version of this patch, never
> posted, didn't include legacy lzma handling to split xz/lzma. I added it
> at the last minute and broke >= dependencies on rpm, erasing
> app-arch/rpm if it didn't work, etc. All this logic needed to be
> reverted and reintegrated.
>
> Apologies for submitting a rushed patch and never checking the results.
> I saw the other competing proposal and said "I  better submit quickly".
> :(
>
>  eclass/rpm.eclass | 101 +++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 90 insertions(+), 11 deletions(-)
>
> [...]

LGTM. Thanks.

sam

Back to linux.gentoo.dev | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

[gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-22 16:30 +0200
  [gentoo-dev] [PATCH 4/5] x11-themes/leonidas-backgrounds: set rpm.eclass var for reference rpm support Eli Schwartz <eschwartz@gentoo.org> - 2026-04-22 16:30 +0200
  Re: [gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm support  into pre-inherit variable Nowa Ammerlaan <nowa@gentoo.org> - 2026-04-22 17:20 +0200
    Re: [gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm support  into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-23 00:20 +0200
  Re: [gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm  support into pre-inherit variable Sam James <sam@gentoo.org> - 2026-04-22 18:20 +0200
    Re: [gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm support  into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-23 00:20 +0200
      Re: [gentoo-dev] [PATCH 1/5] rpm.eclass: rework app-arch/rpm  support into pre-inherit variable Sam James <sam@gentoo.org> - 2026-04-23 02:10 +0200
  [gentoo-dev] [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-23 02:50 +0200
    Re: [gentoo-dev] [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm  support into pre-inherit variable Sam James <sam@gentoo.org> - 2026-04-23 03:20 +0200
    Re: [gentoo-dev] [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm  support into pre-inherit variable Nicolas PARLANT <nicolas.parlant@parhuet.fr> - 2026-04-23 06:30 +0200
      Re: [gentoo-dev] [PATCH v2 1/5] rpm.eclass: rework app-arch/rpm  support into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-23 07:00 +0200
  [gentoo-dev] [PATCH v3 0/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200
    [gentoo-dev] [PATCH v3 4/5] x11-themes/leonidas-backgrounds: set rpm.eclass var for reference rpm support Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200
    [gentoo-dev] [PATCH v3 1/5] rpm.eclass: rework app-arch/rpm support into pre-inherit variable Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200
    [gentoo-dev] [PATCH v3 3/5] app-backup/tsm: set rpm.eclass var for reference rpm support Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200
    [gentoo-dev] [PATCH v3 5/5] rpm.eclass: make RPM_COMPRESS_TYPE mandatory in EAPI 9 Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200
    [gentoo-dev] [PATCH v3 2/5] app-office/libreoffice-l10n: set rpm.eclass var for reference rpm support Eli Schwartz <eschwartz@gentoo.org> - 2026-04-24 16:50 +0200

csiph-web