Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #7994 > unrolled thread

Adopting factory-boy

Back to article view | Back to linux.debian.maint.python

Contents

  Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2015-12-19 12:40 +0100
    Re: Adopting factory-boy Dmitry Shachnev <mitya57@debian.org> - 2015-12-19 19:10 +0100
      Re: Adopting factory-boy Thomas Goirand <zigo@debian.org> - 2015-12-23 12:40 +0100
        Re: Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2015-12-23 16:40 +0100
          Re: Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2016-05-11 11:40 +0200
            Re: Adopting factory-boy Thomas Goirand <zigo@debian.org> - 2016-05-11 14:30 +0200
              Re: Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2016-05-11 14:40 +0200
                Re: Adopting factory-boy Thomas Goirand <zigo@debian.org> - 2016-05-12 09:00 +0200
                  Re: Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2016-05-12 10:20 +0200
                    Re: Adopting factory-boy Thomas Goirand <zigo@debian.org> - 2016-05-12 16:20 +0200
                      Re: Adopting factory-boy Christopher Baines <chris@cbaines.net> - 2016-05-12 17:10 +0200

#7994 — Adopting factory-boy

I use python-factory-boy [1] and recently realised that it was removed
from Debian [2]. The reasoning being that it is no longer a dependency
of some OpenStack packages.

I use this (currently through a package of the latest upstream release
created with py2dsc), and would be interested in getting this back in to
Debian.

Currently I am not a member of the Python modules team (request
pending), but I would be interested in maintaining it as part of the team.

The source package can be found here [3], would it be best to try to
continue with the history in that repository and bring it in to
compliance with the team policy (use pristine-tar, use upstream tarballs
to advance the upstream branch and use git-dpm), or to just start from
scratch?

Thanks,

Chris

1: https://tracker.debian.org/pkg/factory-boy
2: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804673
3: https://anonscm.debian.org/cgit/openstack/factory-boy.git/

[toc] | [next] | [standalone]

#7996

[Multipart message — attachments visible in raw view] — view raw

Hi Christopher,

On Sat, Dec 19, 2015 at 11:34:15AM +0000, Christopher Baines wrote:
> [...]
>
> The source package can be found here [3], would it be best to try to
> continue with the history in that repository and bring it in to
> compliance with the team policy (use pristine-tar, use upstream tarballs
> to advance the upstream branch and use git-dpm), or to just start from
> scratch?

Of course it would be better to preserve the changes history.

Basically you need to push the “debian/unstable” branch to the new repository
as “master”, add missing “upstream” and “pristine-tar” branches, and call
“git-dpm init”.

Your upstream branch should be based on commit ac7e11a3389f15bb, so that git
can handle the merge correctly.

--
Dmitry Shachnev

[toc] | [prev] | [next] | [standalone]

#8006

On 12/19/2015 07:06 PM, Dmitry Shachnev wrote:
> Hi Christopher,
> 
> On Sat, Dec 19, 2015 at 11:34:15AM +0000, Christopher Baines wrote:
>> [...]
>>
>> The source package can be found here [3], would it be best to try to
>> continue with the history in that repository and bring it in to
>> compliance with the team policy (use pristine-tar, use upstream tarballs
>> to advance the upstream branch and use git-dpm), or to just start from
>> scratch?
> 
> Of course it would be better to preserve the changes history.
> 
> Basically you need to push the “debian/unstable” branch to the new repository
> as “master”, add missing “upstream” and “pristine-tar” branches, and call
> “git-dpm init”.
> 
> Your upstream branch should be based on commit ac7e11a3389f15bb, so that git
> can handle the merge correctly.
> 
> --
> Dmitry Shachnev

Hi Christopher,

I was the maintainer of this package, though I lost interest for it
because there's no reverse dependency for it.

If you want to continue maintaining it within the OpenStack PKG team,
you can do it as well. Though we're not using git-dpm, and rather a git
tag workflow, you're still free to use whatever workflow you want there,
as long as the package is well maintained.

If you need sponsoring for this package, I can review it and upload it
for you.

Cheers,

Thomas Goirand (zigo)

[toc] | [prev] | [next] | [standalone]

#8009

On 23/12/15 11:31, Thomas Goirand wrote:
> I was the maintainer of this package, though I lost interest for it
> because there's no reverse dependency for it.

Thanks for packaging it :)

> If you want to continue maintaining it within the OpenStack PKG team,
> you can do it as well. Though we're not using git-dpm, and rather a git
> tag workflow, you're still free to use whatever workflow you want there,
> as long as the package is well maintained.
> 
> If you need sponsoring for this package, I can review it and upload it
> for you.

Great, thanks for the offer. I think I'll have to wait a couple of weeks
to see where things are for packaging this. There is at least one new
dependency for the latest release (python-fake-factory), I have packaged
that, but the tests currently don't pass. Once there is a release for
python-fake-factory, for which the tests pass, and that has been
uploaded to Debian, I'll get around to looking at factory-boy again.

[toc] | [prev] | [next] | [standalone]

#8512

[Multipart message — attachments visible in raw view] — view raw

On 23/12/15 15:30, Christopher Baines wrote:
> On 23/12/15 11:31, Thomas Goirand wrote:
>> I was the maintainer of this package, though I lost interest for it
>> because there's no reverse dependency for it.
> 
> Thanks for packaging it :)
> 
>> If you want to continue maintaining it within the OpenStack PKG team,
>> you can do it as well. Though we're not using git-dpm, and rather a git
>> tag workflow, you're still free to use whatever workflow you want there,
>> as long as the package is well maintained.
>>
>> If you need sponsoring for this package, I can review it and upload it
>> for you.
> 
> Great, thanks for the offer. I think I'll have to wait a couple of weeks
> to see where things are for packaging this. There is at least one new
> dependency for the latest release (python-fake-factory), I have packaged
> that, but the tests currently don't pass. Once there is a release for
> python-fake-factory, for which the tests pass, and that has been
> uploaded to Debian, I'll get around to looking at factory-boy again.

Its been quite a few weeks, but the above is now done. The missing
dependency (python-fake-factory) is now in Debian, and I have updated
factory-boy to the latest upstream version [1].

Are you still open to sponsoring this zigo? I have just filled in the
alioth form to become a member of the OpenStack team.

1: http://git.cbaines.net/factory-boy/

[toc] | [prev] | [next] | [standalone]

#8514

On 05/11/2016 11:31 AM, Christopher Baines wrote:
> On 23/12/15 15:30, Christopher Baines wrote:
>> On 23/12/15 11:31, Thomas Goirand wrote:
>>> I was the maintainer of this package, though I lost interest for it
>>> because there's no reverse dependency for it.
>>
>> Thanks for packaging it :)
>>
>>> If you want to continue maintaining it within the OpenStack PKG team,
>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>> tag workflow, you're still free to use whatever workflow you want there,
>>> as long as the package is well maintained.
>>>
>>> If you need sponsoring for this package, I can review it and upload it
>>> for you.
>>
>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>> to see where things are for packaging this. There is at least one new
>> dependency for the latest release (python-fake-factory), I have packaged
>> that, but the tests currently don't pass. Once there is a release for
>> python-fake-factory, for which the tests pass, and that has been
>> uploaded to Debian, I'll get around to looking at factory-boy again.
> 
> Its been quite a few weeks, but the above is now done. The missing
> dependency (python-fake-factory) is now in Debian, and I have updated
> factory-boy to the latest upstream version [1].
> 
> Are you still open to sponsoring this zigo? I have just filled in the
> alioth form to become a member of the OpenStack team.
> 
> 1: http://git.cbaines.net/factory-boy/

Hi,

I added you as a member of the team. Let me know when I should sponsor
the package.

Cheers,

Thomas Goirand (zigo)

[toc] | [prev] | [next] | [standalone]

#8515

[Multipart message — attachments visible in raw view] — view raw

On 11/05/16 13:19, Thomas Goirand wrote:
> On 05/11/2016 11:31 AM, Christopher Baines wrote:
>> On 23/12/15 15:30, Christopher Baines wrote:
>>> On 23/12/15 11:31, Thomas Goirand wrote:
>>>> I was the maintainer of this package, though I lost interest for it
>>>> because there's no reverse dependency for it.
>>>
>>> Thanks for packaging it :)
>>>
>>>> If you want to continue maintaining it within the OpenStack PKG team,
>>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>>> tag workflow, you're still free to use whatever workflow you want there,
>>>> as long as the package is well maintained.
>>>>
>>>> If you need sponsoring for this package, I can review it and upload it
>>>> for you.
>>>
>>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>>> to see where things are for packaging this. There is at least one new
>>> dependency for the latest release (python-fake-factory), I have packaged
>>> that, but the tests currently don't pass. Once there is a release for
>>> python-fake-factory, for which the tests pass, and that has been
>>> uploaded to Debian, I'll get around to looking at factory-boy again.
>>
>> Its been quite a few weeks, but the above is now done. The missing
>> dependency (python-fake-factory) is now in Debian, and I have updated
>> factory-boy to the latest upstream version [1].
>>
>> Are you still open to sponsoring this zigo? I have just filled in the
>> alioth form to become a member of the OpenStack team.
>>
>> 1: http://git.cbaines.net/factory-boy/
> 
> Hi,
> 
> I added you as a member of the team. Let me know when I should sponsor
> the package.

Great, I have pushed the changes to the repository and it is ready for
you to review.

[toc] | [prev] | [next] | [standalone]

#8520

On 05/11/2016 02:31 PM, Christopher Baines wrote:
> On 11/05/16 13:19, Thomas Goirand wrote:
>> On 05/11/2016 11:31 AM, Christopher Baines wrote:
>>> On 23/12/15 15:30, Christopher Baines wrote:
>>>> On 23/12/15 11:31, Thomas Goirand wrote:
>>>>> I was the maintainer of this package, though I lost interest for it
>>>>> because there's no reverse dependency for it.
>>>>
>>>> Thanks for packaging it :)
>>>>
>>>>> If you want to continue maintaining it within the OpenStack PKG team,
>>>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>>>> tag workflow, you're still free to use whatever workflow you want there,
>>>>> as long as the package is well maintained.
>>>>>
>>>>> If you need sponsoring for this package, I can review it and upload it
>>>>> for you.
>>>>
>>>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>>>> to see where things are for packaging this. There is at least one new
>>>> dependency for the latest release (python-fake-factory), I have packaged
>>>> that, but the tests currently don't pass. Once there is a release for
>>>> python-fake-factory, for which the tests pass, and that has been
>>>> uploaded to Debian, I'll get around to looking at factory-boy again.
>>>
>>> Its been quite a few weeks, but the above is now done. The missing
>>> dependency (python-fake-factory) is now in Debian, and I have updated
>>> factory-boy to the latest upstream version [1].
>>>
>>> Are you still open to sponsoring this zigo? I have just filled in the
>>> alioth form to become a member of the OpenStack team.
>>>
>>> 1: http://git.cbaines.net/factory-boy/
>>
>> Hi,
>>
>> I added you as a member of the team. Let me know when I should sponsor
>> the package.
> 
> Great, I have pushed the changes to the repository and it is ready for
> you to review.

Hi,

Please join #debian-openstack-commits to see the build results.
Currently, the package FTBFS in Jessie's chroot:

https://mitaka-jessie.pkgs.mirantis.com/job/factory-boy/5/console

The type of error you're seeing is most of the time due to the fact you
didn't push the upstream tags to Git.

Cheers,

Thomas Goirand (zigo)

[toc] | [prev] | [next] | [standalone]

#8521

[Multipart message — attachments visible in raw view] — view raw

On 12/05/16 07:57, Thomas Goirand wrote:
> On 05/11/2016 02:31 PM, Christopher Baines wrote:
>> On 11/05/16 13:19, Thomas Goirand wrote:
>>> On 05/11/2016 11:31 AM, Christopher Baines wrote:
>>>> On 23/12/15 15:30, Christopher Baines wrote:
>>>>> On 23/12/15 11:31, Thomas Goirand wrote:
>>>>>> I was the maintainer of this package, though I lost interest for it
>>>>>> because there's no reverse dependency for it.
>>>>>
>>>>> Thanks for packaging it :)
>>>>>
>>>>>> If you want to continue maintaining it within the OpenStack PKG team,
>>>>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>>>>> tag workflow, you're still free to use whatever workflow you want there,
>>>>>> as long as the package is well maintained.
>>>>>>
>>>>>> If you need sponsoring for this package, I can review it and upload it
>>>>>> for you.
>>>>>
>>>>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>>>>> to see where things are for packaging this. There is at least one new
>>>>> dependency for the latest release (python-fake-factory), I have packaged
>>>>> that, but the tests currently don't pass. Once there is a release for
>>>>> python-fake-factory, for which the tests pass, and that has been
>>>>> uploaded to Debian, I'll get around to looking at factory-boy again.
>>>>
>>>> Its been quite a few weeks, but the above is now done. The missing
>>>> dependency (python-fake-factory) is now in Debian, and I have updated
>>>> factory-boy to the latest upstream version [1].
>>>>
>>>> Are you still open to sponsoring this zigo? I have just filled in the
>>>> alioth form to become a member of the OpenStack team.
>>>>
>>>> 1: http://git.cbaines.net/factory-boy/
>>>
>>> Hi,
>>>
>>> I added you as a member of the team. Let me know when I should sponsor
>>> the package.
>>
>> Great, I have pushed the changes to the repository and it is ready for
>> you to review.
> 
> Hi,
> 
> Please join #debian-openstack-commits to see the build results.
> Currently, the package FTBFS in Jessie's chroot:
> 
> https://mitaka-jessie.pkgs.mirantis.com/job/factory-boy/5/console
> 
> The type of error you're seeing is most of the time due to the fact you
> didn't push the upstream tags to Git.

Ok, the script in use there was not using the correct tag (it was
missing a leading "v"), but this is now fixed by modifying GIT_TAG in
the debian/rules makefile.

However, the package still fails, as fake-factory is not available in
Jessie.

[toc] | [prev] | [next] | [standalone]

#8526

On 05/12/2016 10:13 AM, Christopher Baines wrote:
> On 12/05/16 07:57, Thomas Goirand wrote:
>> On 05/11/2016 02:31 PM, Christopher Baines wrote:
>>> On 11/05/16 13:19, Thomas Goirand wrote:
>>>> On 05/11/2016 11:31 AM, Christopher Baines wrote:
>>>>> On 23/12/15 15:30, Christopher Baines wrote:
>>>>>> On 23/12/15 11:31, Thomas Goirand wrote:
>>>>>>> I was the maintainer of this package, though I lost interest for it
>>>>>>> because there's no reverse dependency for it.
>>>>>>
>>>>>> Thanks for packaging it :)
>>>>>>
>>>>>>> If you want to continue maintaining it within the OpenStack PKG team,
>>>>>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>>>>>> tag workflow, you're still free to use whatever workflow you want there,
>>>>>>> as long as the package is well maintained.
>>>>>>>
>>>>>>> If you need sponsoring for this package, I can review it and upload it
>>>>>>> for you.
>>>>>>
>>>>>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>>>>>> to see where things are for packaging this. There is at least one new
>>>>>> dependency for the latest release (python-fake-factory), I have packaged
>>>>>> that, but the tests currently don't pass. Once there is a release for
>>>>>> python-fake-factory, for which the tests pass, and that has been
>>>>>> uploaded to Debian, I'll get around to looking at factory-boy again.
>>>>>
>>>>> Its been quite a few weeks, but the above is now done. The missing
>>>>> dependency (python-fake-factory) is now in Debian, and I have updated
>>>>> factory-boy to the latest upstream version [1].
>>>>>
>>>>> Are you still open to sponsoring this zigo? I have just filled in the
>>>>> alioth form to become a member of the OpenStack team.
>>>>>
>>>>> 1: http://git.cbaines.net/factory-boy/
>>>>
>>>> Hi,
>>>>
>>>> I added you as a member of the team. Let me know when I should sponsor
>>>> the package.
>>>
>>> Great, I have pushed the changes to the repository and it is ready for
>>> you to review.
>>
>> Hi,
>>
>> Please join #debian-openstack-commits to see the build results.
>> Currently, the package FTBFS in Jessie's chroot:
>>
>> https://mitaka-jessie.pkgs.mirantis.com/job/factory-boy/5/console
>>
>> The type of error you're seeing is most of the time due to the fact you
>> didn't push the upstream tags to Git.
> 
> Ok, the script in use there was not using the correct tag (it was
> missing a leading "v"), but this is now fixed by modifying GIT_TAG in
> the debian/rules makefile.
> 
> However, the package still fails, as fake-factory is not available in
> Jessie.

Hi,

I added fake-factory as backport in that Jenkins server, and now it
builds fine.

In your Git log, I can read:

    * Add myself to Uploaders
    * Add build dependencies on fake-factory and python-ipaddress
    * Bump Standards-Version to 3.9.8 (no changes required)
    * Change the gbp.conf upstream-tag to include the v prefix, as this
      makes git-buildpackage able to find the tags

None of this appeared in the debian/changelog. I added them, pushed them
to the git, built and upload. Next time, please document all of your
packaging changes in debian/changelog.

Thanks for your contribution to Debian,
Cheers,

Thomas Goirand (zigo)

[toc] | [prev] | [next] | [standalone]

#8527

On 12/05/16 15:14, Thomas Goirand wrote:
> On 05/12/2016 10:13 AM, Christopher Baines wrote:
>> On 12/05/16 07:57, Thomas Goirand wrote:
>>> On 05/11/2016 02:31 PM, Christopher Baines wrote:
>>>> On 11/05/16 13:19, Thomas Goirand wrote:
>>>>> On 05/11/2016 11:31 AM, Christopher Baines wrote:
>>>>>> On 23/12/15 15:30, Christopher Baines wrote:
>>>>>>> On 23/12/15 11:31, Thomas Goirand wrote:
>>>>>>>> I was the maintainer of this package, though I lost interest for it
>>>>>>>> because there's no reverse dependency for it.
>>>>>>>
>>>>>>> Thanks for packaging it :)
>>>>>>>
>>>>>>>> If you want to continue maintaining it within the OpenStack PKG team,
>>>>>>>> you can do it as well. Though we're not using git-dpm, and rather a git
>>>>>>>> tag workflow, you're still free to use whatever workflow you want there,
>>>>>>>> as long as the package is well maintained.
>>>>>>>>
>>>>>>>> If you need sponsoring for this package, I can review it and upload it
>>>>>>>> for you.
>>>>>>>
>>>>>>> Great, thanks for the offer. I think I'll have to wait a couple of weeks
>>>>>>> to see where things are for packaging this. There is at least one new
>>>>>>> dependency for the latest release (python-fake-factory), I have packaged
>>>>>>> that, but the tests currently don't pass. Once there is a release for
>>>>>>> python-fake-factory, for which the tests pass, and that has been
>>>>>>> uploaded to Debian, I'll get around to looking at factory-boy again.
>>>>>>
>>>>>> Its been quite a few weeks, but the above is now done. The missing
>>>>>> dependency (python-fake-factory) is now in Debian, and I have updated
>>>>>> factory-boy to the latest upstream version [1].
>>>>>>
>>>>>> Are you still open to sponsoring this zigo? I have just filled in the
>>>>>> alioth form to become a member of the OpenStack team.
>>>>>>
>>>>>> 1: http://git.cbaines.net/factory-boy/
>>>>>
>>>>> Hi,
>>>>>
>>>>> I added you as a member of the team. Let me know when I should sponsor
>>>>> the package.
>>>>
>>>> Great, I have pushed the changes to the repository and it is ready for
>>>> you to review.
>>>
>>> Hi,
>>>
>>> Please join #debian-openstack-commits to see the build results.
>>> Currently, the package FTBFS in Jessie's chroot:
>>>
>>> https://mitaka-jessie.pkgs.mirantis.com/job/factory-boy/5/console
>>>
>>> The type of error you're seeing is most of the time due to the fact you
>>> didn't push the upstream tags to Git.
>>
>> Ok, the script in use there was not using the correct tag (it was
>> missing a leading "v"), but this is now fixed by modifying GIT_TAG in
>> the debian/rules makefile.
>>
>> However, the package still fails, as fake-factory is not available in
>> Jessie.
>
> Hi,
>
> I added fake-factory as backport in that Jenkins server, and now it
> builds fine.
>
> In your Git log, I can read:
>
>      * Add myself to Uploaders
>      * Add build dependencies on fake-factory and python-ipaddress
>      * Bump Standards-Version to 3.9.8 (no changes required)
>      * Change the gbp.conf upstream-tag to include the v prefix, as this
>        makes git-buildpackage able to find the tags
>
> None of this appeared in the debian/changelog. I added them, pushed them
> to the git, built and upload. Next time, please document all of your
> packaging changes in debian/changelog.

Ah yeah, sorry about the changelog, and thanks for uploading it :)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web