Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.maint.python > #17249 > unrolled thread
| Started by | Jai kadam <jaivkadam@gmail.com> |
|---|---|
| First post | 2025-12-06 05:50 +0100 |
| Last post | 2025-12-07 20:00 +0100 |
| Articles | 9 — 4 participants |
Back to article view | Back to linux.debian.maint.python
Playwright version bump and testing Jai kadam <jaivkadam@gmail.com> - 2025-12-06 05:50 +0100
Re: Playwright version bump and testing Carsten Schoenert <c.schoenert@t-online.de> - 2025-12-06 06:50 +0100
Re: Playwright version bump and testing Roland Mas <lolando@debian.org> - 2025-12-06 14:20 +0100
Re: Playwright version bump and testing jvk <jaivkadam@gmail.com> - 2025-12-06 15:00 +0100
Re: Playwright version bump and testing Roland Mas <lolando@debian.org> - 2025-12-06 18:50 +0100
Re: Playwright version bump and testing Jai kadam <jaivkadam@gmail.com> - 2025-12-06 21:10 +0100
Re: Playwright version bump and testing Jai kadam <jaivkadam@gmail.com> - 2025-12-06 22:50 +0100
Re: Playwright version bump and testing Roland Mas <lolando@debian.org> - 2025-12-07 20:00 +0100
Re: Playwright version bump and testing Jai kadam <jaivkadam@gmail.com> - 2025-12-07 20:00 +0100
| From | Jai kadam <jaivkadam@gmail.com> |
|---|---|
| Date | 2025-12-06 05:50 +0100 |
| Subject | Playwright version bump and testing |
| Message-ID | <LYSp3-IiN-5@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hello, I have bumped the playwright version from 1.55.0 to 1.56.0 the build was successful. https://salsa.debian.org/jvk_here/python-playwright/ How should i test the package cause there is no debian/tests/ Please tell the next course of action. Thank you jvk
[toc] | [next] | [standalone]
| From | Carsten Schoenert <c.schoenert@t-online.de> |
|---|---|
| Date | 2025-12-06 06:50 +0100 |
| Message-ID | <LYTl7-IXR-1@gated-at.bofh.it> |
| In reply to | #17249 |
Hello Aryan, Am 06.12.25 um 06:59 schrieb Aryan Karamtoth: > playwright is already in the salsa namespace of DPT [1] and you should > push your changes there instead. No! Not yet now! I don't understand why this wish of behaving is constantly repeated. People should use their namespace while learning all the stuff, 20 commits back and forth about small changes that could have been rebased before makes it no easier for me to understand what did happen. > Follow the instructions here [2] and join the Debian Python Team's > Salsa namespace. That's doable at any time but not necessarily needed now to work on that package. First things first. > Since you're going for NMU of an existing package, just run the build > directly. I use sbuild and it performs the tests automatically since the > upstream already has tests for this package. Things do work automatically if there is a setup to do so. There is no difference between git-pbuilder and sbuild here. git-pbuilder has a very conservative default setting as we all have different ways of doing things. I've configured my setup of git-buildpackage to do most of the things automatically too. But it's up to you as user to do this. For sure we can do better the documentation of how the DPT is working and the workflows we use. > Not sure why you had difficulties with sbuild in the first place. This > manual [3] is a very straightforward process to set up sbuild in a few > minutes. sbuild makes it a lot easier to build, test and identify > lintian errors. So pbuilder does not? Where is the difference in gbp buildpackage --git-builder=sbuild vs. =pbuilder vs. =debuild? And I disagree, sbuild isn't that straightforward or at least wasn't that straightforward as you think. Using git-pbuilder is quite damn simple and I always suggest this newcomers. https://wiki.debian.org/git-pbuilder (for completeness) sbuild itself has nothing to do with Lintan or autopkgtest directly nor pbuilder has. The question Jai has is a valid question, I wished maintainers would take more the opportunity of using the fie README.Debian to explain the state of packaging, what is missing or needed or other things that might be important to know. Or at least a small comment in d/rules. -- Regards Carsten
[toc] | [prev] | [next] | [standalone]
| From | Roland Mas <lolando@debian.org> |
|---|---|
| Date | 2025-12-06 14:20 +0100 |
| Message-ID | <LZ0mB-NBU-5@gated-at.bofh.it> |
| In reply to | #17249 |
Le 06/12/2025 à 05:46, Jai kadam a écrit : > Hello, > I have bumped the playwright version from 1.55.0 to 1.56.0 the build > was successful. > https://salsa.debian.org/jvk_here/python-playwright/ > > How should i test the package cause there is no debian/tests/ Hi Jai, The first step would be to remove the "override_dh_auto_test:" line in debian/rules. I inserted it so that the package would skip its testsuite as a preliminaly packaging effort, but it needs to be fixed. So remove that line, re-run the build, see what breaks and fix that until nothing breaks at all (and then we'll go on to debian/tests, which is a separate testsuite). Roland.
[toc] | [prev] | [next] | [standalone]
| From | jvk <jaivkadam@gmail.com> |
|---|---|
| Date | 2025-12-06 15:00 +0100 |
| Message-ID | <LZ0Zk-NPq-19@gated-at.bofh.it> |
| In reply to | #17253 |
On Sat, 2025-12-06 at 14:19 +0100, Roland Mas wrote: > Le 06/12/2025 à 05:46, Jai kadam a écrit : > > Hello, > > I have bumped the playwright version from 1.55.0 to 1.56.0 the > > build > > was successful. > > https://salsa.debian.org/jvk_here/python-playwright/ > > > > How should i test the package cause there is no debian/tests/ > > Hi Jai, > > The first step would be to remove the "override_dh_auto_test:" line > in > debian/rules. I inserted it so that the package would skip its > testsuite > as a preliminaly packaging effort, but it needs to be fixed. So > remove > that line, re-run the build, see what breaks and fix that until > nothing > breaks at all (and then we'll go on to debian/tests, which is a > separate > testsuite). The test suite is running but there is a problem ============================= test session starts ============================== platform linux -- Python 3.14.0, pytest-8.4.2, pluggy-1.6.0 -- /usr/bin/python3.14 cachedir: .pytest_cache rootdir: /build/python-playwright- 1.56.0+ds/.pybuild/cpython3_3.14_playwright/build configfile: pyproject.toml plugins: flaky-3.8.1, asyncio-1.2.0, xvfb-3.0.0, xdist-3.8.0, cov- 5.0.0, repeat-0.9.4, timeout-2.4.0, typeguard-4.4.4 asyncio: mode=Mode.AUTO, debug=False, asyncio_default_fixture_loop_scope=session, asyncio_default_test_loop_scope=session collecting ... collected 6579 items tests/async/test_accessibility.py::test_accessibility_should_work[chrom ium] it is stuck here for quite a while now i checked the test code and its not a heavy test, i think there is some kind of bottel neck or some other problem. I will it to run for some more time. But i am sure it should not take this long. > > Roland.
[toc] | [prev] | [next] | [standalone]
| From | Roland Mas <lolando@debian.org> |
|---|---|
| Date | 2025-12-06 18:50 +0100 |
| Message-ID | <LZ4zU-QjJ-3@gated-at.bofh.it> |
| In reply to | #17253 |
[Multipart message — attachments visible in raw view] — view raw
Le 06/12/2025 à 14:39, Jai kadam a écrit : > > > On Sat, 6 Dec, 2025, 6:49 pm Roland Mas, <lolando@debian.org> wrote: > > Le 06/12/2025 à 05:46, Jai kadam a écrit : > > Hello, > > I have bumped the playwright version from 1.55.0 to 1.56.0 the > build > > was successful. > > https://salsa.debian.org/jvk_here/python-playwright/ > > > > How should i test the package cause there is no debian/tests/ > > Hi Jai, > > Hello! > > > > The first step would be to remove the "override_dh_auto_test:" > line in > debian/rules. I inserted it so that the package would skip its > testsuite > as a preliminaly packaging effort, but it needs to be fixed. So > remove > that line, re-run the build, see what breaks and fix that until > nothing > breaks at all (and then we'll go on to debian/tests, which is a > separate > testsuite). > > > Noted , so we have to build package everytime ? > I mean it will be very time consuming . > There is no other option? :) pbuilder caches the downloads, so builds are not that long. On my 5-year-old workstation, it took some time on the initial try because of the downloading of build-depends, but it now takes less than a minute on subsequent runs. If it's still too long: I've been working on an abstraction layer to gbp called gwh (see https://salsa.debian.org/lolando/gwh). It automates many of the tasks for users of the gbp workflow, and adds some others. In this case, what I'd do is run gwh --shell-on-failure, which would set up the build then try it; once the build has failed you'll have a shell open inside the chroot, and you can then iterate running commands without the full build. For instance, you'd run "cd /build/python-playwright-1.55.0+ds/.pybuild/cpython3_3.14_playwright/build; python3.14 -m pytest tests", see where it breaks, fix it, and iterate. Roland. PS: I intend to push gwh to Debian proper sometime, just haven't found the time for it yet. I use it daily though.
[toc] | [prev] | [next] | [standalone]
| From | Jai kadam <jaivkadam@gmail.com> |
|---|---|
| Date | 2025-12-06 21:10 +0100 |
| Message-ID | <LZ6Ln-RRC-1@gated-at.bofh.it> |
| In reply to | #17255 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, 7 Dec, 2025, 12:13 am Jai kadam, <jaivkadam@gmail.com> wrote: > > > On Sat, 6 Dec, 2025, 11:18 pm Roland Mas, <lolando@debian.org> wrote: > >> Le 06/12/2025 à 14:39, Jai kadam a écrit : >> >> >> >> On Sat, 6 Dec, 2025, 6:49 pm Roland Mas, <lolando@debian.org> wrote: >> >>> Le 06/12/2025 à 05:46, Jai kadam a écrit : >>> > Hello, >>> > I have bumped the playwright version from 1.55.0 to 1.56.0 the build >>> > was successful. >>> > https://salsa.debian.org/jvk_here/python-playwright/ >>> > >>> > How should i test the package cause there is no debian/tests/ >>> >>> Hi Jai, >>> >> Hello! >> >>> >>> >>> The first step would be to remove the "override_dh_auto_test:" line in >>> debian/rules. I inserted it so that the package would skip its testsuite >>> as a preliminaly packaging effort, but it needs to be fixed. So remove >>> that line, re-run the build, see what breaks and fix that until nothing >>> breaks at all (and then we'll go on to debian/tests, which is a separate >>> testsuite). >>> >> >> Noted , so we have to build package everytime ? >> I mean it will be very time consuming . >> There is no other option? :) >> >> pbuilder caches the downloads, so builds are not that long. On my >> 5-year-old workstation, it took some time on the initial try because of the >> downloading of build-depends, but it now takes less than a minute on >> subsequent runs. >> > The problem is not downloading it just kind of froze for like more that > 20mins after printing the last test line > >> If it's still too long: I've been working on an abstraction layer to gbp >> called gwh (see https://salsa.debian.org/lolando/gwh). >> > Wow that sounds great (altough it also sounds like the current state of > web devlopment , the abstraction on top of abstractions :) ) > >> It automates many of the tasks for users of the gbp workflow, and adds >> some others. In this case, what I'd do is run gwh --shell-on-failure, which >> would set up the build then try it; once the build has failed you'll have a >> shell open inside the chroot, and you can then iterate running commands >> without the full build. For instance, you'd run "cd >> /build/python-playwright-1.55.0+ds/.pybuild/cpython3_3.14_playwright/build; >> python3.14 -m pytest tests", see where it breaks, fix it, and iterate. >> > Actully the problem is not that it's failing, the problem is that it freezes Thats sounds like a better workflow :) i will try > >> Roland. >> >> PS: I intend to push gwh to Debian proper sometime, just haven't found >> the time for it yet. I use it daily though. >> > > >
[toc] | [prev] | [next] | [standalone]
| From | Jai kadam <jaivkadam@gmail.com> |
|---|---|
| Date | 2025-12-06 22:50 +0100 |
| Message-ID | <LZ8k9-SFy-5@gated-at.bofh.it> |
| In reply to | #17255 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, 6 Dec, 2025, 11:18 pm Roland Mas, <lolando@debian.org> wrote: > Le 06/12/2025 à 14:39, Jai kadam a écrit : > > > > On Sat, 6 Dec, 2025, 6:49 pm Roland Mas, <lolando@debian.org> wrote: > >> Le 06/12/2025 à 05:46, Jai kadam a écrit : >> > Hello, >> > I have bumped the playwright version from 1.55.0 to 1.56.0 the build >> > was successful. >> > https://salsa.debian.org/jvk_here/python-playwright/ >> > >> > How should i test the package cause there is no debian/tests/ >> >> Hi Jai, >> > Hello! > >> >> >> The first step would be to remove the "override_dh_auto_test:" line in >> debian/rules. I inserted it so that the package would skip its testsuite >> as a preliminaly packaging effort, but it needs to be fixed. So remove >> that line, re-run the build, see what breaks and fix that until nothing >> breaks at all (and then we'll go on to debian/tests, which is a separate >> testsuite). >> > > Noted , so we have to build package everytime ? > I mean it will be very time consuming . > There is no other option? :) > > pbuilder caches the downloads, so builds are not that long. On my > 5-year-old workstation, it took some time on the initial try because of the > downloading of build-depends, but it now takes less than a minute on > subsequent runs. > > If it's still too long: I've been working on an abstraction layer to gbp > called gwh (see https://salsa.debian.org/lolando/gwh). It automates many > of the tasks for users of the gbp workflow, and adds some others. In this > case, what I'd do is run gwh --shell-on-failure, which would set up the > build then try it; once the build has failed you'll have a shell open > inside the chroot, and you can then iterate running commands without the > full build. For instance, you'd run "cd > /build/python-playwright-1.55.0+ds/.pybuild/cpython3_3.14_playwright/build; > python3.14 -m pytest tests", see where it breaks, fix it, and iterate. > > Roland. > > PS: I intend to push gwh to Debian proper sometime, just haven't found the > time for it yet. I use it daily though. > So i tried many things, the latest this i tried was to override the dh auto test command and add -s -vv flags to the command and it didnt work either i thought i you give some more info but nah no luck Can you try to clone https://salsa.debian.org/jvk_here/python-playwright/ and run gbp build not gwh that would tell if there is some problem with my machine :/ Thank you >
[toc] | [prev] | [next] | [standalone]
| From | Roland Mas <lolando@debian.org> |
|---|---|
| Date | 2025-12-07 20:00 +0100 |
| Message-ID | <LZs9b-15PZ-1@gated-at.bofh.it> |
| In reply to | #17258 |
Le 06/12/2025 à 22:44, Jai kadam a écrit : > > Can you try to clone https://salsa.debian.org/jvk_here/python-playwright/ > and run gbp build not gwh that would tell if there is some problem > with my machine :/ I get the same thing, which is the reason why I disabled the testsuite in the first place :-) I seem to remember there's some nodejs involved, but I haven't investigated yet. Roland.
[toc] | [prev] | [next] | [standalone]
| From | Jai kadam <jaivkadam@gmail.com> |
|---|---|
| Date | 2025-12-07 20:00 +0100 |
| Message-ID | <LZs9b-15PZ-7@gated-at.bofh.it> |
| In reply to | #17260 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 8 Dec, 2025, 12:20 am Roland Mas, <lolando@debian.org> wrote: > Le 06/12/2025 à 22:44, Jai kadam a écrit : > > > > Can you try to clone > https://salsa.debian.org/jvk_here/python-playwright/ > > and run gbp build not gwh that would tell if there is some problem > > with my machine :/ > > I get the same thing, which is the reason why I disabled the testsuite > in the first place :-) > > I seem to remember there's some nodejs involved, but I haven't > investigated yet. > Ah i see then i will try to investigate further, it looks like this will take time cause at -vvv maximum verbosity also pytest isnt giving any information > > Roland. > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.maint.python
csiph-web