Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #16112 > unrolled thread

Package review request: cocotb -- library for writing VHDL and Verilog testbenches in Python

Back to article view | Back to linux.debian.maint.python

Contents

  Package review request: cocotb -- library for writing VHDL and  Verilog testbenches in Python أحمد المحمودي <aelmahmoudy@users.sourceforge.net> - 2024-07-28 07:30 +0200
    Re: Package review request: cocotb -- library for writing VHDL and  Verilog testbenches in Python Agathe Porte <gagath@debian.org> - 2024-08-12 21:20 +0200
      Re: Package review request: cocotb -- library for writing VHDL and  Verilog testbenches in Python أحمد المحمودي <aelmahmoudy@users.sourceforge.net> - 2024-12-08 18:40 +0100
        Re: Package review request: cocotb -- library for writing VHDL and  Verilog testbenches in Python أحمد المحمودي <aelmahmoudy@users.sourceforge.net> - 2024-12-19 03:10 +0100
          Re: Package review request: cocotb -- library for writing VHDL and  Verilog testbenches in Python Carsten Schoenert <c.schoenert@t-online.de> - 2024-12-19 15:50 +0100

#16112 — Package review request: cocotb -- library for writing VHDL and Verilog testbenches in Python

[Multipart message — attachments visible in raw view] — view raw

Hello,

I need someone from the Python packaging team to review the packaging of 
cocotb

The package can be found on Git: 
https://salsa.debian.org/electronics-team/cocotb

I am particularly puzzled by the files layout of cocotb, for example 
compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
and data files (makefiles mostly) are under:
/usr/lib/python3/dist-packages/cocotb/share/

The package has the following lintian issues:
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libembed.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpi.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/simulator.cpython-312-x86_64-linux-gnu.so]
I: python3-cocotb: hardening-no-fortify-functions [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:12]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:13]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:5]
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

Regards,

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7

[toc] | [next] | [standalone]

#16207

مرحبًا أحمد

I was not able to fix the hardening-no-bindnow errors by adding the
usual hardening=+bindnow to the DEB_BUILD_MAINT_OPTIONS in d/rules.

However I saw some other things that I think should be fixed before you
upload. I have created a PR here:

https://salsa.debian.org/electronics-team/cocotb/-/merge_requests/1

 debian/copyright                | 10 ++++------
 debian/lintian-overrides        |  2 ++
 debian/source/lintian-overrides |  3 +++
 3 files changed, 9 insertions(+), 6 deletions(-)

Otherwise I think the package is good to upload. Maybe the other
warnings can be fixed later.

Best regards,

Agathe.

2024-07-28 07:23 CEST, أحمد المحمودي:
> Hello,
> 
> I need someone from the Python packaging team to review the packaging of 
> cocotb
> 
> The package can be found on Git: 
> https://salsa.debian.org/electronics-team/cocotb
> 
> I am particularly puzzled by the files layout of cocotb, for example 
> compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
> and data files (makefiles mostly) are under:
> /usr/lib/python3/dist-packages/cocotb/share/
> 
> The package has the following lintian issues:
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libembed.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpi.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so]
> I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/simulator.cpython-312-x86_64-linux-gnu.so]
> I: python3-cocotb: hardening-no-fortify-functions [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
> I: cocotb source: uses-python-distutils [cocotb_build_libs.py:12]
> I: cocotb source: uses-python-distutils [cocotb_build_libs.py:13]
> I: cocotb source: uses-python-distutils [cocotb_build_libs.py:5]
> P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

[toc] | [prev] | [next] | [standalone]

#16561

[Multipart message — attachments visible in raw view] — view raw

On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:
> Otherwise I think the package is good to upload. Maybe the other
> warnings can be fixed later.
---end quoted text---

Thanks for your reply, yet my primary concern, rather than the lintian 
issues, was the files layout for python3-cocotb:

compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
shouldn't those rather be under: /usr/lib/<multiarch-triplet>/cocotb/ ?

also, the data files (makefiles mostly) are under:
/usr/lib/python3/dist-packages/cocotb/share/, shouldn't those rather be 
under /usr/share/cocotb ?

I'm not sure if this lintian issue is related:
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

Here's a snipet of the files layout for python3-cocotb:

./usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so
./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so
./usr/lib/python3/dist-packages/cocotb/libs/libembed.so
./usr/lib/python3/dist-packages/cocotb/libs/libgpi.so
./usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so
./usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so

./usr/lib/python3/dist-packages/cocotb/share/include/
./usr/lib/python3/dist-packages/cocotb/share/include/cocotb_utils.h
./usr/lib/python3/dist-packages/cocotb/share/include/embed.h
./usr/lib/python3/dist-packages/cocotb/share/include/exports.h
./usr/lib/python3/dist-packages/cocotb/share/include/gpi.h
./usr/lib/python3/dist-packages/cocotb/share/include/gpi_logging.h
./usr/lib/python3/dist-packages/cocotb/share/include/py_gpi_logging.h
./usr/lib/python3/dist-packages/cocotb/share/include/vhpi_user_ext.h
./usr/lib/python3/dist-packages/cocotb/share/include/vpi_user_ext.h
./usr/lib/python3/dist-packages/cocotb/share/lib/
./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/
./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/verilator.cpp
./usr/lib/python3/dist-packages/cocotb/share/makefiles/
./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.deprecations
./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.inc
./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.sim
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.activehdl
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.cvc
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ghdl
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.icarus
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ius
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.modelsim
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.nvc
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.questa
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.riviera
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.vcs
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.verilator
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.xcelium

Sorry for the late reply, I had no internet access in the previous 
months.

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7

[toc] | [prev] | [next] | [standalone]

#16590

[Multipart message — attachments visible in raw view] — view raw

On Sun, Dec 08, 2024 at 06:21:23PM +0100, أحمد المحمودي wrote:
> On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:
> > Otherwise I think the package is good to upload. Maybe the other
> > warnings can be fixed later.
> ---end quoted text---

A recent build gsve this lintian issue:
W: python3-cocotb: python-module-in-wrong-location usr/lib/python3.13/dist-packages/cocotb -> usr/lib/python3/dist-packages/cocotb

> Thanks for your reply, yet my primary concern, rather than the lintian 
> issues, was the files layout for python3-cocotb:
> compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
> shouldn't those rather be under: /usr/lib/<multiarch-triplet>/cocotb/ ?
> 
> also, the data files (makefiles mostly) are under:
> /usr/lib/python3/dist-packages/cocotb/share/, shouldn't those rather be 
> under /usr/share/cocotb ?
> 
> I'm not sure if this lintian issue is related:
> P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]
> 
> Here's a snipet of the files layout for python3-cocotb:
> 
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libembed.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libgpi.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so
> ./usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so
> 
> ./usr/lib/python3/dist-packages/cocotb/share/include/
> ./usr/lib/python3/dist-packages/cocotb/share/include/cocotb_utils.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/embed.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/exports.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/gpi.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/gpi_logging.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/py_gpi_logging.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/vhpi_user_ext.h
> ./usr/lib/python3/dist-packages/cocotb/share/include/vpi_user_ext.h
> ./usr/lib/python3/dist-packages/cocotb/share/lib/
> ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/
> ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/verilator.cpp
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.deprecations
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.inc
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.sim
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.activehdl
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.cvc
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ghdl
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.icarus
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ius
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.modelsim
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.nvc
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.questa
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.riviera
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.vcs
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.verilator
> ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.xcelium
> 
> Sorry for the late reply, I had no internet access in the previous 
> months.
> 
> -- 
> ‎أحمد المحمودي (Ahmed El-Mahmoudy)
>  Digital design engineer
> GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
> GPG Fingerprints:
>  6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
>  8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7


---end quoted text---

-- 
‎أحمد المحمودي (Ahmed El-Mahmoudy)
 Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
 6E2E E4BB 72E2 F417 D066  6ABF 7B30 B496 A7EF 5761
 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7

[toc] | [prev] | [next] | [standalone]

#16592

Am 19.12.24 um 04:06 schrieb أحمد المحمودي:
> On Sun, Dec 08, 2024 at 06:21:23PM +0100, أحمد المحمودي wrote:
>> On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:
>>> Otherwise I think the package is good to upload. Maybe the other
>>> warnings can be fixed later.
>> ---end quoted text---
> 
> A recent build gsve this lintian issue:
> W: python3-cocotb: python-module-in-wrong-location usr/lib/python3.13/dist-packages/cocotb -> usr/lib/python3/dist-packages/cocotb

You've forgot to add dh-sequence-python3 to the Build-Depends?
Iy you add this package you can then also drop "--with=python3" in the 
default make target in debian/rules.

And you should consider to sort the entries in debian/contral 
alphabetical, this helps human to read the entries more eaasy.

-- 
Regards
Carsten

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.python

csiph-web