Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.maint.python > #15408 > unrolled thread

QA python3-unittest2

Started byAlexandre Detiste <alexandre.detiste@gmail.com>
First post2024-01-10 12:30 +0100
Last post2024-01-18 21:20 +0100
Articles 3 — 1 participant

Back to article view | Back to linux.debian.maint.python


Contents

  QA python3-unittest2 Alexandre Detiste <alexandre.detiste@gmail.com> - 2024-01-10 12:30 +0100
    Re: QA python3-unittest2 Alexandre Detiste <alexandre.detiste@gmail.com> - 2024-01-17 14:30 +0100
      Re: QA python3-unittest2 Alexandre Detiste <alexandre.detiste@gmail.com> - 2024-01-18 21:20 +0100

#15408 — QA python3-unittest2

FromAlexandre Detiste <alexandre.detiste@gmail.com>
Date2024-01-10 12:30 +0100
SubjectQA python3-unittest2
Message-ID<HUEWt-278E-9@gated-at.bofh.it>
Hi,

I'm busy with the (tentative-) removal of python3-unittest2.

unitest2 is an old version of what has become "unittest.mock" in the
standard library

90% of dependencies are stale and only need a quick edit of debian/control
for the other I submit patches upstream

Can I get (minimal) Salsa team membership for this one task ?

maybe also checking for python3-mock & python3-six at the same time.

I do not plan to do any upload of these packages and more generally
I do not even fully grasp what OpenStack is about.

I can maybe handle just this urgent one
#1059108 [i|P|♔] [src:gnocchi] gnocchi: please remove extraneous
dependency on python3-future

python3-unittest2:
"""""""""""""""""""""""
designate-dashboard
keystone
mistral
murano-agent
neutron
python-django-compressor
python-funcsigs
python-jenkins
python-kafka
python-linecache2
python-novaclient
python-oauth2client
python-pecan
python-pymysql
sahara-dashboard
senlin-dashboard
testresources
trove-dashboard

python3-six:

#1053966 [n|  |  ] [python3-ironic-ui] python3-ironic-ui: please
remove extraneous, obsolete, dependency on python3-six
#1054151 [n|  |  ] [python3-neutron-vpnaas] python3-neutron-vpnaas:
please remove obsolete python3-six dependency
#1060114 [n|  |↝] [src:python-txaio] python-txaio: please remove
extraneous dependency on python3-six

(so not these ones, unless requested)
#1052512 [n|  |  ] [src:python-pysaml2] python-pysaml2: please package
v7.4.2 and remove python3-six dependency
#1053378 [n|  |  ] [src:python-gabbi] python-gabbi: please package
v2.10.0 and remove dependency on python3-six

Greetings

[toc] | [next] | [standalone]


#15416

FromAlexandre Detiste <alexandre.detiste@gmail.com>
Date2024-01-17 14:30 +0100
Message-ID<HXe9r-3HUa-5@gated-at.bofh.it>
In reply to#15408
Le jeu. 11 janv. 2024 à 10:47, Thomas Goirand <zigo@debian.org> a écrit :
> > I'm busy with the (tentative-) removal of python3-unittest2.
> >
> > unitest2 is an old version of what has become "unittest" in the
> > standard library
> >
> > 90% of dependencies are stale and only need a quick edit of debian/control
> > for the other I submit patches upstream
>
> Will you also send patches to upstream OpenStack? If so, please note
> that OpenStack uses Gerrit, and you need to follow the instructions
> detailed here for a new account:
> https://docs.openstack.org/contributors/en_GB/common/accounts.html

I will learn Gerrit because I'm curious...

...but 90% of these remaining dep on unittest2 are really only about
removing 1 line from debian/control ...
only committing this change + setting the bug as pending would
already help with triaging

I can send Salsa MR if that's easier for everyone too.

> I'd strongly recommend sending patches upstream rather than in
> downstream Debian packages only. The next OpenStack release (codename:
> Caracal) is due for April, so if you send patches upstream now, it's
> going to be in Debian soonish.

Great

> Note that upstream OpenStack has been actively removing the Six
> dependency, and they'll be very happy to have some kind of help
> finishing the work.

I'll do.

have a nice day

[toc] | [prev] | [next] | [standalone]


#15417

FromAlexandre Detiste <alexandre.detiste@gmail.com>
Date2024-01-18 21:20 +0100
Message-ID<HXH1L-3Zkd-1@gated-at.bofh.it>
In reply to#15416
Le mer. 17 janv. 2024 à 17:14, Thomas Goirand <zigo@debian.org> a écrit :
> On 1/17/24 14:25, Alexandre Detiste wrote:
> > Le jeu. 11 janv. 2024 à 10:47, Thomas Goirand <zigo@debian.org> a écrit :
> >>> I'm busy with the (tentative-) removal of python3-unittest2.
> >>>
> >> https://docs.openstack.org/contributors/en_GB/common/accounts.html
> > I can send Salsa MR if that's easier for everyone too.
>
> If you just send me the list of packages affected, with no change to be
> sent upstream, I can take care of it in a few minutes myself.
Yes please

>Or have you already filled the bugs?

I've filled a handful of bugs then it felt wrong so I dropped the ball

10 cases with the 1 extraneous line in d/control

keystone/debian/control: python3-unittest2,
neutron/debian/control: python3-unittest2,
python-django-compressor/debian/control: python3-unittest2,
python-kafka/debian/control: python3-unittest2,
python-novaclient/debian/control: python3-unittest2,
python-oauth2client/debian/control: python3-unittest2,
python-pecan/debian/control: python3-unittest2,
sahara-dashboard/debian/control: python3-unittest2,
senlin-dashboard/debian/control: python3-unittest2,
trove-dashboard/debian/control: python3-unittest2,

----

3 cases with 1 extraneous line in test-requirements.txt &
1 extraneous line in d/control
... removing the Debian line may trigger a regression
when someone package the next update.
These would be my first 3 Gerrit-requests

murano-agent/test-requirements.txt:unittest2>=1.1.0 # BSD
murano-agent/debian/control: python3-unittest2,

designate-dashboard/test-requirements.txt:unittest2>=1.1.0 # BSD
designate-dashboard/debian/control: python3-unittest2,

mistral/test-requirements.txt:unittest2>=1.1.0 # BSD
mistral/debian/control: python3-unittest2,

----

and then more, but that is scripted.. and will be for a next iteration

#!/bin/bash
lists=/var/lib/apt/lists/ftp.be.debian.org_debian_dists
mkdir -p /tmp/unittest2
grep-dctrl python3-unittest2 -n -s Vcs-Git
${lists}_*{Sources,Packages} | grep openstack | sort -u | while read
url
do
    dir=$(basename $url)
    git clone --depth=1 $url /tmp/unittest2/$dir
done
(cd /tmp/unittest2; grep -r unittest2 .)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.maint.python


csiph-web