Groups > linux.debian.maint.python > #9120

Re: RFS: python-jsonref 0.1

Path	csiph.com!goblin1!goblin.stu.neva.ru!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Mattia Rizzolo <mattia@debian.org>
Newsgroups	linux.debian.maint.python
Subject	Re: RFS: python-jsonref 0.1
Date	Sat, 31 Dec 2016 16:30:02 +0100
Message-ID	<sUtLA-4Gy-25@gated-at.bofh.it> (permalink)
References	<sILbc-5im-13@gated-at.bofh.it>
X-Mailbox-Line	From debian-python-request@lists.debian.org Sat Dec 31 15:22:24 2016
Old-Return-Path	<mattia@debian.org>
X-Amavis-Spam-Status	No, score=-11.9 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FOURLA=0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate:hard: -5
Mail-Followup-To	debian-python@lists.debian.org
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="abvphyqro6cv6psc"
Content-Disposition	inline
X-Info	Keep It Simple, Stupid.
X-Operating-System	Linux, kernel 4.8.0-2-amd64, inside Debian GNU/Linux unstable (sid) sid.
X-Message-Flag	WARNING!! Outlook sucks. A lot.
User-Agent	Every email client sucks, this one just sucks less.
X-Debbugs-No-Ack	no thanks I trust my emails to reach their destination… ☺
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/14475
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/20161231152205.bz2rzy426bk5jl2a@mapreri.org
Approved	robomod@news.nic.it
Lines	71
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Sat, 31 Dec 2016 16:22:07 +0100
X-Original-Message-ID	<20161231152205.bz2rzy426bk5jl2a@mapreri.org>
X-Original-References	<4797ce6d-18e8-cbbd-c3d5-94e70f32390e@libpf.com>
Xref	csiph.com linux.debian.maint.python:9120

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Paolo,
<fill here my recommendations about RFS bugs..>

On Tue, Nov 29, 2016 at 08:33:20AM +0100, Paolo Greppi wrote:
> I packaged python-jsonref as per this ITP:
> https://bugs.debian.org/844986, this is the repo:
> https://anonscm.debian.org/cgit/python-modules/packages/python-jsonref.git
> 
> Please someone more experienced than me review it and if it's OK sponsor
> its upload.

* git is lacking a pristine-tar branch, please push it (I don't even try
  to build without)
* d/control:
  + please wrap-and-sort that list of build-deps
  + maintainer is you, and DPMT is nowhere to be seen
  + why is Testsuite commented out?
* please bump compat to 10
* d/rules:
  + I think you need to also do --with sphinx to have dh_sphnixdocs do
    it's job?
* d/copyright:
  + why are you listing all the files instead of using wildcards?!
  + is there a particular reason the license of debian/ is different and
    more stricter than upstream's?
  + no need to repeat "Copyright (C)" on the Copyright: lines
  + also I very much like emails in d/copright
  + the license field of upstream also include the copyright notice, it
    shouldn't
* that proxytypes.py has a "based on the implementation..", are you sure
  that's not under a different copyright/license? (if so upstream might
  be at fault here, and this package might not be redistributable)


-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Thread

RFS: python-jsonref 0.1 Paolo Greppi <paolo.greppi@libpf.com> - 2016-11-29 08:40 +0100
  Re: RFS: python-jsonref 0.1 Mattia Rizzolo <mattia@debian.org> - 2016-12-31 16:30 +0100
    Re: RFS: python-jsonref 0.1 Paolo Greppi <paolo.greppi@libpf.com> - 2017-05-24 14:00 +0200

csiph-web