Groups > linux.debian.maint.python > #9080

Request for review and sponsorship for pydbus

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Alberto Caso <alberto.caso@juntaex.es>
Newsgroups	linux.debian.maint.python
Subject	Request for review and sponsorship for pydbus
Date	Mon, 12 Dec 2016 00:40:01 +0100
Message-ID	<sNlSN-5jM-3@gated-at.bofh.it> (permalink)
X-Mailbox-Line	From debian-python-request@lists.debian.org Sun Dec 11 23:36:12 2016
Old-Return-Path	<alberto.caso@juntaex.es>
X-Amavis-Spam-Status	No, score=-6.919 tagged_above=-10000 required=5.3 tests=[BAD_ENC_HEADER=0.001, BAYES_00=-2, FOURLA=0.1, LDO_WHITELIST=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
X-Policyd-Weight	DYN_NJABL=ERR(0) NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .juntaex. - helo: .routemea2.hes.trendmicro. - helo-domain: .trendmicro.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -7
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.22.2-1
MIME-Version	1.0
X-Originating-IP	[172.31.252.195]
Content-Transfer-Encoding	quoted-printable
X-Tmase-Version	StarCloud-1.3-8.1.1060-22756.003
X-Tmase-Result	10--20.380900-7.000000
X-Tmase-Matchedrid	zQKP0r74H9q/Y1/vmrr7/o9hRjNfZeOXyTicrAwW35bynfEnuLxjDR/X WBLkU7fu374LMa56PLJABfNARaV2wffNW7+59c86PbAGLx7oOwpYN1akkye0qLkY3WUw/B8XVyR 2139nMg7KEio955kBs2ykyESCIpDfOpITOJG3CaUtR8fVMTBo3ecUOFeb+PcjDYbe/PyX8gTvya eDVeqV3zz76SRwgb+RIzI90InV623Hof55kx23fdlHf9Z3qZKTFJFr2qlKix83Z3efQH+wjwavH iGd/roPC7lQTD5itvs2/FCjxw+QrO6oG5WaBwJaHcQQBuf4ZFsrHkgIan9a0QDqzaYhcjeQt5QF Sft3MP7CMHD4g9JSKezoPScbG9SHkfThEk7TEzZC0Qyu9JnDKRSpYqhygmjpDrM6uyrOP3P7Fay iYIE+mB08yFl2lorZ5mVXuYmP8P83KXWd30Ii3YMbH85DUZXygMf23PO6/W/6C0ePs7A07SAhra 4zm6TylExlQIQeRG0=
X-Tm-As-Urlratinginfo	81-38-=?us-ascii?B?aHR0cHM6Ly9hbm9uc2NtLmRlYmlhbi5vcm cvY2dpdC9weXRob24tbW9kdWxlcy9wYWNrYWdlcy9weWRidXMuZ2l0Lw==?=
X-Tm-As-Urlratingact	60-
X-Tm-Deliver-Signature	CD7063695150DA07F418F6A58603C8EA
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/14430
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/1481499345.12181.5.camel@juntaex.es
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Mon, 12 Dec 2016 00:35:45 +0100
X-Original-Message-ID	<1481499345.12181.5.camel@juntaex.es>
Xref	csiph.com linux.debian.maint.python:9080

Show key headers only | View raw

Hello all,

I would be very grateful if someone could review my pydbus package:

https://anonscm.debian.org/cgit/python-modules/packages/pydbus.git/

Once it gets to a shape good enough to be uploaded, I will also need a
sponsor for it.

Some comments for the reviewer(s):

Orig is from GitHub [1] where upstream tags its releases. Upstream also
publishes it on PyPI, but the package there is less complete (the one
released on GitHub has more docs). This has the effect of not having 
egg-info in the source package. As it gets generated on the package
build, I added a dh_clean override to delete it, but I am not sure this
is the way to go.

[1] https://github.com/LEW21/pydbus/releases

Upstream sources lack a copyright notice. The license (LGPL-2.1+) is
clearly stated in the README file [2] but it has no copyright notice
telling who is the copyright holder. I have used the one that appears
as author in the setup.py (an hence in PyPI), also author of the
commits on GitHub. At least of commits before september 2016, because,
strange enough, author seems to have changed his first name and email
and commits since september 2016 appear under his new name (which
matches the name that currently appears on his GitHub account [3]).

I have emailed the author to ask for clarification, and event sent a
pull request [4] upstream fixing the README file, but have not received
any answer yet. For now I am sticking to the author info as it appears
in setup.py.

[2] https://anonscm.debian.org/cgit/python-modules/packages/pydbus.git/
tree/README.rst
[3] https://github.com/LEW21
[4] https://github.com/LEW21/pydbus/pull/37

I have included .pyremove files to get rid of tests and examples in the
module packages. In the examples case, because I include them in the
-doc package. In the tests case, because they should be used when
building the packages (and they are), but I guess it is better not to
ship them along with the library (correct me if I am wrong).

There is a directory named "signal-spammer" with some C++ code. I have
not included it in the binary packages because it is just for testing
purposes during development. Upstream neither includes it in the PyPI
package, nor calls it in his tests runner script.


Thank you very much in advance.

Best regards,

-- 
Alberto Caso Palomino 
Servicio de Implantación de Sistemas
Dirección Gral. de Admón. Electrónica y TI
Consejería de Hacienda y Administración Pública
Junta de Extremadura

Back to linux.debian.maint.python | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Request for review and sponsorship for pydbus Alberto Caso <alberto.caso@juntaex.es> - 2016-12-12 00:40 +0100
  Re: Request for review and sponsorship for pydbus Dmitry Shachnev <mitya57@debian.org> - 2016-12-19 21:20 +0100

csiph-web