Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #17423

Re: review for audio-visualizer-python/2.2.4-1

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Thanks for the review Jeroen.

On Fri, 2026-03-06 at 12:10 +0000, Jeroen Ploemen wrote:
> 
> * patches: 0003 seems to serve no other purpose than deleting a file.
>   You don't want to use patches for that. To prevent that license
>   file from getting installed, please use some other method with a
>   much smaller footprint, such as overriding dh_install to exclude
>   the file from install, or removing it after the install step in an
>   override_after_ stanza.

I have reverted the change that introduced the patch you have mentioned
and introduced another patch that sets 'license-files' in
pyproject.toml, which makes the lint errors go away. The patch has been
upstreamed (review pending).

> 
> * rules: why is test_comp_spectrum_previewRender getting deselected?
>   I can see it failed on i386 on the CI, but there could be a number
>   of reasons for that. Was the cause for the failure investigated? Is
>   the test itself buggy or does it correctly identify a bug in
>   upstream code? Was the issue reported upstream?
> 
>   Adding an explanatory comment alongside the relevant setting in
>   d/rules can be very helpful to provide a bit of context.

I started investigating this and I couldn't spot anything obvious on
the test itself.

I have reported this to the upstream and we will investigate this there
with them.

For the moment, I've marked the test to be skipped on i{3,6}86, as it
passes on other platforms.

Cheers,
Aeliton

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

review for audio-visualizer-python/2.2.4-1 Jeroen Ploemen <jcfp@debian.org> - 2026-03-06 13:20 +0100
  Re: review for audio-visualizer-python/2.2.4-1 "Aeliton G. Silva" <aeliton@aeliton.com> - 2026-03-06 18:20 +0100
    Re: review for audio-visualizer-python/2.2.4-1 Jeroen Ploemen <jcfp@debian.org> - 2026-03-07 09:20 +0100

csiph-web