Groups > linux.debian.maint.python > #17418

Re: review for python-pgvector/0.4.2-1

Path	csiph.com!weretis.net!feeder8.news.weretis.net!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Arian Ott <arian.ott@ieee.org>
Newsgroups	linux.debian.maint.python
Subject	Re: review for python-pgvector/0.4.2-1
Date	Wed, 04 Mar 2026 09:00:01 +0100
Message-ID	<MuPjb-4UCZ-1@gated-at.bofh.it> (permalink)
References	<MrHi9-2M4o-3@gated-at.bofh.it>
X-Original-To	jcfp@debian.org
X-Mailbox-Line	From debian-python-request@lists.debian.org Wed Mar 4 07:54:55 2026
Old-Return-Path	<arian.ott@ieee.org>
X-Amavis-Spam-Status	No, score=-12.201 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, LDO_WHITELIST=-5, PGPSIGNATURE=-5, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
X-Policyd-Weight	NOT_IN_SBL_XBL_SPAMHAUS=-1.5 IX_MANITU=ERR(0) CL_IP_EQ_HELO_IP=-2 (check from: .ieee. - helo: .mail-wm1-x32a.google. - helo-domain: .google.) FROM/MX_MATCHES_HELO(DOMAIN)=-2; rate: -5.5
X-Gm-Message-State	AOJu0YzYMrmiJAdplQxW2LD1+lpps7dsbr0jOzQlbXjY7N/pGsbHHGQa V4hftqHgQNrQcQ1Ay2gPCssXBd04lgfNqXVFn2ZIErcS9AdW2lgqKopDn6glqngPxy9IRHjMA/c m9A8=
X-Gm-Gg	ATEYQzwVpC9FnXUIWwwt3iaOVvwsCNJwnXZVCEz5zusFgWQXe+z80hgNX56LRAhlMuL k338MD6CR2g79PuXgJ724gNG3+SewXKeYL4BFcx9WMCu18tMlGnr8a42EcXZMorFfakWlsvRwKi DAdd+Wa1Vwv3Pkp498oC2L1QUKZvbDy8i9wIHP81b3EquuEzoTrW+ogqLjc4JnKyDjxI8JSg+9l nhWfrUTmx7NIw9x+xWTmJQBJB0sTluc58B4Ojbj2I41n5ZnVs8Hmoz1wtKooeoRDswmX2eYBTIk mGF7a6N5G3L9+mPjtuhPsM4h+kGhBvwPjDIkJO6JUKtVhtY30QD7axh+S8+RC8g/oPs+yFDuHWE skC+lyc8blND99IMJjHzyiDfPTnyAfxuKzZiLhpRj60gQxXXAVAdSQR2ciArSPrxzpOFhDj/LqI b7Q+y8oBiF77xwDMviPi/c369JyhHKk2DhC/6y4vAuJgNiDFVdXTsAbLGdLRY9nNiA4/Zno83kG S5mrypIEEc4jItBw23lNTMyfpqbP4r7sfMDptFxe96YgRMflxU=
X-Received	by 2002:a05:600c:6d95:b0:477:991c:a17c with SMTP id 5b1f17b1804b1-48513c7710bmr66437015e9.6.1772610866274; Tue, 03 Mar 2026 23:54:26 -0800 (PST)
Organization	IEEE
MIME-Version	1.0
Content-Type	multipart/signed; boundary="nextPart5050174.GXAFRqVoOG"; micalg="pgp-sha512"; protocol="application/pgp-signature"
X-Mailing-List	<debian-python@lists.debian.org> archive/latest/23680
List-ID	<debian-python.lists.debian.org>
List-URL	<https://lists.debian.org/debian-python/>
List-Archive	https://lists.debian.org/msgid-search/2398665.ElGaqSPkdT@office.arianott.com
Approved	robomod@news.nic.it
Lines	71
Sender	robomod@news.nic.it
X-Original-Cc	debian-python@lists.debian.org
X-Original-Date	Wed, 04 Mar 2026 07:24:58 +0000
X-Original-Message-ID	<2398665.ElGaqSPkdT@office.arianott.com>
X-Original-References	<20260223164040.492b6a46@debian.org>
Xref	csiph.com linux.debian.maint.python:17418

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Jeroen,

sorry again for my late reply and thanks for your review.

In the current version most of the feedback should be implemented. 

On Monday, 23 February 2026 16:40:40 Greenwich Mean Time you wrote:
> hi Arian,
> 
> I took a look at the python-pgvector package, up for sponsorship in
> the Python team:
> 
> * there's diff between the orig tarball pulled in by uscan and the
>   one generated from the pristine-tar branch:
>   (output from tardiff -m -s)
> <snip>

I recreated the pristine-tar again and pushed it in the repo.



> * autopkgtest: please test with all supported Python versions. The
>   salsa CI logs show both 3.13 and 3.14 tested on build, but only
>   3.13 in the autopkgtest.

I added a for loop iterating over all python versions.
> 
> * patches: 0001 says 'forwarded: not needed' but looks like it
>   wouldn't do any harm upstream either?
> 

Upstream rejected all patches ¯\_(ツ)_/¯

See: 

https://github.com/pgvector/pgvector-python/pull/148
https://github.com/pgvector/pgvector-python/pull/149

Thanks again for your feedback.

Best,
-- 
Arian Ott
arian.ott@ieee.org

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

review for python-pgvector/0.4.2-1 Jeroen Ploemen <jcfp@debian.org> - 2026-02-23 17:50 +0100
  Re: review for python-pgvector/0.4.2-1 Arian Ott <arian.ott@ieee.org> - 2026-03-04 09:00 +0100
    Re: review for python-pgvector/0.4.2-1 Jeroen Ploemen <jcfp@debian.org> - 2026-03-04 12:00 +0100

csiph-web