Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #16761

Re: Package review python-ecs-logging

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello!

Thank you for your work! I took a look to your package. I leave you some comments

- d/control: wrap-and-sort can be excecuted.
- d/control: I guess Build-Depends-Indep is not necessary
- d/control: You can use autopkgtest-pkg-pybuild as Testsuite, instead of autopkgtest-pkg-python. And unittests will run in autopkgtests.
- d/control: I gues you don't have permissions to create projects under python-team? That's why Vcs-* does not exists.
- d/rules: You can remove the template comments
- d/patches/001_disable_elasticapm_tests.patch: The patch descriptions has part of d/changelog, I think is a typo?.

Let me know, if you made some changes to review it again :-) 

Cheers!

On Wed, Mar 05, 2025 at 11:59:10AM +0000, Schöke, Karsten wrote:
> Hello,
> 
> we continue to work on the dependencies in the elasticsearch environment.
> I have finished packaging ecs-logging, could someone review my work and if OK, sponsor it?
> https://salsa.debian.org/schoekek-guest/python-ecs-logging
> This is a new dependency on es_client, this in turn on elasticsearch-curator...
> 
> If it's OK, I would push it to the DPT repo.
> 
> Many thanks and best regards
> Karsten

-- 
cheers,
        Emmanuel Arias

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  eamanu@debian.org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1                     
 ⠈⠳⣄

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Package review python-ecs-logging Schöke, Karsten <Karsten.Schoeke@geobasis-bb.de> - 2025-03-05 13:00 +0100
  Re: Package review python-ecs-logging Emmanuel Arias <eamanu@debian.org> - 2025-03-05 20:50 +0100
    Re: Package review python-ecs-logging Alexandre Detiste <alexandre.detiste@gmail.com> - 2025-03-26 12:40 +0100

csiph-web