Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #16001

Review of package dep-logic

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello!

Here's my review of the work you did for dep-logic. I'll try to be 
thorough. If something isn't clear, feel free to hit me up on IRC.

===================================================================
1. d/changelog:

The version number for your package isn't right. You currently only have 
the upstream version (0.2.0) and you forgot to add the Debian revision 
part. It should thus be "0.2.0-1", as it's the first Debian revision of 
this upstream version. You can find more info on this field here [1].

You also named the package "dep-log" instead of "dep-logic"

2. d/control:

* You have a "Maintainer" field (which is OK), but you also need an 
"Uploaders" field, listing humans.

* Your "Build-Depends" field is very incomplete. I would suggest you 
look at other packages in the Team to get some inspiration, but in 
addition to python3-packaging, I would expect it to depend on:

- debhelper-compat (the main "Debian building framework" in use)
- dh-python (the debhelper tool we use to build Python packages)
- python3-all (all the python version available in the archive)
- python3-pdm-backend (the build tool used for this package)

* Your "Description" field only has a short description. It also needs a 
long one.

3. d/copyright:

Your copyright file is not complete. This file is very important, as if 
it's not 100% right, your package will be rejected by the FTP masters 
when submitting it to the archive for the first time (the NEW queue).

I would recommend using some automated tools (I like 'decopy') to start 
the work, but it's always a good idea to manually double-check and fix 
errors.

4. d/format:

There is currently no such thing as a "3.0 (git)" format. The choices 
you have are listed here [2], but the right one is most probably "3.0 
(quilt)".

Not only this, but this file should be in a directory named "debian/source".

5. d/rules:

The only thing you're currently specifying in this file, is that you're 
using the debhelper framework. At a minimum, you'll need to tell it to 
use pybuild, the main Python build tool in Debian.
===================================================================

More generally, I doubt you tried to build this package, as fails to 
pretty quickly :)

I encourage you to take a few minutes to set up a clean build 
environment. In my opinion, sbuild is a good tool for this and the 
documentation on the Debian wiki is pretty good [3]. I suggest you 
follow the "Option 2: Automatic setup using 
sbuild-debian-developer-setup" setup process, as this tools pretty much 
does everything for you.

Once setup, the "magical" sbuild command I like to use is: "sbuild -A -s 
-d unstable --source-only-changes PACKAGE".

If you need inspiration from another package, I think this one is fairly 
straightforward and simple:

https://salsa.debian.org/python-team/packages/python-mpv

Cheers, and thanks for your contribution to Debian :)

-----------------------------------------------------------------------
[1]: 
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-version

[2]: https://www.debian.org/doc/manuals/maint-guide/dother.en.html#sourcef

[3]: https://wiki.debian.org/sbuild

-- 
   ⢀⣴⠾⠻⢶⣦⠀
   ⣾⠁⢠⠒⠀⣿⡁  Louis-Philippe Véronneau
   ⢿⡄⠘⠷⠚⠋   pollo@debian.org / veronneau.org
   ⠈⠳⣄

Back to linux.debian.maint.python | Previous | Next | Find similar | Unroll thread

Thread

Review of package dep-logic Louis-Philippe Véronneau <pollo@debian.org> - 2024-07-04 04:00 +0200

csiph-web