Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.python > #15159

Re: Uncleaned egg-info directory giving lots of bugs about failing to build after successful build

Show all headers | View raw

Hi Soren

On 07/09/2023 01:05, Soren Stoutner wrote:
> Also, the commit linked to below states:
> 
> "if the egg-info directory is included in the upstream source, then
>    deleting it causes no harm as dpkg-source warns on missing files in
>    the source package but does not exit with error.”
> 
> It might not cause any problems for dpkg-source, but won’t it cause 
> issues for double builds?  For reference:
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1044268 
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1044268>
> 
> If so, any package that ships the egg-info directory in the tarball will 
> get flagged with a FTBFS bug, which might be the desired behavior if 
> these shouldn’t be in the tarball anyway.

No, the opposite is true.

They _currently_ FTBFS when built twice in a row because:

* the build modifies the egg-info files
* the change to the egg-info is not undone by the clean step that is
   run between the two builds
* dpkg-source doesn't want modified upstream files and so exits
   with error

With the change you referred to, these packages do not FTBFS when built 
twice in a row because:

* the build modifies the egg-info files
* the egg-info is removed in the clean step between that runs between
   the two build attempts
* dpkg-source doesn't care about removed upstream files and so
   completes its task without error (it warns about them, that's all)
* the build proceeds and regenerates the egg-info

It was pointed out on IRC today that some packages (like poetry) ship 
egg-info files that are part of the test suite and so are not 
regenerated... and they should not be deleted. That's the next task.

regards
Stuart



-- 
Stuart Prescott   http://www.nanonanonano.net/ stuart@nanonanonano.net
Debian Developer  http://www.debian.org/       stuart@debian.org
GPG fingerprint   90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7

Back to linux.debian.maint.python | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Uncleaned egg-info directory giving lots of bugs about failing to  build after successful build Julian Gilbey <julian@d-and-j.net> - 2023-08-18 15:10 +0200
  Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Andreas Tille <andreas@an3as.eu> - 2023-08-18 15:20 +0200
    Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Scott Talbert <swt@techie.net> - 2023-08-18 15:30 +0200
      Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Julian Gilbey <julian@d-and-j.net> - 2023-08-18 15:50 +0200
  Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Timo Röhling <roehling@debian.org> - 2023-08-18 15:30 +0200
  Re: Uncleaned egg-info directory giving lots of bugs about failing to  build after successful build Thomas Goirand <zigo@debian.org> - 2023-09-05 14:20 +0200
    Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Jeremy Stanley <fungi@yuggoth.org> - 2023-09-06 15:20 +0200
        Re: Uncleaned egg-info directory giving lots of bugs about failing to build  after successful build Soren Stoutner <soren@stoutner.com> - 2023-09-06 17:50 +0200
        Re: Uncleaned egg-info directory giving lots of bugs about failing to build after successful build Scott Kitterman <debian@kitterman.com> - 2023-09-06 18:00 +0200
        Re: Uncleaned egg-info directory giving lots of bugs about failing  to build after successful build Julian Gilbey <julian@d-and-j.net> - 2023-09-07 11:20 +0200
        Re: Uncleaned egg-info directory giving lots of bugs about failing to  build after successful build Stuart Prescott <stuart@debian.org> - 2023-09-07 11:20 +0200

csiph-web