Groups > linux.debian.maint.python > #15108

Re: Review of package dunamai

From	Jakub Ružička <jakub.ruzicka@nic.cz>
Newsgroups	linux.debian.maint.python
Subject	Re: Review of package dunamai
Date	2023-08-09 17:30 +0200
Message-ID	<H0Tih-CIj-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <GctkB-ewZP-3@gated-at.bofh.it> <GctkB-ewZP-3@gated-at.bofh.it> <GXNVM-4c3x-3@gated-at.bofh.it> <H0lqh-hd3-3@gated-at.bofh.it> <H0lqh-hd3-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Thank you for for the comprehensive yet friendly review!

I've fixed all the things you pointed out in a new python-dunamai 
packaging repo:

https://salsa.debian.org/python-team/packages/python-dunamai

Salsa CI is green, lintian stays silent, unit tests pass, autopkgtests 
pass \o/

I've uploaded the initial package, let's see if it passes NEW.

On 8/8/23 05:16, Louis-Philippe Véronneau wrote:

> 10. Your package doesn't actually run tests during build: "Ran 0 tests 
> in 0.000s". You're missing "python3-pytest" as a build-dependency.
>
> With this dependency, all tests (and not only the unit tests) will be 
> ran and they'll fail. I don't think you want to run the integration 
> tests, or at least, this should probably be done in an autopkgtest 
> instead.
>
> You can fix this by adding a "d/pybuild.testsuites" file containing 
> "tests/unit" to specify what testfiles to add/keep.

This file had no effect for me, all tests were run regardless. I found 
no mention of it in man or in other packages.

> (man pybuild for more info)
I've used

     export PYBUILD_TEST_ARGS=tests/unit

in d/rules to achieve the desired effect of only running unit tests.

> Cheers, and thanks for contributing to Debian!
My pleasure and thank you for helping me contribute to Debian in higher 
quality! :)

> When you're ready for a review of poetry-dynamic-versioning, don't 
> hesitate to ping me.
Will do.

I've opened ITP bug in the meantime (before dunamai hits sid):

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1043360

There is already a question you might be able to answer.

Cheers,
Jakub Ružička

Back to linux.debian.maint.python | Previous | Next | Find similar | Unroll thread

Thread

Re: Review of package dunamai Jakub Ružička <jakub.ruzicka@nic.cz> - 2023-08-09 17:30 +0200

csiph-web