Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.java > #10350 > unrolled thread

Updating BND to 3.x

Started by殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>
First post2018-03-04 15:50 +0100
Last post2018-03-20 12:20 +0100
Articles 11 — 5 participants

Back to article view | Back to linux.debian.maint.java

Contents

  Updating BND to 3.x 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com> - 2018-03-04 15:50 +0100
    Re: Updating BND to 3.x Markus Koschany <apo@debian.org> - 2018-03-04 16:00 +0100
    Re: Updating BND to 3.x Emmanuel Bourg <ebourg@apache.org> - 2018-03-05 13:50 +0100
      Re: Updating BND to 3.x 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com> - 2018-03-10 07:50 +0100
        Re: Updating BND to 3.x Emmanuel Bourg <ebourg@apache.org> - 2018-03-10 10:20 +0100
          Re: Updating BND to 3.x 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com> - 2018-03-14 07:20 +0100
            Re: Updating BND to 3.x Emmanuel Bourg <ebourg@apache.org> - 2018-03-14 14:50 +0100
              Re: Updating BND to 3.x 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com> - 2018-03-15 14:00 +0100
          Re: Updating BND to 3.x Tiago Daitx <tiago.daitx@canonical.com> - 2018-03-19 23:10 +0100
            Re: Updating BND to 3.x 殷啟聰 <seamlikok@gmail.com> - 2018-03-20 02:20 +0100
              Re: Updating BND to 3.x Tiago Daitx <tiago.daitx@canonical.com> - 2018-03-20 12:20 +0100

#10350 — Updating BND to 3.x

From殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>
Date2018-03-04 15:50 +0100
SubjectUpdating BND to 3.x
Message-ID<vpD7z-5S2-7@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

I have been working on updating "bnd"[1] to 3.5.0. I had to say this time it is much smoother than what Markus did 2 years ago. Here is a summary of the progress so far:

* All changes to "bnd" are now temporarily stored on Salsa [2]
* Introduced new dependency "felix-resolver" [3]
* Updated dependency "osgi-compendium" to version 6 [4]
* Tested reverse-build-dependencies on "bnd", "osgi-compendium" and "maven-bundle-plugin"
  * 176 packages build successfully without modification
  * 15 packages already FTBFS before my work:
    * activemq
    * activemq-protobuf
    * apache-directory-server
    * apache-mime4j
    * avro-java
    * cobertura
    * gradle
    * hawtbuf
    * jruby
    * libcommons-jexl2-java
    * maven-bundle-plugin
    * mockito
    * mustache-java
    * openjpa
    * tika
  * 4 packages need fixes:
    * felix-bundlerepository (done)
    * jboss-xnio
    * libquartz2-java
    * maven-bundle-plugin

Here is the summary of significant changes I made to the package:

* Added rules to build more artifacts
  * aQute.libg
  * biz.aQute.remote
  * biz.aQute.repository
  * biz.aQute.resolve
  * biz.aQute.tester
  * org.osgi.impl.bundle.repoindex.api
  * org.osgi.impl.bundle.repoindex.lib
  * The Gradle plugin (But not installing it)
* Changed the artifact/group IDs to match the upstream
  * E.g. biz.aQute:bnd => biz.aQute.bnd:biz.aQute.bnd
* Switched to use a simpler "get-orig-source" approach using "uscan" + "d/copyright"

The Gradle plugin obviously have a runtime dependency on Gradle, so it is better be put in a separated package. I'll leave it to the next update, so this time we can bypass FTP-Master.

During the update I found some issues:

* "bnd" hardcodes its data directory as "~/.bnd" which causes errors under "fakeroot" [5]
* I have no idea how to exclude certain Java source in "*.bnd" files, so I had to delete them. [6]

So far I have fixed "felix-bundlerepository", and I will fix the rest of the 3 packages. However I don't want to fix those packages that already FTBFS before this, as they tend to have other issues and fixing "bnd"-related problems will likely be trivial.

Can somebody grant me upload permission to "osgi-compendium" so that I can deal with it myself? I will signal you once other packages are ready. Thank you!

[1]: https://tracker.debian.org/pkg/bnd
[2]: https://salsa.debian.org/seamlik-guest/bnd/tree/3.5
[3]: https://anonscm.debian.org/cgit/pkg-java/felix-resolver.git
[4]: https://anonscm.debian.org/cgit/pkg-java/osgi-compendium.git
[5]: https://github.com/bndtools/bnd/issues/2327
[6]: https://salsa.debian.org/seamlik-guest/bnd/blob/920033023392d0fe9e7c01a3b3f39dc42aeaf3b8/debian/rules#L51

[toc] | [next] | [standalone]

#10351

FromMarkus Koschany <apo@debian.org>
Date2018-03-04 16:00 +0100
Message-ID<vpDhf-5XK-1@gated-at.bofh.it>
In reply to#10350

[Multipart message — attachments visible in raw view] — view raw

Am 04.03.2018 um 15:41 schrieb 殷啟聰 | Kai-Chung Yan:
> I have been working on updating "bnd"[1] to 3.5.0. I had to say this time it is much smoother than what Markus did 2 years ago. Here is a summary of the progress so far:

Wow! Excellent work. I will grant you upload permissions for
osgi-compendium. I also intend to NMU jtb today. This should fix a few
of the FTBFS you have mentioned.

Regards,

Markus

[toc] | [prev] | [next] | [standalone]

#10352

FromEmmanuel Bourg <ebourg@apache.org>
Date2018-03-05 13:50 +0100
Message-ID<vpXJ0-2Kt-5@gated-at.bofh.it>
In reply to#10350
Le 04/03/2018 à 15:41, 殷啟聰 | Kai-Chung Yan a écrit :
> I have been working on updating "bnd"[1] to 3.5.0. I had to say this time it is much smoother than what Markus did 2 years ago. Here is a summary of the progress so far:

Thanks a lot for tackling this transition!


> * All changes to "bnd" are now temporarily stored on Salsa [2]

For now I recommended updating the repository on alioth. I made good
progress on the Salsa migration, I'll post more on this later.


> * Tested reverse-build-dependencies on "bnd", "osgi-compendium" and "maven-bundle-plugin"
>   * 176 packages build successfully without modification
>   * 15 packages already FTBFS before my work:
>   * 4 packages need fixes:

The success rate is encouraging. Assuming maven-bundle-plugin works fine
I think the package can be uploaded to unstable.


> * Changed the artifact/group IDs to match the upstream
>   * E.g. biz.aQute:bnd => biz.aQute.bnd:biz.aQute.bnd

Did you also add a relocation of the old coordinates to the new ones?


> * "bnd" hardcodes its data directory as "~/.bnd" which causes errors under "fakeroot" [5]

I think setting the user.home property should allow you to change this
directory. gradle-debian-helper does that [1].

Emmanuel Bourg

[1]
https://anonscm.debian.org/cgit/pkg-java/gradle-debian-helper.git/tree/gradle-helper-plugin/src/main/perl/gradle.pm#n36

[toc] | [prev] | [next] | [standalone]

#10355

From殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>
Date2018-03-10 07:50 +0100
Message-ID<vrGum-1GI-1@gated-at.bofh.it>
In reply to#10352

[Multipart message — attachments visible in raw view] — view raw

I put it on Salsa just in case things go south. I'll push them to Alioth when everything's ready.

Without the relocation, that would have been hundreds of FTBFS instead. :) BTW, thanks again for adding this super handy feature!

I also took your advice to change the HOME directory. Now it works.

A little update on the progress: I prepared a "maven-dependency-tree-2" package [1] for "maven-bundle-plugin". It builds fine now, so are its 174 reverse-build-dependencies. Thanks to Markus, the FTBFS are now limited to:

* apache-directory-server
* jackson-dataformat-yaml
* jruby
* openhft-lang
* tika

These already FTBFS before "bnd" 3.x, so I'll leave them to their maintainers. All I need to fix are:

* jboss-xnio [2]
* felix-bundlerepository [3]

Which are already done and the changes pushed. Can someone grant me permission on this 2 packages so that I can deal with them myself?

Also, can someone review "maven-dependency-tree-2"? Thank you so much.

I'm pushing the changes of "bnd" to Alioth soon.

[1]: https://bugs.debian.org/892519
[2]: https://anonscm.debian.org/cgit/pkg-java/jboss-xnio.git/commit/?id=8b4322e0d0717a6e581fd6cb8cc666a95b992e42
[3]: https://anonscm.debian.org/cgit/pkg-java/felix-bundlerepository.git/commit/?id=563fd1d2a776a4ddba8776693312cd61bebf2937

Emmanuel Bourg 於 2018年03月05日 星期一 08:44 下午 寫道:
> Le 04/03/2018 à 15:41, 殷啟聰 | Kai-Chung Yan a écrit :
>> I have been working on updating "bnd"[1] to 3.5.0. I had to say this time it is much smoother than what Markus did 2 years ago. Here is a summary of the progress so far:
> Thanks a lot for tackling this transition!
>
>
>> * All changes to "bnd" are now temporarily stored on Salsa [2]
> For now I recommended updating the repository on alioth. I made good
> progress on the Salsa migration, I'll post more on this later.
>
>
>> * Tested reverse-build-dependencies on "bnd", "osgi-compendium" and "maven-bundle-plugin"
>>   * 176 packages build successfully without modification
>>   * 15 packages already FTBFS before my work:
>>   * 4 packages need fixes:
> The success rate is encouraging. Assuming maven-bundle-plugin works fine
> I think the package can be uploaded to unstable.
>
>
>> * Changed the artifact/group IDs to match the upstream
>>   * E.g. biz.aQute:bnd => biz.aQute.bnd:biz.aQute.bnd
> Did you also add a relocation of the old coordinates to the new ones?
>
>
>> * "bnd" hardcodes its data directory as "~/.bnd" which causes errors under "fakeroot" [5]
> I think setting the user.home property should allow you to change this
> directory. gradle-debian-helper does that [1].
>
> Emmanuel Bourg
>
> [1]
> https://anonscm.debian.org/cgit/pkg-java/gradle-debian-helper.git/tree/gradle-helper-plugin/src/main/perl/gradle.pm#n36

[toc] | [prev] | [next] | [standalone]

#10356

FromEmmanuel Bourg <ebourg@apache.org>
Date2018-03-10 10:20 +0100
Message-ID<vrIPw-3WN-19@gated-at.bofh.it>
In reply to#10355
Le 10/03/2018 à 07:45, 殷啟聰 | Kai-Chung Yan a écrit :

> Thanks to Markus, the FTBFS are now limited to:
> 
> * apache-directory-server
> * jackson-dataformat-yaml
> * jruby
> * openhft-lang
> * tika

What kind of error do you get with these packages?


> These already FTBFS before "bnd" 3.x, so I'll leave them to their maintainers. All I need to fix are:
> 
> * jboss-xnio [2]
> * felix-bundlerepository [3]
> 
> Which are already done and the changes pushed. Can someone grant me permission on this 2 packages so that I can deal with them myself?

Done


> Also, can someone review "maven-dependency-tree-2"? Thank you so much.

I'll take care of it.

Emmanuel Bourg

[toc] | [prev] | [next] | [standalone]

#10363

From殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>
Date2018-03-14 07:20 +0100
Message-ID<vt7Vv-Gi-1@gated-at.bofh.it>
In reply to#10356

[Multipart message — attachments visible in raw view] — view raw

I pushed a change to rename all JAR names to "bnd-*.jar".

Emmanuel Bourg 於 2018年03月10日 星期六 05:14 下午 寫道:
> Le 10/03/2018 à 07:45, 殷啟聰 | Kai-Chung Yan a écrit :
>
>> Thanks to Markus, the FTBFS are now limited to:
>>
>> * apache-directory-server
>> * jackson-dataformat-yaml
>> * jruby
>> * openhft-lang
>> * tika
> What kind of error do you get with these packages?
>
>
>> These already FTBFS before "bnd" 3.x, so I'll leave them to their maintainers. All I need to fix are:
>>
>> * jboss-xnio [2]
>> * felix-bundlerepository [3]
>>
>> Which are already done and the changes pushed. Can someone grant me permission on this 2 packages so that I can deal with them myself?
> Done
>
>
>> Also, can someone review "maven-dependency-tree-2"? Thank you so much.
> I'll take care of it.
>
> Emmanuel Bourg

[toc] | [prev] | [next] | [standalone]

#10364

FromEmmanuel Bourg <ebourg@apache.org>
Date2018-03-14 14:50 +0100
Message-ID<vteWZ-5gU-1@gated-at.bofh.it>
In reply to#10363
Le 14/03/2018 à 07:12, 殷啟聰 | Kai-Chung Yan a écrit :
> I pushed a change to rename all JAR names to "bnd-*.jar".

Could you also push the updated debian/changelog file?

[toc] | [prev] | [next] | [standalone]

#10365

From殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com>
Date2018-03-15 14:00 +0100
Message-ID<vtAEb-2M0-23@gated-at.bofh.it>
In reply to#10364

[Multipart message — attachments visible in raw view] — view raw

Done.

Emmanuel Bourg 於 2018年03月14日 星期三 09:46 下午 寫道:
> Le 14/03/2018 à 07:12, 殷啟聰 | Kai-Chung Yan a écrit :
>> I pushed a change to rename all JAR names to "bnd-*.jar".
> Could you also push the updated debian/changelog file?

[toc] | [prev] | [next] | [standalone]

#10372

FromTiago Daitx <tiago.daitx@canonical.com>
Date2018-03-19 23:10 +0100
Message-ID<vvb8B-42r-1@gated-at.bofh.it>
In reply to#10356
Hi,

What's missing to get the new maven-bundle-plugin +
maven-dependency-tree-2? Is there anything I can help with?

I have been able to fetch and build maven-dependency-tree-2 from git,
but my first try to build maven-bundle-plugin by simply changing the
build-depends to maven-dependency-tree-2-java failed with:

Failed to execute goal on project maven-bundle-plugin: Could not
resolve dependencies for project
org.apache.felix:maven-bundle-plugin:maven-plugin:2.5.4: Cannot access
central (https://repo.maven.apache.org/maven2) in offline mode and the
artifact org.apache.maven.shared:maven-dependency-tree:jar:debian has
not been downloaded from it before. -> [Help 1]

which I'm looking into right now.

Regards,
Tiago

On Sat, Mar 10, 2018 at 10:14 AM, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 10/03/2018 à 07:45, 殷啟聰 | Kai-Chung Yan a écrit :
>
>> Thanks to Markus, the FTBFS are now limited to:
>>
>> * apache-directory-server
>> * jackson-dataformat-yaml
>> * jruby
>> * openhft-lang
>> * tika
>
> What kind of error do you get with these packages?
>
>
>> These already FTBFS before "bnd" 3.x, so I'll leave them to their maintainers. All I need to fix are:
>>
>> * jboss-xnio [2]
>> * felix-bundlerepository [3]
>>
>> Which are already done and the changes pushed. Can someone grant me permission on this 2 packages so that I can deal with them myself?
>
> Done
>
>
>> Also, can someone review "maven-dependency-tree-2"? Thank you so much.
>
> I'll take care of it.
>
> Emmanuel Bourg
>



-- 
Tiago Stürmer Daitx
Software Engineer
tiago.daitx@canonical.com

PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE

[toc] | [prev] | [next] | [standalone]

#10373

From殷啟聰 <seamlikok@gmail.com>
Date2018-03-20 02:20 +0100
Message-ID<vve6t-5Q7-3@gated-at.bofh.it>
In reply to#10372

[Multipart message — attachments visible in raw view] — view raw

I also imported 3.5.0 release of "maven-bundle-plugin" and did some hack on
it, but I have yet to push the changes... Also, Emmanuel found a patch from
Fedora that brings compatibility of "maven-dependency-tree" 3.x, I'm about
to test it.

I'm gonna push the changes later today.

在 2018年3月20日週二 06:03，Tiago Daitx <tiago.daitx@canonical.com> 寫道：

> Hi,
>
> What's missing to get the new maven-bundle-plugin +
> maven-dependency-tree-2? Is there anything I can help with?
>
> I have been able to fetch and build maven-dependency-tree-2 from git,
> but my first try to build maven-bundle-plugin by simply changing the
> build-depends to maven-dependency-tree-2-java failed with:
>
> Failed to execute goal on project maven-bundle-plugin: Could not
> resolve dependencies for project
> org.apache.felix:maven-bundle-plugin:maven-plugin:2.5.4: Cannot access
> central (https://repo.maven.apache.org/maven2) in offline mode and the
> artifact org.apache.maven.shared:maven-dependency-tree:jar:debian has
> not been downloaded from it before. -> [Help 1]
>
> which I'm looking into right now.
>
> Regards,
> Tiago
>
> On Sat, Mar 10, 2018 at 10:14 AM, Emmanuel Bourg <ebourg@apache.org>
> wrote:
> > Le 10/03/2018 à 07:45, 殷啟聰 | Kai-Chung Yan a écrit :
> >
> >> Thanks to Markus, the FTBFS are now limited to:
> >>
> >> * apache-directory-server
> >> * jackson-dataformat-yaml
> >> * jruby
> >> * openhft-lang
> >> * tika
> >
> > What kind of error do you get with these packages?
> >
> >
> >> These already FTBFS before "bnd" 3.x, so I'll leave them to their
> maintainers. All I need to fix are:
> >>
> >> * jboss-xnio [2]
> >> * felix-bundlerepository [3]
> >>
> >> Which are already done and the changes pushed. Can someone grant me
> permission on this 2 packages so that I can deal with them myself?
> >
> > Done
> >
> >
> >> Also, can someone review "maven-dependency-tree-2"? Thank you so much.
> >
> > I'll take care of it.
> >
> > Emmanuel Bourg
> >
>
>
>
> --
> Tiago Stürmer Daitx
> Software Engineer
> tiago.daitx@canonical.com
>
> PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
> Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE
>

[toc] | [prev] | [next] | [standalone]

#10375

FromTiago Daitx <tiago.daitx@canonical.com>
Date2018-03-20 12:20 +0100
Message-ID<vvnt8-3tH-11@gated-at.bofh.it>
In reply to#10373
On Tue, Mar 20, 2018 at 2:11 AM, 殷啟聰 <seamlikok@gmail.com> wrote:
> I also imported 3.5.0 release of "maven-bundle-plugin" and did some hack on
> it, but I have yet to push the changes... Also, Emmanuel found a patch from
> Fedora that brings compatibility of "maven-dependency-tree" 3.x, I'm about
> to test it.

That's awesome, nice work there folks.

>
> I'm gonna push the changes later today.

Ack, thanks for the heads up.

>
>
> 在 2018年3月20日週二 06:03，Tiago Daitx <tiago.daitx@canonical.com> 寫道：
>>
>> Hi,
>>
>> What's missing to get the new maven-bundle-plugin +
>> maven-dependency-tree-2? Is there anything I can help with?
>>
>> I have been able to fetch and build maven-dependency-tree-2 from git,
>> but my first try to build maven-bundle-plugin by simply changing the
>> build-depends to maven-dependency-tree-2-java failed with:
>>
>> Failed to execute goal on project maven-bundle-plugin: Could not
>> resolve dependencies for project
>> org.apache.felix:maven-bundle-plugin:maven-plugin:2.5.4: Cannot access
>> central (https://repo.maven.apache.org/maven2) in offline mode and the
>> artifact org.apache.maven.shared:maven-dependency-tree:jar:debian has
>> not been downloaded from it before. -> [Help 1]
>>
>> which I'm looking into right now.
>>
>> Regards,
>> Tiago
>>
>> On Sat, Mar 10, 2018 at 10:14 AM, Emmanuel Bourg <ebourg@apache.org>
>> wrote:
>> > Le 10/03/2018 à 07:45, 殷啟聰 | Kai-Chung Yan a écrit :
>> >
>> >> Thanks to Markus, the FTBFS are now limited to:
>> >>
>> >> * apache-directory-server
>> >> * jackson-dataformat-yaml
>> >> * jruby
>> >> * openhft-lang
>> >> * tika
>> >
>> > What kind of error do you get with these packages?
>> >
>> >
>> >> These already FTBFS before "bnd" 3.x, so I'll leave them to their
>> >> maintainers. All I need to fix are:
>> >>
>> >> * jboss-xnio [2]
>> >> * felix-bundlerepository [3]
>> >>
>> >> Which are already done and the changes pushed. Can someone grant me
>> >> permission on this 2 packages so that I can deal with them myself?
>> >
>> > Done
>> >
>> >
>> >> Also, can someone review "maven-dependency-tree-2"? Thank you so much.
>> >
>> > I'll take care of it.
>> >
>> > Emmanuel Bourg
>> >
>>
>>
>>
>> --
>> Tiago Stürmer Daitx
>> Software Engineer
>> tiago.daitx@canonical.com
>>
>> PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
>> Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE



-- 
Tiago Stürmer Daitx
Software Engineer
tiago.daitx@canonical.com

PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com)
Fingerprint = 45D0 FE5A 8109 1E91 866E  8CA4 1931 8D5E F5B2 13BE

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.java

csiph-web