Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.maint.java > #11866 > unrolled thread

jni launcher library

Back to article view | Back to linux.debian.maint.java

Contents

  jni launcher library Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2020-09-29 18:20 +0200
    Re: jni launcher library Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2020-09-29 21:50 +0200
    Re: jni launcher library Emmanuel Bourg <ebourg@apache.org> - 2020-10-02 08:30 +0200
      Re: jni launcher library Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2020-10-02 18:20 +0200
        Re: jni launcher library Emmanuel Bourg <ebourg@apache.org> - 2020-10-04 16:30 +0200
          Re: jni launcher library Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2020-10-04 23:10 +0200
            Re: jni launcher library Emmanuel Bourg <ebourg@apache.org> - 2020-10-05 14:20 +0200
              Re: jni launcher library Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2020-10-05 15:30 +0200

#11866 — jni launcher library

Hi Emmanuel,

I was looking at one of the last problems for #943552, it was not
displaying the splash screen. And, after a little bit of debugging it
seems it was unable to find the JNIBridge as it was not finding the
launcher library.
The launcher library code is part of "equinox-framework" and lives at
'features/org.eclipse.equinox.executable.feature/library/gtk' but its
not built and packaged. I get the splash screen working when I build
it and use it as a launcher library. Just wanted to confirm if you
left it out intentionally? Is there any problem if I add it as a
package name  "libequinox-launcher-jni" ?


-- 
Regards
Sudip

[toc] | [next] | [standalone]

#11867

On Tue, Sep 29, 2020 at 5:10 PM Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
>
> Hi Emmanuel,
>
<snip>
> Is there any problem if I add it as a
> package name  "libequinox-launcher-jni" ?

Sorry, it should be libequinox-executable-jni.


-- 
Regards
Sudip

[toc] | [prev] | [next] | [standalone]

#11870

Le 29.09.2020 18:10, Sudip Mukherjee a écrit :

> The launcher library code is part of "equinox-framework" and lives at
> 'features/org.eclipse.equinox.executable.feature/library/gtk' but its
> not built and packaged. I get the splash screen working when I build
> it and use it as a launcher library. Just wanted to confirm if you
> left it out intentionally? Is there any problem if I add it as a
> package name  "libequinox-launcher-jni" ?

No objection to add the jni package, but be careful with the version of 
the binary package, it has to match the version of the associated -java 
package. The version of the eclipse packages is heavily tinkered to use 
the OSGi bundle version instead of the tag version. So you'll need a 
tweak in debian/rules for the jni package. I can get a look before you 
upload if you aren't sure to do it right.

Emmanuel Bourg

[toc] | [prev] | [next] | [standalone]

#11871

Hi Emmanuel,

On Thu, Oct 1, 2020 at 11:42 PM Emmanuel Bourg <ebourg@apache.org> wrote:
>
> Le 29.09.2020 18:10, Sudip Mukherjee a écrit :
>
> > The launcher library code is part of "equinox-framework" and lives at
> > 'features/org.eclipse.equinox.executable.feature/library/gtk' but its
> > not built and packaged. I get the splash screen working when I build
> > it and use it as a launcher library. Just wanted to confirm if you
> > left it out intentionally? Is there any problem if I add it as a
> > package name  "libequinox-launcher-jni" ?
>
> No objection to add the jni package, but be careful with the version of
> the binary package, it has to match the version of the associated -java
> package. The version of the eclipse packages is heavily tinkered to use
> the OSGi bundle version instead of the tag version. So you'll need a
> tweak in debian/rules for the jni package. I can get a look before you
> upload if you aren't sure to do it right.

Thanks. I did it in a fairly simple (hacky) way and have pushed to
'sudip/jni' branch for you to have a look first.
It is now building 'libequinox-executable-jni_4.17-2_amd64.deb' and
'libequinox-executable-jni-dbgsym_4.17-2_amd64.deb' for this change.

Can you please have a look at the branch when you get some time..

-- 
Regards
Sudip

[toc] | [prev] | [next] | [standalone]

#11873

Le 02.10.2020 18:14, Sudip Mukherjee a écrit :

> Thanks. I did it in a fairly simple (hacky) way and have pushed to
> 'sudip/jni' branch for you to have a look first.
> It is now building 'libequinox-executable-jni_4.17-2_amd64.deb' and
> 'libequinox-executable-jni-dbgsym_4.17-2_amd64.deb' for this change.
> 
> Can you please have a look at the branch when you get some time..

I think the version should be picked from the feature.xml file, so the 
package would have the version 3.8.900+eclipse4.17-2.

Emmanuel Bourg

[toc] | [prev] | [next] | [standalone]

#11874

On Sun, Oct 4, 2020 at 3:03 PM Emmanuel Bourg <ebourg@apache.org> wrote:
>
> Le 02.10.2020 18:14, Sudip Mukherjee a écrit :
>
> > Thanks. I did it in a fairly simple (hacky) way and have pushed to
> > 'sudip/jni' branch for you to have a look first.
> > It is now building 'libequinox-executable-jni_4.17-2_amd64.deb' and
> > 'libequinox-executable-jni-dbgsym_4.17-2_amd64.deb' for this change.
> >
> > Can you please have a look at the branch when you get some time..
>
> I think the version should be picked from the feature.xml file, so the
> package would have the version 3.8.900+eclipse4.17-2.

I have modified d/rules and added the version in 'dh_gencontrol' and
you can see it in sudip/jni branch. It now builds
libequinox-executable-jni_3.8.900+eclipse4.17-2_amd64.deb package. Not
sure if there is some simple way to extract the version from
feature.xml file and use.
Can you please check again. I will also build in different porter
boxes to verify it builds properly in all of them.


-- 
Regards
Sudip

[toc] | [prev] | [next] | [standalone]

#11875

Le 04.10.2020 23:02, Sudip Mukherjee a écrit :
> 
> I have modified d/rules and added the version in 'dh_gencontrol' and
> you can see it in sudip/jni branch. It now builds
> libequinox-executable-jni_3.8.900+eclipse4.17-2_amd64.deb package. Not
> sure if there is some simple way to extract the version from
> feature.xml file and use.

Yes there is, we can use xmlstartlet:

   xmlstarlet sel -t -v '//feature/@version' 
features/org.eclipse.equinox.executable.feature/feature.xml

I've pushed the modification to the sudip/jni branch with a few other 
changes.

Emmanuel Bourg

[toc] | [prev] | [next] | [standalone]

#11876

On Mon, Oct 5, 2020 at 11:17 AM Emmanuel Bourg <ebourg@apache.org> wrote:
>
> Le 04.10.2020 23:02, Sudip Mukherjee a écrit :
> >
> > I have modified d/rules and added the version in 'dh_gencontrol' and
> > you can see it in sudip/jni branch. It now builds
> > libequinox-executable-jni_3.8.900+eclipse4.17-2_amd64.deb package. Not
> > sure if there is some simple way to extract the version from
> > feature.xml file and use.
>
> Yes there is, we can use xmlstartlet:
>
>    xmlstarlet sel -t -v '//feature/@version'
> features/org.eclipse.equinox.executable.feature/feature.xml
>
> I've pushed the modification to the sudip/jni branch with a few other
> changes.

Thanks a lot.


-- 
Regards
Sudip

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.maint.java

csiph-web