Groups > linux.debian.maint.java > #12715

Re: Bug#1054361: ITP: jruby-jzlib

Path	csiph.com!weretis.net!feeder8.news.weretis.net!fu-berlin.de!bofh.it!news.nic.it!robomod
From	Emmanuel Bourg <ebourg@apache.org>
Newsgroups	linux.debian.maint.java
Subject	Re: Bug#1054361: ITP: jruby-jzlib
Date	Tue, 24 Oct 2023 17:10:01 +0200
Message-ID	<HsrcB-xM4-3@gated-at.bofh.it> (permalink)
References	<HrHW9-4fN-1@gated-at.bofh.it> <Hspu9-wA9-1@gated-at.bofh.it> <Hsqgx-x7A-3@gated-at.bofh.it> <HsqzT-xeA-1@gated-at.bofh.it>
X-Mailbox-Line	From debian-java-request@lists.debian.org Tue Oct 24 15:02:47 2023
Old-Return-Path	<ebourg@apache.org>
X-Amavis-Spam-Status	No, score=-13.348 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, FVGT_m_MULTI_ODD=0.02, LDO_WHITELIST=-5, NICE_REPLY_A=-3.058, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
X-Policyd-Weight	using cached result; rate:hard: -5.5
Authentication-Results	apache.org; auth=none
MIME-Version	1.0
User-Agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1
Content-Language	en-US
Content-Type	text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding	8bit
X-Mailing-List	<debian-java@lists.debian.org> archive/latest/23399
List-ID	<debian-java.lists.debian.org>
List-URL	<https://lists.debian.org/debian-java/>
List-Archive	https://lists.debian.org/msgid-search/35ff36e1-dcd6-8817-f963-dcff12a25272@apache.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
Sender	robomod@news.nic.it
X-Original-Date	Tue, 24 Oct 2023 17:02:24 +0200
X-Original-Message-ID	<35ff36e1-dcd6-8817-f963-dcff12a25272@apache.org>
X-Original-References	<08e5cc7f-a158-4af5-9fe7-e0a5cf74d8bf@riseup.net> <63f1b611-474a-4541-aea4-750d13fb9c9b@riseup.net> <b8b607fc-a363-23e5-b445-a2fdb8007183@apache.org> <b1b3940c-d37a-43ae-8394-03700c170922@riseup.net>
Xref	csiph.com linux.debian.maint.java:12715

Show key headers only | View raw

Le 24/10/2023 à 16:28, Jérôme Charaoui a écrit :

> Right, my thinking was to use the same path usj/jzlib.jar to signal the 
> classpath conflict. Otherwise, we can install it to usj/jruby-jzlib.jar 
> and not make the packages conflict, but I'm not sure what would happen 
> if both were installed at the same time, at the JVM-level.

If both jars are loaded in the classpath the JVM will randomly resolve 
the classes from the 2 files, that may lead to runtime errors if the two 
implementations are not binary compatible.


> There are some (small) code changes as well, here is a pkgdiff report: 
> https://paste.lib3.net/lavamind/2023-10-24-gBV6KdXXUJ4R0DlxXjjnjz0RmA9OCJ6goNYKux5c03M/changes_report.html

Looking at the changes :

* DeflaterOutputStream.java: exception message changed
* GZIPHeader.java: private 'time' variable removed
* GZIPInputStream.java: getModifiedTime method added (typo fix)
* Inflate.java: call a setter instead of setting the variable directly
* ZStream.java: comment change

The only notable change is the addition of getModifiedTime(), we can add 
it to the existing package.


> In addition, I believe there may be more substantive changes in the 
> future since there are zlib-related bugs reported against JRuby which 
> may lead to further changes in jruby-jzlib, see 
> https://github.com/jruby/jruby/issues/6613

Good point. If the code diverges significantly an independent package is 
perfectly justified then.

Emmanuel Bourg

Back to linux.debian.maint.java | Previous | Next — Previous in thread | Next in thread | Find similar

Thread

Fwd: Bug#1054361: ITP: jruby-jzlib Jérôme Charaoui <jerome@riseup.net> - 2023-10-24 15:20 +0200
  Re: Bug#1054361: ITP: jruby-jzlib Emmanuel Bourg <ebourg@apache.org> - 2023-10-24 16:10 +0200
    Re: Bug#1054361: ITP: jruby-jzlib Jérôme Charaoui <jerome@riseup.net> - 2023-10-24 16:30 +0200
      Re: Bug#1054361: ITP: jruby-jzlib Emmanuel Bourg <ebourg@apache.org> - 2023-10-24 17:10 +0200
        Re: Bug#1054361: ITP: jruby-jzlib Jérôme Charaoui <jerome@riseup.net> - 2023-10-24 17:30 +0200

csiph-web