Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > gnu.groff.bug > #1832

[bug #58314] [PATCH] preconv.cpp: Add block delimiters for an if-clause

Show key headers only | View raw

URL:
  <https://savannah.gnu.org/bugs/?58314>

                 Summary: [PATCH] preconv.cpp: Add block delimiters for an
if-clause
                 Project: GNU troff
            Submitted by: bjarniig
            Submitted on: Wed 06 May 2020 08:39:34 PM UTC
                Category: Core
                Severity: 3 - Normal
              Item Group: Warning/Suspicious behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

>From bfda94f0ffbf1cce3a35370f650564affe4a5535 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Wed, 6 May 2020 20:29:43 +0000
Subject: [PATCH] preconv.cpp: Add block delimiters for an if-clause

  Warning from the compiler:

../src/preproc/preconv/preconv.cpp: In function 'char*
get_late_coding_tag(FILE*)':
../src/preproc/preconv/preconv.cpp:959:6: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wdangling-else]
  959 |   if (fseek(fp, -limit, SEEK_END) != 0)
      |      ^

  Always use block delimiters to help the compiler to know explicitly
what belongs to a block.

  Indention is a pseudo (unreal) structure element, intended only for
humans.

  Compilers don't "see" nor do they count, how many tabs or space
characters there are in front of a command word.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/preproc/preconv/preconv.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/preproc/preconv/preconv.cpp
b/src/preproc/preconv/preconv.cpp
index b4da04d0..f068bad6 100644
--- a/src/preproc/preconv/preconv.cpp
+++ b/src/preproc/preconv/preconv.cpp
@@ -956,11 +956,12 @@ get_late_coding_tag(FILE *fp)
   if (fseek(fp, 0, SEEK_END) != 0)
     return NULL;
   // Seek to `limit` bytes from the end of the buffer, or the beginning.
-  if (fseek(fp, -limit, SEEK_END) != 0)
+  if (fseek(fp, -limit, SEEK_END) != 0) {
     if (errno == EINVAL)
       rewind(fp);
     else
       return NULL;
+  }
   char *tmpbuf = (char *) calloc(1, limit + 1 /* trailing '\0' */);
   if (!tmpbuf) {
     error("unable to allocate memory");
-- 
2.26.2
-verbatim





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58314>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/

Back to gnu.groff.bug | Previous | Next | Find similar

Thread

[bug #58314] [PATCH] preconv.cpp: Add block delimiters for an if-clause Bjarni Ingi Gislason <INVALID.NOREPLY@gnu.org> - 2020-05-06 16:39 -0400

csiph-web