Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #15730

Re: bind -X shows inactive bindings (bindings removed using bind -r)

From Chet Ramey <chet.ramey@case.edu>
Newsgroups gnu.bash.bug
Subject Re: bind -X shows inactive bindings (bindings removed using bind -r)
Date 2019-12-13 14:25 -0500
Message-ID <mailman.823.1576265143.1979.bug-bash@gnu.org> (permalink)
References <CAOdNpm8m-8NQVfWiCQX3CKPordxzZShx6K1_OLTbYg77gf5R=g@mail.gmail.com> <CAFLRLk9-QDjyX0v_9OGc364m_wadcma1_q+unWPXhiE0HUq6xw@mail.gmail.com> <029feb2c-77b4-d999-9cdf-f364a8a2f53c@case.edu>

Show all headers | View raw


On 12/12/19 8:04 AM, Koichi Murase wrote:

> I also would like to see this problem fixed.  In this February, I
> actually posted to this mailing list a patch fixing this problem (with
> another patch):
> 
> https://lists.gnu.org/archive/html/bug-bash/2019-02/msg00038.html
> 
> Although the first patch was applied to the devel branch, the second
> one which fixes this problem seems not to have been reviewed yet.  I
> updated the patch to fit the current devel branch.  I attach the
> updated patch.  Here is the description quoted from the mail:

I declined to apply this patch because, as you observe, it uses private
readline APIs. Bash doesn't do that. Nor did I think it was the right
approach to the problem.

> Note that in the attached patch the functions in Readline library,
> `_rl_get_keyname' and `_rl_untranslate_macro_value', were made public
> and used from Bash codes.  I think it is worth to make them a part of
> public interface of Readline library.

I'm not convinced.

I appreciate the reminder, though. This was still on my list of issues
to look at, so I took a look.

It takes maybe a dozen lines of code, and no modifications to readline,
to solve the problem with `bind -r'. There are a couple of other remaining
issues, but that one was easy.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar | Unroll thread


Thread

Re: bind -X shows inactive bindings (bindings removed using bind -r) Chet Ramey <chet.ramey@case.edu> - 2019-12-13 14:25 -0500

csiph-web