Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #14579

Re: error message for missing fi is not helpful

Path csiph.com!xmission!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!usenet.stanford.edu!not-for-mail
From Manuel Reiter <manuel.reiter@dwd.de>
Newsgroups gnu.bash.bug
Subject Re: error message for missing fi is not helpful
Date Fri, 14 Sep 2018 16:26:14 +0200
Lines 82
Approved bug-bash@gnu.org
Message-ID <mailman.783.1536935190.1284.bug-bash@gnu.org> (permalink)
References <12006574-8df4-d613-0603-51b77b703a3d@dwd.de> <3461cc07-6477-234b-83ea-30a6bc0c8d8c@case.edu> <5B99CB6D.5060108@tlinx.org>
NNTP-Posting-Host lists.gnu.org
Mime-Version 1.0
Content-Type multipart/mixed; boundary="------------F73683A027B772DBEC74E544"
X-Trace usenet.stanford.edu 1536935191 10297 208.118.235.17 (14 Sep 2018 14:26:31 GMT)
X-Complaints-To action@cs.stanford.edu
To bug-bash@gnu.org
Envelope-to bug-bash@gnu.org
X-Virus-Scanned by amavisd-new at csg.dwd.de
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
In-Reply-To <5B99CB6D.5060108@tlinx.org>
Content-Language uk-UA
X-detected-operating-system by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy]
X-Received-From 141.38.3.245
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.21
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <http://lists.gnu.org/archive/html/bug-bash/>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
Xref csiph.com gnu.bash.bug:14579

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On 13.09.2018 04:29, L A Walsh wrote:
> This isn't *exactly* what you wanted, but this gives the line number
> of the last unmatched statement (but doesn't tell you what the statement
> was).  The diff was against bash-4.4.23 (4.4 base w/23 patches)

Thank you for taking the time to look into this! There seems to be a 
problem with your code though: if word_top is zero and EOF_Reached is 
true, you set msg to msg0 without initializing msg0 first.

Reviving the code you commented out (your first attempt?) I came to the 
attached result. I also added if/fi to the compound commands tracked by 
word_top. There are probably others that I have missed missed.

> Anyway, if you store the word in a separate array where the line #
> is stored, you _could_ list the matching word, but I suspect just the
> line it started on would be enough for most users.

I totally agree with that.

Thanks and best regards,

   Manuel

Back to gnu.bash.bug | Previous | Next | Find similar | Unroll thread


Thread

Re: error message for missing fi is not helpful Manuel Reiter <manuel.reiter@dwd.de> - 2018-09-14 16:26 +0200

csiph-web