Re: [PATCH] unwind_prot.c: Avoid buffer overflow

From	Chet Ramey <chet.ramey@case.edu>
Newsgroups	gnu.bash.bug
Subject	Re: [PATCH] unwind_prot.c: Avoid buffer overflow
Date	2020-06-29 11:04 -0400
Organization	ITS, Case Western Reserve University
Message-ID	<mailman.654.1593443056.2574.bug-bash@gnu.org> (permalink)
References	<20200627211438.40013-1-jrtc27@jrtc27.com> <1f15d59b-4973-229f-d3c2-00e8c7a06283@case.edu>

Show all headers | View raw

On 6/27/20 5:14 PM, Jessica Clarke wrote:
> In unwind_protect_mem_internal, we must make sure to allocate at least a
> full UNWIND_ELT, even if the required size for desired_setting is less
> than the remaining padding in UNWIND_ELT. Otherwise when we come to
> memset it with 0xdf in unwind_frame_discard_internal we will overflow
> the allocation.

Thanks for the fix.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH] unwind_prot.c: Avoid buffer overflow Chet Ramey <chet.ramey@case.edu> - 2020-06-29 11:04 -0400

csiph-web