Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > gnu.bash.bug > #16787

Re: [PATCH] fc: trim range instead of erroring out

Path csiph.com!2.eu.feeder.erje.net!feeder.erje.net!news.uzoreto.com!goblin2!goblin3!goblin.stu.neva.ru!panix!usenet.stanford.edu!not-for-mail
From Chet Ramey <chet.ramey@case.edu>
Newsgroups gnu.bash.bug
Subject Re: [PATCH] fc: trim range instead of erroring out
Date Thu, 20 Aug 2020 11:43:09 -0400
Organization ITS, Case Western Reserve University
Lines 28
Approved bug-bash@gnu.org
Message-ID <mailman.485.1597938220.2469.bug-bash@gnu.org> (permalink)
References <bee8013d-39e9-7433-934f-89fce4134369@inlv.org> <b86c684a-64fc-e622-f5b0-16d382a1a27b@case.edu> <0a83590f-880b-ba7e-ccb7-6d0d424fb586@inlv.org> <b62d1eb7-7214-caf9-66b1-613c6ed9b3af@case.edu>
Reply-To chet.ramey@case.edu
NNTP-Posting-Host lists.gnu.org
Mime-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 7bit
X-Trace usenet.stanford.edu 1597938220 3758 209.51.188.17 (20 Aug 2020 15:43:40 GMT)
X-Complaints-To action@cs.stanford.edu
Cc chet.ramey@case.edu
To Martijn Dekker <martijn@inlv.org>, bug-bash@gnu.org
Envelope-to bug-bash@gnu.org
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1597938215; bh=pIyA87NUIFAlqmfdKK7sL7U4bMdYWVydCXmk9OXYKkg=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=wP2++iZYgJNsQRhpzyu/EwJkyydnAEgXbDlpr19Pek/fZQ/cGAq4cI/tH5im4SHPxb a929SE6YP0OMJjXgQtakAd5ShBzpMjIlBMHxct9t/vNEhLTNLAB2dhLxDOZnF7+Yp5o TOP1pvVNCL+31pRuPiV7x3qDVGegd32txgTzp25ipbAgwb7zmyFtd+S+zenMi1vZu7I gL686vhNzNAVk2HOWEJ4UOyFZ1W88bzqB83yTmyfoHzAWn+uNCpPI+GoH6Q3eo1nGaT LpNFX7nRu06uD2kzxZvuDLa9HgxQDX+3NWmZ2SBaLyA8WtZPyrInZqGAd06WPf7zz3d DAM3pgFg==
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1597938213; bh=4xYzrwT8to4WuPC3f3F68MV08Ub72TdhJHYwZsFOgWQ=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=zaVVvCXirMsL0qPTc03LyIwMUvyXkMr7cUeKi+JDN42IBSLYk73P8LMZlQaU0U1WlG uk3UEuzVZTiuEHQtbbs0NVUPj7sMPKetdx4M5cjWMbicYYL7LBzBsTJeuI3iQgFaF2v nvp/NTukhcjuqMOMHQkEBCubsTdIsG2J7dLNkC3UuXv6pPN5taFWdTW2ZC2aZH6eERT ugUSH1gzv1aNCZJlfbftpulMMBL3h4jxG0meeCu4iSSCk8TVunAsRKdcrj3CQRCZBEN u2RdrRc91MmnA18tD0x+xK4kmJ/CjY7ui8iPoBglEiS6zvdsKaI12PNSfbQFNbhMife mRfl8Bww==
DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=g-case; h=reply-to:cc:subject:to:references:from:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=4xYzrwT8to4WuPC3f3F68MV08Ub72TdhJHYwZsFOgWQ=; b=AbJEreKOusbIo1NM+KWsITYq0PtBrxCpz5Gysuts41u0oiBfL4CFSuTGbQGylrjRlA D549YK0rGwsLympEHXTURTZzbD/ZmtnRsdwr7fBTctVRH00D98H5qEU95O/dLPJ10PKX oU5G/+wGSKSjI64QALSKodhOmkngJdbUb3hQvvcFoHsfE552UL4dpfVFWZj4ILGPqcuw BNsUtH46yXKbB2gxYiP1S4KNB6b2hrK+X4bSFEGIQJVFN1oxCvnlv0WwLwKtY+mUsh1p vZudJ8Y8Dc3DQXOUvGpqnPs4YGHzbmJlq3xciX0a1mAWjXKel7qyHARAnVS/G497e2QG 8Sqw==
X-Google-DKIM-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:cc:subject:to:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=4xYzrwT8to4WuPC3f3F68MV08Ub72TdhJHYwZsFOgWQ=; b=VWCZdDC0Q5/NJ3hUEatiNlKNnVRCeo1y2F0G3ZH9plY2GLKsJmQwV7oX9lFvm2W5g1 HjnUzmpaDpvhX7W5EiiFytCeJdARraP5PX+pbKm8odxQa/OHvaKLDlER3aF98wZ0nkWv L1DSJiP0nrCb2hH4jjPmI5BOCU0jUe2aK/dUoB+22dr1SXgQ5TvRMXbzhxXQQk6T+DXS IZ7pT+XTrGmsmhovBlCb9OJ/2hn+ix3K9klSEyaPc5B4GN2GpzUc21hBjzYyY3gMCYdm yT5Hp704HKVQNXRR7jevoFjyjIE+eVStdKi0i/p7iJn2erb5hAokiF6IHqejDa7KNoZa QO6A==
X-Gm-Message-State AOAM530y5kbqaO3v6vKSjLj6yORLHOdGV43bnhHopODeQk9GvIll8Oa0 wyvvy5Xh0uRHnEVFN6BZqeut1OXp9jC4h8nQW/nIGhK6SQhyKXHVaWMSApcTnXHMvJEOYoGF7BT 1/sUMtMOkazU=
X-Received by 2002:a05:620a:1014:: with SMTP id z20mr3131657qkj.52.1597938213133; Thu, 20 Aug 2020 08:43:33 -0700 (PDT)
X-Google-Smtp-Source ABdhPJw4MHyJgcJ8iHgN1RwkaDVpeV3n08jgQVZKFECsBNkXNApcnXxGEMUdot3UwrKQIx7RODsFdA==
X-Received by 2002:a05:620a:1014:: with SMTP id z20mr3131630qkj.52.1597938212760; Thu, 20 Aug 2020 08:43:32 -0700 (PDT)
Autocrypt addr=chet.ramey@case.edu; prefer-encrypt=mutual; keydata= mQGiBEEOsGwRBACFa0A1oa71HSZLWxAx0svXzhOZNQZOzqHmSuGOG92jIpQpr8DpvgRh40Yp AwdcXb8QG1J5yGAKeevNE1zCFaA725vGSdHUyypHouV0xoWwukYO6qlyyX+2BZU+okBUqoWQ koWxiYaCSfzB2Ln7pmdys1fJhcgBKf3VjWCjd2XJTwCgoFJOwyBFJdugjfwjSoRSwDOIMf0D /iQKqlWhIO1LGpMrGX0il0/x4zj0NAcSwAk7LaPZbN4UPjn5pqGEHBlf1+xDDQCkAoZ/VqES GZragl4VqJfxBr29Ag0UDvNbUbXoxQsARdero1M8GiAIRc50hj7HXFoERwenbNDJL86GPLAQ OTGOCa4W2o29nFfFjQrsrrYHzVtyA/9oyKvTeEMJ7NA3VJdWcmn7gOu0FxEmSNhSoV1T4vP2 1Wf7f5niCCRKQLNyUy0wEApQi4tSysdz+AbgAc0b/bHYVzIf2uO2lIEZQNNt+3g2bmXgloWm W5fsm/di50Gm1l1Na63d3RZ00SeFQos6WEwLUHEB0yp6KXluXLLIZitEJLQwQ2hldCBSYW1l eSAoQ2FzZSBzdGFuZGFyZCkgPGNoZXQucmFtZXlAY2FzZS5lZHU+iF8EExECAB8FAkPi19EC GwMHCwkIBwMCAQMVAgMDFgIBAh4BAheAAAoJELtYafBk6nSrelkAn31Gsuib7GcCZHbv5L5t VKYR9LklAJ4hzUHKA49Z0QXR+qCb80osIcmPSbkBDQRBDrBvEAQAkK6TAOKBEM+EC4j6V/7o /riVZqcgU5cid2qG9TXdwNtD9a3kvA/ObZBO93sX59wc6Bnwo4VJxsOmMlpGrAjJsxNwg3QH akEtf8LXRbVpj5xStdmBdQZUhIQyalo/2/TZq5OijtddUQcL5cs70hTv/FpT3wUvr2Xr8rjF 41IFEz8AAwcD/A0CZEGlzIrT5WCBnl6xBog/8vKiUCbarByat3d1mL6DbizvKNXQRTC9E/vE dENAWCQCjr75Bu55xT8n3SXGtWdDC5xmZ/P3OBYORP8yl8H8I1FIosWOFirbIeYdZPq8SPD1 HL+EXo9zSiHVrrZRJ19ooCKKbSdXHFCY+aJG+0KZiEkEGBECAAkFAkEOsG8CGwwACgkQu1hp 8GTqdKvjcACfZlkVCDwaz/NTO9cy3t69oWpVPNwAnRwe0qk/WL/gfhH346xh5B3HFbFN
User-Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0
In-Reply-To <0a83590f-880b-ba7e-ccb7-6d0d424fb586@inlv.org>
Content-Language en-US
X-Mirapoint-IP-Reputation reputation=Good-1, source=Queried, refid=tid=0001.0A020303.5F3E90B6.005E, actions=tag
X-Mirapoint-IP-Reputation reputation=good-1, source=Fixed, refid=n/a, actions=tag
X-Junkmail-Status score=7/80, host=mpv1-2015.case.edu
X-Junkmail-PrAS-Raw score=7/80, refid=2.7.2:2020.8.20.144517:17:7.944, ip=, rules=__YOUTUBE_RCVD, DKIM_SIGNATURE, __X_GOOGLE_DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __SUBJ_REPLY, __PHISH_SPEAR_SUBJ_ALERT, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __TO_MALFORMED_2, __MULTIPLE_RCPTS_TO_X2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC1, __FROM_DOMAIN_IN_ANY_CC2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_MAILTO, __URI_WITH_PATH, __URI_ENDS_IN_SLASH, __URI_NO_WWW, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __MAIL_CHAIN, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138
Received-SPF pass client-ip=129.22.103.226; envelope-from=chet.ramey@case.edu; helo=mpv1-2015.case.edu
X-detected-operating-system by eggs.gnu.org: First seen = 2020/08/20 11:43:34
X-ACL-Warn Detected OS = Linux 2.4.x-2.6.x [generic]
X-Spam_score_int -43
X-Spam_score -4.4
X-Spam_bar ----
X-Spam_report (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no
X-Spam_action no action
X-BeenThere bug-bash@gnu.org
X-Mailman-Version 2.1.23
Precedence list
List-Id Bug reports for the GNU Bourne Again SHell <bug-bash.gnu.org>
List-Unsubscribe <https://lists.gnu.org/mailman/options/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=unsubscribe>
List-Archive <https://lists.gnu.org/archive/html/bug-bash>
List-Post <mailto:bug-bash@gnu.org>
List-Help <mailto:bug-bash-request@gnu.org?subject=help>
List-Subscribe <https://lists.gnu.org/mailman/listinfo/bug-bash>, <mailto:bug-bash-request@gnu.org?subject=subscribe>
X-Mailman-Original-Message-ID <b62d1eb7-7214-caf9-66b1-613c6ed9b3af@case.edu>
X-Mailman-Original-References <bee8013d-39e9-7433-934f-89fce4134369@inlv.org> <b86c684a-64fc-e622-f5b0-16d382a1a27b@case.edu> <0a83590f-880b-ba7e-ccb7-6d0d424fb586@inlv.org>
Xref csiph.com gnu.bash.bug:16787

Show key headers only | View raw


On 8/20/20 9:08 AM, Martijn Dekker wrote:
> Op 12-08-20 om 16:40 schreef Chet Ramey:
>> What's your opinion about what the `as appropriate' means? An out-of-range
>> `first' gets substituted with the first command in the history, and an out-
>> of-range `last' gets the last history entry?
> 
> Yes, that was my intention.

OK. That was my question, since that doesn't seem to happen. With your
patch (and even before), for instance, consider the following commands
on an empty history:

echo a
echo b
fc -l
fc -l 1002 1100

The first `fc' will list the echo commands. The second `fc' will list the
last command in the history, since both numbers are clamped at the end of
the history -- the range ends up being `last-last'.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar


Thread

Re: [PATCH] fc: trim range instead of erroring out Chet Ramey <chet.ramey@case.edu> - 2020-08-20 11:43 -0400

csiph-web