Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > gnu.bash.bug > #16108

Re: [PATCH] Add active mark, face support; activate mark on paste

Show key headers only | View raw

On 3/25/20 4:18 PM, Daniel Colascione wrote:

>> I haven't touched the face code in display.c. I'd like to find a simpler
>> way to do it: the patch seems to have a lot of overhead and adds more
>> complexity than I'd like at a time when I'm trying to make the redisplay
>> code simpler. I don't know of a better way to do that yet.
> 
> The redisplay code needs to track the intended attribute state of each
> character in the buffer. I'm not sure what simpler approach might be
> viable. Fat characters? You'd still have to support the old char*
> interface, and you'd still need something like puts_face to "propertize"
> any strings we add to the buffer. A face system preserves the existing
> format of the buffer at least, and the redisplay update code is a logical
> extension of the current diffing logic.

OK, I've finished the initial integration of your patches, and I've done
some initial minimal testing. The updated version is in the devel git
branch on savannah; please take a look and see if it passes your tests.

Chet

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Back to gnu.bash.bug | Previous | Next | Find similar

Thread

Re: [PATCH] Add active mark, face support; activate mark on paste Chet Ramey <chet.ramey@case.edu> - 2020-04-08 17:15 -0400

csiph-web